Your message dated Fri, 01 Aug 2008 21:47:15 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#457963: fixed in uswsusp 0.8-1 has caused the Debian Bug report #457963, regarding uswsusp: empty passphrase hangs installation and suspend-keygen to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 457963: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=457963 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: uswsusp Version: 0.3~cvs20060928-7etch1 Severity: normal Tags: patch *** Please type your report below this line *** I just played with uswsusp and it hanged during install if encrytion was enabled but passphrases were set empty -- I just pressed enter on passphrase questions. The hang shows up like this: ... Selecting previously deselected package uswsusp. (Reading database ... 142234 files and directories currently installed.) Unpacking uswsusp (from .../uswsusp_0.3~cvs20060928-7etch1_i386.deb) ... Setting up uswsusp (0.3~cvs20060928-7etch1) ... Generating RSA key, this may take a while ... and: PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 10456 root 25 0 2020 724 608 R 99.6 0.1 9:23.53 suspend-keygen To me this seems like a debconf usage bug. First in uswsusp.config, an empty string is accepted as a passphrase and written to debconf database. A fix would go somehow like this: --- uswsusp.config-orig 2007-12-27 15:28:43.000000000 +0200 +++ uswsusp.config 2007-12-27 15:38:32.000000000 +0200 @@ -190,9 +190,11 @@ db_go || true db_get uswsusp/RSA_passphrase - P1=$RET + # fail with empty passphrase + if [ -n "$RET" ]; then P1=$RET; fi db_get uswsusp/RSA_passphrase_v - P2=$RET + # fail with empty passphrase + if [ -n "$RET" ]; then P2=$RET; fi done fi fi Then in uswsusp.postinst the empty string is read from database and fed without checks to suspend-keygen. A fix could go somehow like this: --- /tmp/uswsusp/postinst 2007-09-18 00:21:59.000000000 +0300 +++ uswsusp.postinst 2007-12-27 16:36:31.000000000 +0200 @@ -94,13 +94,18 @@ KEYFILE=$RET db_get uswsusp/RSA_passphrase PASS=$RET - echo "Generating RSA key, this may take a while ..." - suspend-keygen <<EOFa &> /dev/null + if [ -n "$BITS" ] && [ -n "$KEYFILE" ] && [ -n "$PASS" ]; then + echo "Generating RSA key, this may take a while ..." + suspend-keygen <<EOFa &> /dev/null $BITS $PASS $PASS $KEYFILE EOFa + else echo "RSA_key_bits, RSA_key_file or RSA_passphrase empty!" + echo "suspend-keygen not called." + exit 1; + fi db_reset uswsusp/RSA_passphrase db_reset uswsusp/RSA_passphrase_v fi There might be something wrong with suspend-keygen argument parsing too, since a few times I got it to loop forever with $ /usr/sbin/suspend-keygen << EOF 1024 /dev/null EOF The output filled with questions and overwrote the history buffer too fast. This is not always repeatable. Perhaps suspend-keygen is waiting for the kernels entropy bucket to fill up or something. Anyway, at least the debconf stuff would be nice to fix. -Mikko -- System Information: Debian Release: 4.0 APT prefers stable APT policy: (990, 'stable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.18-5-686 Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15) Versions of packages uswsusp depends on: ii debconf [debconf-2.0] 1.5.11etch1 Debian configuration management sy ii libc6 2.3.6.ds1-13etch4 GNU C Library: Shared libraries ii libgcrypt11 1.2.3-2 LGPL Crypto library - runtime libr ii libgpg-error0 1.4-1 library for common error values an ii zlib1g 1:1.2.3-13 compression library - runtime Versions of packages uswsusp recommends: ii initramfs-tools 0.85h tools for generating an initramfs -- debconf information: uswsusp/suspend_loglevel: uswsusp/no_swap: uswsusp/early_writeout: true uswsusp/image_size: 487590461 uswsusp/snapshot_device: uswsusp/max_loglevel: uswsusp/shutdown_method: platform * uswsusp/encrypt: true uswsusp/RSA_key_bits: 1024 uswsusp/continue_without_swap: true uswsusp/compute_checksum: false uswsusp/no_snapshot: uswsusp/compress: true uswsusp/create_RSA_key: true uswsusp/RSA_key_file: /etc/uswsusp.key * uswsusp/resume_device: /dev/mapper/volgrp1-swap uswsusp/splash: false
--- End Message ---
--- Begin Message ---Source: uswsusp Source-Version: 0.8-1 We believe that the bug you reported is fixed in the latest version of uswsusp, which is due to be installed in the Debian FTP archive: uswsusp_0.8-1.diff.gz to pool/main/u/uswsusp/uswsusp_0.8-1.diff.gz uswsusp_0.8-1.dsc to pool/main/u/uswsusp/uswsusp_0.8-1.dsc uswsusp_0.8-1_i386.deb to pool/main/u/uswsusp/uswsusp_0.8-1_i386.deb uswsusp_0.8.orig.tar.gz to pool/main/u/uswsusp/uswsusp_0.8.orig.tar.gz A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Tim Dijkstra <[EMAIL PROTECTED]> (supplier of updated uswsusp package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Mon, 28 Jul 2008 23:22:26 +0200 Source: uswsusp Binary: uswsusp Architecture: source i386 Version: 0.8-1 Distribution: unstable Urgency: low Maintainer: Tim Dijkstra <[EMAIL PROTECTED]> Changed-By: Tim Dijkstra <[EMAIL PROTECTED]> Description: uswsusp - tools to use userspace software suspend provided by Linux Closes: 443434 443677 443818 444810 448450 448484 448536 450680 451249 452030 457963 458308 458566 458566 459844 467109 470314 470578 470861 471120 473160 474389 475367 487656 489939 490568 491418 Changes: uswsusp (0.8-1) unstable; urgency=low . [ Michael Biebl ] * New upstream release (closes: #459844). . [ Tim Dijkstra ] * The "Sorry this took so long, but a baby and a house got in the way" - release * Add patch for LFS (closes: #451249) * Remove use of grep in initramfs (closes: #443434) * New models in the whitelist (closes: #473160, #467109, #475367, #448484, #458566, #458566, #470314, #487656, #444810) * Ask shutdown_method at low priority (closes: #448536) * Change CONFIG_SOFTWARE_SUSPEND to CONFIG_HIBERNATION (closes: #452030, #470861) * Update whitelist for MacBook1,1 (closes: #458308) * Make CLI arguments consistent, update manpages (closes: #471120) * Document shutdown_method (closes: #490568) * Debconf translation updates (closes: #470578, #491418, #489939) Thanks: Vincent Zweije [nl], Martin Ågren [sv], Hideki Yamane [jp] * Do not hang when user supplies an empty passphrase. Thanks Mikko Rapeli for the patch. (closes: #457963) * Fix typo in README (closes: #448450) * Remove libzf licence from copyright file (closes: #474389) * Disable erroneous comress ratio output. This is fixed upstream by now, but it's not worth the trouble backporting IMHO. (closes: #443677, #443818) * Disable improved key handeling patch. This version is not working anymore. New version is applied upstream, no time for backporting before lenny, sorry. * Remove hack for devfs style node names (closes: #450680) Checksums-Sha1: 95620756f5a30503ef3a3d59c076875162a9bcce 1162 uswsusp_0.8-1.dsc acc9fb8f85d35f3e12c8406be1e958fc67ece01c 414135 uswsusp_0.8.orig.tar.gz 4dff5467115d79e89c23b9da9e6973dd89706e85 149864 uswsusp_0.8-1.diff.gz 96227d3337934c15ee1cde9c30b807a6bfa28f50 153938 uswsusp_0.8-1_i386.deb Checksums-Sha256: eca18c72faf09445ebcaeadef56d58c9a6da724bf56809d67c8c8cd0cb0a0a3f 1162 uswsusp_0.8-1.dsc a5ee1dcfeb05e9c2a63583d7518065d42dc83264144359a2456fd8b9c71e63ee 414135 uswsusp_0.8.orig.tar.gz 2de2e9c3f2428f81eac88680587cd17b9d9379191024c1286a4be0c9267725f0 149864 uswsusp_0.8-1.diff.gz d6e80f1de75863e97ccc91613c3d69a7ad0bc896ef29c595851fb852a8addbbe 153938 uswsusp_0.8-1_i386.deb Files: b016937d3f72297544dd0d6ec26305d4 1162 admin optional uswsusp_0.8-1.dsc c81817b2ba2be899cdb32c00de016bff 414135 admin optional uswsusp_0.8.orig.tar.gz 8c94adb41542bb0c152c9a4378a4241c 149864 admin optional uswsusp_0.8-1.diff.gz fea7d908a37cf7d9d64be40f470c0f0d 153938 admin optional uswsusp_0.8-1_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkiTgHQACgkQlR+JLH/tVJutWQCfX2vgTqZv8LWAkVNjbgAjKCaS CwMAoM9qkWxme2Drmzb1q5o2SEUs8TTP =rPm2 -----END PGP SIGNATURE-----
--- End Message ---
