Your message dated Mon, 06 Oct 2008 04:32:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#489219: fixed in cvsps 2.1-5
has caused the Debian Bug report #489219,
regarding direct cvs mode failure on 64bit arches
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
489219: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=489219
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: cvsps
Version: 2.1-4
Severity: normal
Tags: patch
The direct cvs code incorrectly converts the hostname to an IP address,
by doing a wrong check with the result of the inet_addr call.
The code does (at line 201 in file cbtcommon/tcp_socket.c):
if ( (*dest = inet_addr(addr_str)) != -1)
but here *dest is a long, which is signed and on 64 bit arches has a
different size than the actual return address of inet_addr (in_addr_t)
which is unsigned int. As such, the comparison fails, and the test is
always considered successful, and it will generate the known "Network
unreachable" message when running git-cvsimport. On 32bit arches, due to
the same size, the code will run correctly.
Per
http://www.opengroup.org/onlinepubs/000095399/functions/inet_addr.html,
it is simply enough to test the return value against (in_addr_t)(-1),
which I can confirm works on both 32 and 64 bit. Patch attached.
Side note: the function in cause also has a different codepath for
#ifdef LINUX, but this define is not used anywhere else; the same
problem can be solved (at least on Debian) by modifying in Makefile the
CFLAGS and adding -DLINUX.
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.25.8-teal (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages cvsps depends on:
ii cvs 1:1.12.13-11 Concurrent Versions System
ii libc6 2.7-12 GNU C Library: Shared libraries
ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime
cvsps recommends no packages.
-- no debconf information
#! /bin/sh /usr/share/dpatch/dpatch-run
## 05-inet_addr_fix.dpatch by Iustin Pop <[EMAIL PROTECTED]>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Fix the inet_addr result check with correct type casting
@DPATCH@
diff -urN cvsps-2.1.orig/cbtcommon/tcpsocket.c cvsps-2.1/cbtcommon/tcpsocket.c
--- cvsps-2.1.orig/cbtcommon/tcpsocket.c 2005-05-26 05:39:40.000000000
+0200
+++ cvsps-2.1/cbtcommon/tcpsocket.c 2008-07-04 07:45:08.571962583 +0200
@@ -198,7 +198,7 @@
memcpy(dest, &ip.s_addr, sizeof(ip.s_addr));
}
#else
- if ( (*dest = inet_addr(addr_str)) != -1)
+ if ( (*dest = inet_addr(addr_str)) != (in_addr_t)-1)
{
/* nothing */
}
--- End Message ---
--- Begin Message ---
Source: cvsps
Source-Version: 2.1-5
We believe that the bug you reported is fixed in the latest version of
cvsps, which is due to be installed in the Debian FTP archive:
cvsps_2.1-5.diff.gz
to pool/main/c/cvsps/cvsps_2.1-5.diff.gz
cvsps_2.1-5.dsc
to pool/main/c/cvsps/cvsps_2.1-5.dsc
cvsps_2.1-5_i386.deb
to pool/main/c/cvsps/cvsps_2.1-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Casadevall <[EMAIL PROTECTED]> (supplier of updated cvsps package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 05 Oct 2008 23:10:04 -0400
Source: cvsps
Binary: cvsps
Architecture: source i386
Version: 2.1-5
Distribution: unstable
Urgency: low
Maintainer: [EMAIL PROTECTED]
Changed-By: Michael Casadevall <[EMAIL PROTECTED]>
Description:
cvsps - Tool to generate CVS patch set information
Closes: 489219
Changes:
cvsps (2.1-5) unstable; urgency=low
.
* Sync from Ubuntu to Debian, fixing 64-bit issue in Debian (Closes: #489219)
* Bumped standards version to 3.8.0
Checksums-Sha1:
811c7ea31c44ce1a7c281907ce271233f90a412c 934 cvsps_2.1-5.dsc
c654d63f8cc7cd98b1fb3d33833161aac9157e53 5390 cvsps_2.1-5.diff.gz
7579c729d05b52d3b726e09e2e990334e81f5408 46018 cvsps_2.1-5_i386.deb
Checksums-Sha256:
86fd037037f8c43b54622b1c7ab1c4fc11656e2870922d1a48df7eaacdfd8df7 934
cvsps_2.1-5.dsc
12e1f5f6096abf5d6e4a1fe332e231d6066149639acea4721f038737deb79b13 5390
cvsps_2.1-5.diff.gz
8a81c08bdcb806b1c4ae35911bf1296c29484021918a966337b40f9287f46e5e 46018
cvsps_2.1-5_i386.deb
Files:
23864a3b6af9ddd136b67f630ffb009c 934 devel optional cvsps_2.1-5.dsc
799bc9228ec6757d478e8215a9d88807 5390 devel optional cvsps_2.1-5.diff.gz
163818f021de931f73380a64a5be368e 46018 devel optional cvsps_2.1-5_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFI6ZIPggkdmlkhtdgRAkmaAJ9/FiDA9LZa5VNpErvN/JgMzF5YPwCfa49u
JkOpg93rAkntxHcSfkVPlVE=
=fL4V
-----END PGP SIGNATURE-----
--- End Message ---
