Your message dated Fri, 07 Nov 2008 13:47:22 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#502122: fixed in nfs-utils 1:1.1.4-1 has caused the Debian Bug report #502122, regarding nfs-utils: Patch to make sm-notify faster when there's no-one to notify to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 502122: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502122 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: nfs-utils Version: 1.1.3-1 Severity: normal Tags: patch Hi, I use NFS only rarely on my laptop. During boot, sm-notify takes several seconds to run - whether or not I'm using NFS. On investigation, this is because sm-notify indirectly calls sync(): /* Get and update the NSM state. This will call sync() */ nsm_state = nsm_get_state(opt_update_state); which causes lots of pending writes from the boot process to be written out, and slows other boot processes that are trying to read. It takes 2-3 seconds on my system. And I believe it's unnecessary in the (common for me) case where I didn't use NFS in the last session and sm-notify actually has nothing to do. I propose therefore that sm-notify should first check whether its list of hosts is empty, and terminate immediately in this case. The following simple patch implements that: diff -ur nfs-utils-1.1.3.orig/utils/statd/sm-notify.c nfs-utils-1.1.3/utils/statd/sm-notify.c --- nfs-utils-1.1.3.orig/utils/statd/sm-notify.c 2008-07-27 22:01:45.000000000 +0100 +++ nfs-utils-1.1.3/utils/statd/sm-notify.c 2008-10-13 19:02:54.000000000 +0100 @@ -169,6 +169,10 @@ backup_hosts(_SM_DIR_PATH, _SM_BAK_PATH); get_hosts(_SM_BAK_PATH); + if (!hosts) { + return 0; + } + /* Get and update the NSM state. This will call sync() */ nsm_state = nsm_get_state(opt_update_state); set_kernel_nsm_state(nsm_state); This accelerates boot by the expected couple of seconds on my machine, but I have not tested whether it breaks something when there are hosts to notify. An "expert" should look at this before you consider applying it. (BTW, I had a look at the sourceforge mailing list for NFS-utils and it seems to be 100% spam. Is there a better upstream bug reporting channel?) Regards, Phil. -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.25 Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
--- End Message ---
--- Begin Message ---Source: nfs-utils Source-Version: 1:1.1.4-1 We believe that the bug you reported is fixed in the latest version of nfs-utils, which is due to be installed in the Debian FTP archive: nfs-common_1.1.4-1_i386.deb to pool/main/n/nfs-utils/nfs-common_1.1.4-1_i386.deb nfs-kernel-server_1.1.4-1_i386.deb to pool/main/n/nfs-utils/nfs-kernel-server_1.1.4-1_i386.deb nfs-utils_1.1.4-1.diff.gz to pool/main/n/nfs-utils/nfs-utils_1.1.4-1.diff.gz nfs-utils_1.1.4-1.dsc to pool/main/n/nfs-utils/nfs-utils_1.1.4-1.dsc nfs-utils_1.1.4.orig.tar.gz to pool/main/n/nfs-utils/nfs-utils_1.1.4.orig.tar.gz A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Steinar H. Gunderson <[EMAIL PROTECTED]> (supplier of updated nfs-utils package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Fri, 07 Nov 2008 14:01:19 +0100 Source: nfs-utils Binary: nfs-kernel-server nfs-common Architecture: source i386 Version: 1:1.1.4-1 Distribution: unstable Urgency: low Maintainer: Anibal Monsalve Salazar <[EMAIL PROTECTED]> Changed-By: Steinar H. Gunderson <[EMAIL PROTECTED]> Description: nfs-common - NFS support files common to client and server nfs-kernel-server - support for NFS kernel server Closes: 480909 492970 493059 502122 503643 Changes: nfs-utils (1:1.1.4-1) unstable; urgency=low . * New upstream release. Patch status: * 01-sm-notify-in-sbin.patch: Refreshed. * 03-handle-mtab-symlink.patch: Refreshed. * 05-default-use-old-mount-interface.patch: Removed (see below). * 07-remove-duplicate-exports-paragraphs.patch: No change. * 09-492827-cache.c.patch: Integrated by upstream, removed. * 10-493659-nfs.man.patch: No change. * Do not sync() in sm-notify if there are no hosts to be notified. (Closes: #502122) * Removed 05-default-use-old-mount-interface.patch, ie. revert to the new text-based mount interface, as this package is not intended for lenny. Probably reopens several older bugs, but Closes: #480909, #492970. * Fix abuses of $? in nfs-kernel-server.init (they were already OK in nfs-common.init, for some reason). (Closes: #503643) * In /etc/default/nfs-kernel-server.default, add --manage-gids to the default set of mountd options. (Closes: #493059) Checksums-Sha1: 77487c33a615ea0ab664c066b903a1fea3216925 1300 nfs-utils_1.1.4-1.dsc ddf8e33f3650b2793875b71b570626dde2ee9d1d 807842 nfs-utils_1.1.4.orig.tar.gz f83adba435229a07c32cabb74d2dcae2f42251c6 34562 nfs-utils_1.1.4-1.diff.gz 8a8edda8584a71f1af2bf629b13e0a944dafb1d9 149930 nfs-kernel-server_1.1.4-1_i386.deb 9cd7bbed5b526b09b26b7104b359d5312ed2b79a 195600 nfs-common_1.1.4-1_i386.deb Checksums-Sha256: a2012d1f976ead7b0ad455653e316a9db61fb937a47b55886627f94da2b38146 1300 nfs-utils_1.1.4-1.dsc fe915f59b48771e5c9250cd460b7e108a8fe83adab6190ada6f02cff0a6b0c70 807842 nfs-utils_1.1.4.orig.tar.gz 20c8746f1616e7d064d9ae4ea0f327e161d1a270bca8624e6aec16fc55a72e77 34562 nfs-utils_1.1.4-1.diff.gz 1c8e711825d4c8dd4e92c88bf7c58f0ec9b193a52a97f7ef5c28477e246276f3 149930 nfs-kernel-server_1.1.4-1_i386.deb e09d2923b621a986a54e95d49cb49ae9aad6606e2f4ecc41109c23b006c449d1 195600 nfs-common_1.1.4-1_i386.deb Files: 931d03a68e7e4c741b66345e55623dfe 1300 net standard nfs-utils_1.1.4-1.dsc 51722ec3867eb408fb371e8a0a63c7b6 807842 net standard nfs-utils_1.1.4.orig.tar.gz 485a3a96c01b545776727c7ca2fd46d5 34562 net standard nfs-utils_1.1.4-1.diff.gz abe6a57cad4189371266a5790b16084e 149930 net optional nfs-kernel-server_1.1.4-1_i386.deb 4b5c69907f8067eb918e74889443d602 195600 net standard nfs-common_1.1.4-1_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iD8DBQFJFENHXKRQ3lK3SH4RAtyAAJ9wLjAjFkRWqC1ev+7l6/A18/OdmQCdE3uU eX6yFEKU+ioY4xT7iq+gycI= =OLP2 -----END PGP SIGNATURE-----
--- End Message ---
