Your message dated Sat, 15 Nov 2008 18:17:05 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#256736: fixed in lilo 1:22.8-7
has caused the Debian Bug report #256736,
regarding XSI:isms in various scripts
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
256736: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256736
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: lilo
Version: 22.5.9-3
Severity: minor
Tags: patch
Several scripts in lilo contains use of XSI:isms; `-a' and `-o' in
tests, and pushd and popd. This is technically a policy violation.
The included patch fixes this, and changes egrep to grep -E as per
SUSv3 recommendations, and turns the only remaining bash-script into
a /bin/sh-script, since the required changes were pretty
straight-forward. Finally, it also changes the deprecated use of
chown <user>.<group> into chown <user>:<group>.
Rationale:
policy 10.4
http://www.opengroup.org/onlinepubs/009695399/utilities/test.html
http://www.opengroup.org/onlinepubs/009695399/utilities/chown.html
http://www.opengroup.org/onlinepubs/009695399/utilities/grep.html
Regards: David Weinehall
diff -ur lilo-22.5.9-old/Makefile lilo-22.5.9/Makefile
--- lilo-22.5.9-old/Makefile 2004-04-09 02:36:15.000000000 +0300
+++ lilo-22.5.9/Makefile 2004-06-26 21:56:08.000000000 +0300
@@ -108,7 +108,7 @@
.SUFFIXES: .img .b .com .S .s
all: lilo bootsect.b diag1.img # $(BOOTS) edit dparam.com activate
- if [ -x /usr/bin/bcc -o -x /usr/local/bin/bcc ]; then make diagnostic;
fi
+ if [ -x /usr/bin/bcc ] || [ -x /usr/local/bin/bcc ]; then make
diagnostic; fi
#
# everything above plus the statically linked version
@@ -339,7 +339,7 @@
cp -f diag1.img $$ROOT$(BOOT_DIR); fi
if [ -f diag2.img ]; then \
cp -f diag2.img $$ROOT$(BOOT_DIR); fi
- if [ ! -L $$ROOT$(BOOT_DIR)/boot.b -a -f $$ROOT$(BOOT_DIR)/boot.b ];
then \
+ if [ ! -L $$ROOT$(BOOT_DIR)/boot.b ] && [ -f $$ROOT$(BOOT_DIR)/boot.b
]; then \
mv $$ROOT$(BOOT_DIR)/boot.b $$ROOT$(BOOT_DIR)/boot.old; fi
if [ -f $$ROOT$(BOOT_DIR)/boot-bmp.b ]; then \
mv $$ROOT$(BOOT_DIR)/boot-bmp.b $$ROOT$(BOOT_DIR)/boot-bmp.old; fi
@@ -353,11 +353,11 @@
mv $$ROOT$(BOOT_DIR)/os2_d.b $$ROOT$(BOOT_DIR)/os2_d.old; fi
if [ -f $$ROOT$(BOOT_DIR)/mbr.b ]; then \
mv $$ROOT$(BOOT_DIR)/mbr.b $$ROOT$(BOOT_DIR)/mbr.old; fi
- if [ -f os2_d.b -a $(BUILTIN) = 0 ]; then \
+ if [ -f os2_d.b ] && [ $(BUILTIN) = 0 ]; then \
cp os2_d.b $$ROOT$(BOOT_DIR); fi
if [ $(BUILTIN) = 0 ]; then \
cp boot-text.b boot-menu.b boot-bmp.b chain.b mbr.b
$$ROOT$(BOOT_DIR); fi
- if [ ! -L $$ROOT$(BOOT_DIR)/boot.b -a $(BUILTIN) = 0 ]; then \
+ if [ ! -L $$ROOT$(BOOT_DIR)/boot.b ] && [ $(BUILTIN) = 0 ]; then \
ln -s boot-menu.b $$ROOT$(BOOT_DIR)/boot.b; fi
if [ $(BUILTIN) = 1 ]; then \
rm -f $$ROOT$(BOOT_DIR)/boot.b; fi
diff -ur lilo-22.5.9-old/QuickInst lilo-22.5.9/QuickInst
--- lilo-22.5.9-old/QuickInst 2003-12-15 06:49:37.000000000 +0200
+++ lilo-22.5.9/QuickInst 2004-06-26 22:12:41.000000000 +0300
@@ -122,10 +122,10 @@
{
while true; do
get "$1" line $2
- if echo "$line" | egrep -i '^y(|e(|s))$' >/dev/null; then
+ if echo "$line" | grep -E -i '^y(|e(|s))$' >/dev/null; then
return 0
fi
- if echo "$line" | egrep -i '^no?$' >/dev/null; then
+ if echo "$line" | grep -E -i '^no?$' >/dev/null; then
return 1
fi
echo "YES or NO, please."
@@ -192,8 +192,8 @@
echo "Your grep doesn't behave like grep."
badlib=y
fi
-if [ "`echo 'X(Y)' | egrep '^(X)\(Y\)'`" != "X(Y)" ]; then
- echo "Your egrep doesn't behave like egrep."
+if [ "`echo 'X(Y)' | grep -E '^(X)\(Y\)'`" != "X(Y)" ]; then
+ echo "Your grep -E doesn't behave as expected."
badlib=y
fi
if [ ! -z "$badlib" ]; then
@@ -219,7 +219,7 @@
echo
replace=""
-if [ -d $BOOT_DIR -a \( -f boot.b -o -f first.S \) ]; then
+if [ -d $BOOT_DIR ] && ( [ -f boot.b ] || [ -f first.S ] ); then
cat <<EOF
A directory $BOOT_SUFFIX already exists. If you're installing a new version of
LILO now, QuickInst has to replace the old files with the new ones.
@@ -231,8 +231,8 @@
echo
fi
-if [ -f $ROOT/etc/lilo/install -a ! -L $ROOT/etc/lilo/install -a \
- "$replace" != "y" ]; then
+if [ -f $ROOT/etc/lilo/install ] && [ ! -L $ROOT/etc/lilo/install ] && \
+ [ "$replace" != "y" ]; then
cat <<EOF
/etc/lilo/install is a regular file and not a symbolic link. It should be
a symbolic link to /sbin/lilo (see INCOMPAT for details).
@@ -272,7 +272,7 @@
fi
echo
-if [ ! -f $BOOT_DIR/boot.b -o ! -z "$replace" ]; then
+if [ ! -f $BOOT_DIR/boot.b ] || [ ! -z "$replace" ]; then
if [ ! -f boot.b ]; then
if [ ! -f first.S ]; then
cat <<EOF
@@ -344,7 +344,7 @@
#EOF
#fi
-if [ -d $ROOT/etc/lilo -a ! -x $ROOT/etc/lilo/install ]; then
+if [ -d $ROOT/etc/lilo ] && [ ! -x $ROOT/etc/lilo/install ]; then
ln -s $SBIN_DIR/lilo $ROOT/etc/lilo/install
fi
@@ -453,7 +453,7 @@
if echo "$inp" | grep / >/dev/null; then : ; else
inp="/dev/$inp"
fi
- if echo "$inp" | egrep \
+ if echo "$inp" | grep -E \
"^${first}\$|^${first}[1-4]\$|^${second}\$|^${second}[1-4]\$" \
>/dev/null; then
if true -o probe "$inp"; then
@@ -502,16 +502,16 @@
EOF
while true; do
get "Your choice" line keep
- if echo "$line" | egrep -i '^k(|e(|ep?))$' >/dev/null; then
+ if echo "$line" | grep -E -i '^k(|e(|ep?))$' >/dev/null; then
break
fi
- if echo "$line" | egrep -i '^r(|e(|m(|o(|ve?))))$' >/dev/null; then
+ if echo "$line" | grep -E -i '^r(|e(|m(|o(|ve?))))$' >/dev/null; then
on_second=remove
first=$second
second=
break
fi
- if echo "$line" | egrep -i '^s(|w(|ap?))$' >/dev/null; then
+ if echo "$line" | grep -E -i '^s(|w(|ap?))$' >/dev/null; then
on_second=swap
tmp=$first
first=$second
@@ -547,8 +547,8 @@
if echo "$boot" | grep '^$first[1-4]$' >/dev/null; then
if [ "`dd if=$first bs=1 count=4 skip=2 2>/dev/null | \
- tr -c 'LIO' '?'`" = "LILO" -o \
- "`dd if=$first bs=1 count=4 skip=6 2>/dev/null | \
+ tr -c 'LIO' '?'`" = "LILO" ] || \
+ [ "`dd if=$first bs=1 count=4 skip=6 2>/dev/null | \
tr -c 'LIO' '?'`" = "LILO" ]; then
cat <<EOF
@@ -566,7 +566,7 @@
disk=`echo $boot | sed 's/[1-4]$//'`
oldboot=`$SBIN_DIR/lilo -A $disk 2>/dev/null`
newboot=""
-if [ $boot != "$oldboot" -a ! -z "`echo "$boot" | sed 's|'$dev'/[sh]d.||'`" ];
+if [ $boot != "$oldboot" ] && [ ! -z "`echo "$boot" | sed
's|'$dev'/[sh]d.||'`" ];
then
echo
if [ -z "$oldboot" ]; then
@@ -725,7 +725,7 @@
if probe "$inp"; then
if bootflag $inp; then
loader=""
- if echo "$inp" | egrep "^${second}[1-4]\$" >/dev/null; then
+ if echo "$inp" | grep -E "^${second}[1-4]\$" >/dev/null;
then
echo "It's on your second disk. Is this ..."
if yesno "... OS/2 ?"; then
loader="os2_d.b"
@@ -830,7 +830,7 @@
) | tee $outfile
if [ -f $errflag ]; then
rm $errflag
- if egrep 'geo_query_dev HDIO_|: Got bad geometry' <$outfile >/dev/null
+ if grep -E 'geo_query_dev HDIO_|: Got bad geometry' <$outfile >/dev/null
then
cat <<EOF
diff -ur lilo-22.5.9-old/debian/lilo.postinst lilo-22.5.9/debian/lilo.postinst
--- lilo-22.5.9-old/debian/lilo.postinst 2004-06-22 21:11:49.000000000
+0300
+++ lilo-22.5.9/debian/lilo.postinst 2004-06-26 22:13:28.000000000 +0300
@@ -62,7 +62,7 @@
# Create the missing devices
echo -n "Creating network block devices... "
- pushd /dev > /dev/null
+ (cd /dev
i=0
while [ $i != 128 ]; do
if [ ! -b nbd$i ]; then
@@ -70,7 +70,7 @@
fi
i=$(($i+1))
done
- popd > /dev/null
+ )
echo "done."
fi
fi
diff -ur lilo-22.5.9-old/debian/lilo.sh lilo-22.5.9/debian/lilo.sh
--- lilo-22.5.9-old/debian/lilo.sh 2004-06-22 21:11:49.000000000 +0300
+++ lilo-22.5.9/debian/lilo.sh 2004-06-26 22:12:59.000000000 +0300
@@ -1,8 +1,8 @@
#!/bin/sh -e
# if chroot.
-if [ "$1" = "-r" -a "$2" != "" ]; then
- if [ -c /dev/.devfsd -a ! -c $2/dev/.devfsd ]; then
+if [ "$1" = "-r" ] && [ "$2" != "" ]; then
+ if [ -c /dev/.devfsd ] && [ ! -c $2/dev/.devfsd ]; then
mount none $2/dev -t devfs
fi
diff -ur lilo-22.5.9-old/debian/patches/02_lilo-2.6.dpatch
lilo-22.5.9/debian/patches/02_lilo-2.6.dpatch
--- lilo-22.5.9-old/debian/patches/02_lilo-2.6.dpatch 2004-06-22
21:11:49.000000000 +0300
+++ lilo-22.5.9/debian/patches/02_lilo-2.6.dpatch 2004-06-26
22:13:47.000000000 +0300
@@ -50,7 +50,7 @@
-all: lilo bootsect.b diag1.img # $(BOOTS) edit dparam.com activate
+all: lilo bootsect.b diag1.img $(BOOTS) edit dparam.com activate
- if [ -x /usr/bin/bcc -o -x /usr/local/bin/bcc ]; then make diagnostic;
fi
+ if [ -x /usr/bin/bcc ] || [ -x /usr/local/bin/bcc ]; then make
diagnostic; fi
#
@@ -177,7 +177,7 @@
diff -ur lilo-22.5.9-old/diagnose/Makefile lilo-22.5.9/diagnose/Makefile
--- lilo-22.5.9-old/diagnose/Makefile 2004-03-22 02:32:32.000000000 +0200
+++ lilo-22.5.9/diagnose/Makefile 2004-06-26 21:53:40.000000000 +0300
@@ -45,7 +45,7 @@
# umount $(MFILE) 2>/dev/null
mount -t msdos -o loop=$(LOOP) bootdiagnostic.b $(MFILE)
dd if=floppy.b of=$(LOOP) bs=512
- chown 0.0 *.com *.map
+ chown 0:0 *.com *.map
cp -ufv ../COPYING $(MFILE)
cp -ufv test4.com $(MFILE)/hipboot.sys
cp -ufv test4.com $(MFILE)
diff -ur lilo-22.5.9-old/mkdist lilo-22.5.9/mkdist
--- lilo-22.5.9-old/mkdist 2003-10-10 19:56:44.000000000 +0300
+++ lilo-22.5.9/mkdist 2004-06-26 21:58:30.000000000 +0300
@@ -6,16 +6,14 @@
VERSION=$(echo $MAJOR.$MINOR)
VERSNUM=$(echo $MAJOR.$MINOR$MEDIT)
#DISTDIR=/brun/ftp/pub/linux/lilo
-pushd ..
-DISTDIR=$(pwd)
-popd
+(cd .. ; DISTDIR=$(pwd))
D1=$(pwd)
echo VERSION = $VERSION
echo VERSNUM = $VERSNUM
make spotless
-pushd ..
+(cd ..
D2=$(pwd)
D3=`echo $D1 | sed -e "s~$D2/~~" `
@@ -40,7 +38,7 @@
if [ $D3 != $DIR ]; then mv $DIR $D3; fi
-popd
+)
mv -fv lilo-$VERSNUM.tar.gz $DISTDIR
cp -fdvp lilo.lsm $DISTDIR/lilo-$VERSNUM.lsm
diff -ur lilo-22.5.9-old/mkrescue lilo-22.5.9/mkrescue
--- lilo-22.5.9-old/mkrescue 2003-07-08 03:03:46.000000000 +0300
+++ lilo-22.5.9/mkrescue 2004-06-28 22:50:58.000000000 +0300
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
#
# mkrescue
#
@@ -268,7 +268,7 @@
elif [ $size = 2880 ]; then
sects=36
install=menu
- if [ -f $boot/diag1.img -a -f $boot/diag2.img ]; then
+ if [ -f $boot/diag1.img ] && [ -f $boot/diag2.img ]; then
diag=yes
fi
elif [ $size = 1440 ]; then
@@ -279,7 +279,7 @@
size=1440
fi
-if [ $fs != msdos -a $fs != ext2 -a $fs != minix ]; then
+if [ $fs != msdos ] && [ $fs != ext2 ] && [ $fs != minix ]; then
echo "illegal option: --fs" $fs
echo " must be either msdos or ext2 or minix"
exit 1
@@ -389,10 +389,10 @@
disk=$disk bios=0x00
sectors=$sects heads=2 cylinders=80
EOF
-if [ "$master" != "" -a $isoimage = yes ]; then
+if [ "$master" != "" ] && [ $isoimage = yes ]; then
echo "disk=$master" >>$mountconfig
echo " bios=0x80" >>$mountconfig
-elif [ "$master" != "" -a $debug = true ]; then
+elif [ "$master" != "" ] && [ $debug = true ]; then
echo "disk=$master" >>$mountconfig
echo " bios=0x80 inaccessible" >>$mountconfig
fi
@@ -421,7 +421,7 @@
read-only
EOF
-if [ "$master" != "" -a $size = 2880 ]; then
+if [ "$master" != "" ] && [ $size = 2880 ]; then
cat >> $mountconfig <<EOF
other=$master
unsafe
@@ -482,7 +482,7 @@
log=$(pwd)/mkrescue.log
-pushd $mount >/dev/null 2>/dev/null
+(cd $mount 2> /dev/null
if [ "$fast" = fast ]; then
bootcmd="-b /dev/$loopback"
fi
@@ -494,7 +494,7 @@
else
$lilo -C $mountconfig $compact $bootcmd || fast=error
fi
-popd >/dev/null 2>/dev/null
+)
if [ "$fast" = error ]; then
echo lilo failure.
else
--- End Message ---
--- Begin Message ---
Source: lilo
Source-Version: 1:22.8-7
We believe that the bug you reported is fixed in the latest version of
lilo, which is due to be installed in the Debian FTP archive:
lilo-doc_22.8-7_all.deb
to pool/main/l/lilo/lilo-doc_22.8-7_all.deb
lilo_22.8-7.diff.gz
to pool/main/l/lilo/lilo_22.8-7.diff.gz
lilo_22.8-7.dsc
to pool/main/l/lilo/lilo_22.8-7.dsc
lilo_22.8-7_i386.deb
to pool/main/l/lilo/lilo_22.8-7_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
William Pitcock <[EMAIL PROTECTED]> (supplier of updated lilo package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 15 Nov 2008 11:01:59 -0600
Source: lilo
Binary: lilo lilo-doc
Architecture: source i386 all
Version: 1:22.8-7
Distribution: unstable
Urgency: low
Maintainer: William Pitcock <[EMAIL PROTECTED]>
Changed-By: William Pitcock <[EMAIL PROTECTED]>
Description:
lilo - LInux LOader - The Classic OS loader can load Linux and others
lilo-doc - Documentation for LILO (LInux LOader)
Closes: 256736 504295 504465 504517 504560 504685 504732 505159 505581
Changes:
lilo (1:22.8-7) unstable; urgency=low
.
[ William Pitcock ]
* Acknowledge NMU. (Closes: #504295)
* Fix some remaining XSIisms in scripts. (Closes: #256736)
.
[ Christian Perrier ]
* Translation updates:
- French. (Closes: #504465)
- Swedish. (Closes: #504517)
- Japanese. (Closes: #504560)
- Arabic. (Closes: #504685)
- German. (Closes: #504732)
- Portuguese. (Closes: #505159)
- Russian. (Closes: #505581)
Checksums-Sha1:
a4e4981cb03b6b23ab4c9d47179ba0955e956f30 1235 lilo_22.8-7.dsc
4b845bec83a0c8639983b0a11ad924454d86ac0c 229927 lilo_22.8-7.diff.gz
0dc2980dafe28526513ddd73864faf1fdda0a9bf 381960 lilo_22.8-7_i386.deb
5218c84e820adecf9fa19a6e1340572486e1d62b 346024 lilo-doc_22.8-7_all.deb
Checksums-Sha256:
2937fe65e47dc113bbdfe01c24400f72481d2ebe9160be416a8a43b24042ab36 1235
lilo_22.8-7.dsc
599379860cb8fe032fab4b905afc9b4dfaa92d677b5f4a559fc4ef1571baed93 229927
lilo_22.8-7.diff.gz
f79ff1fa1b65d25d5c82958f120e19bab5defc84662a05e476a627674772e077 381960
lilo_22.8-7_i386.deb
69af9f8c831d94f7c22a228eff65052816b03aa0589c02536ed188f1a502ee71 346024
lilo-doc_22.8-7_all.deb
Files:
de3902fc2c9b63ff7b0bcbf2cef847ad 1235 admin optional lilo_22.8-7.dsc
1fd44dfe9358ff15cb706b355aaef6db 229927 admin optional lilo_22.8-7.diff.gz
467fd66c7dcd39d21257e31faa5a27e3 381960 admin optional lilo_22.8-7_i386.deb
fc2a8a98c73ddfc9f29c9ae984c07bce 346024 doc optional lilo-doc_22.8-7_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkkfDPAACgkQ1OXtrMAUPS3S8gCfbhc7HQOhzQTRptCaWnJShUvo
OOsAoLePYKBciVygjcVR/XVGd5l9v45V
=/2G9
-----END PGP SIGNATURE-----
--- End Message ---
