Your message dated Sun, 03 Jul 2005 14:15:57 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#316302: hugs: Missing Build-Depends and small error in 
debian/rules
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 29 Jun 2005 22:50:33 +0000
>From [EMAIL PROTECTED] Wed Jun 29 15:50:33 2005
Return-path: <[EMAIL PROTECTED]>
Received: from smtpq3.home.nl [213.51.128.198] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DnlO4-00042Z-00; Wed, 29 Jun 2005 15:50:32 -0700
Received: from [213.51.128.133] (port=56890 helo=smtp2.home.nl)
        by smtpq3.home.nl with esmtp (Exim 4.30)
        id 1DnlO3-0004jK-3Q
        for [EMAIL PROTECTED]; Thu, 30 Jun 2005 00:50:31 +0200
Received: from cc203504-a.zwoll1.ov.home.nl ([82.74.134.22]:60413 
helo=moonshine.dnsalias.org)
        by smtp2.home.nl with esmtp (Exim 4.30)
        id 1DnlO1-00067j-JJ; Thu, 30 Jun 2005 00:50:29 +0200
Received: from localhost ([127.0.0.1])
        by moonshine.dnsalias.org with esmtp (Exim 4.50)
        id 1DnlO1-00079y-7O; Thu, 30 Jun 2005 00:50:29 +0200
Received: from moonshine.dnsalias.org ([127.0.0.1])
        by localhost (moonshine.dnsalias.org [127.0.0.1]) (amavisd-new, port 
10024)
        with ESMTP id 26492-06; Thu, 30 Jun 2005 00:50:20 +0200 (CEST)
Received: from stardust.arriesoft.nl ([192.168.1.2])
        by moonshine.dnsalias.org with esmtp (Exim 4.50)
        id 1DnlNs-00079H-I0; Thu, 30 Jun 2005 00:50:20 +0200
Received: from arjan by stardust.arriesoft.nl with local (Exim 4.51)
        id 1DnlNN-0006Tc-Vd; Thu, 30 Jun 2005 00:49:50 +0200
Content-Type: multipart/mixed; boundary="===============0044830448=="
MIME-Version: 1.0
From: Arjan Oosting <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: hugs: Missing Build-Depends and small error in debian/rules
X-Mailer: reportbug 3.15
Date: Thu, 30 Jun 2005 00:49:49 +0200
Message-Id: <[EMAIL PROTECTED]>
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at moonshine.dnsalias.org
X-AtHome-MailScanner-Information: Neem contact op met [EMAIL PROTECTED] voor 
meer informatie
X-AtHome-MailScanner: Found to be clean
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

This is a multi-part MIME message sent by reportbug.

--===============0044830448==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: hugs
Version: 98.200503.08-1
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I was looking at the packaging of Hugs and noticed a couple of things.
First of all the package is missing build depenencies on xlibmesa-gl-dev 
freeglut3-dev and libxt-dev.

Secondly I found a small mistake in the handling of DEB_BUILD_OPTIONS.
If the DEB_BUILD_OPTIONS environment variable DOES NOT CONTAIN noopt hugs is 
build WITHOUT optimization and if it DOES CONTAIN noopt it is build WITH
optimization. 

Lastly I saw that install_exec variable containing the install command for 
installing executables always strips (-s) the binary it installs, regardless 
whether DEB_BUILD_OPTIONS contains nostrip or not. Note that this isn't a 
big problem because install_exec isn't used anywhere, but I fixed it anyway :)

I have attached a patch which fixes all these problems.

Greetings,

        Arjan Oosting   


- -- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-proposed-updates'), (500, 
'unstable'), (102, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-2-stardust
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8)

Versions of packages hugs depends on:
ii  libc6                       2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libncurses5                 5.4-8        Shared libraries for terminal hand
ii  libreadline4                4.3-15       GNU readline and history libraries

hugs recommends no packages.

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCwyWNUALvsZYuOJARAn+/AJ48koHmzlZUYVYjB5r3c0nAtCu0SgCeLr08
IefodOmUFV76XYGuobiYA8g=
=TdEo
-----END PGP SIGNATURE-----

--===============0044830448==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="missing-build-depends.patch"

diff -Naur orig/hugs98-98.200503.08/debian/changelog 
hugs98-98.200503.08/debian/changelog
--- orig/hugs98-98.200503.08/debian/changelog   2005-06-30 00:34:10.000000000 
+0200
+++ hugs98-98.200503.08/debian/changelog        2005-06-30 00:11:40.000000000 
+0200
@@ -1,3 +1,15 @@
+hugs98 (98.200503.08-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix debian/rules to use --enable-debug when DEB_BUILD_OPTIONS
+    contains noopt not the other way around.
+  * Fix debian/rules to stop stripping binaries when DEB_BUILD_OPTIONS
+    contains nostrip.
+  * Added missing build dependencies on xlibmesa-gl-dev and freeglut3-
+    dev and libxt-dev.
+
+ -- Arjan Oosting <[EMAIL PROTECTED]>  Wed, 29 Jun 2005 23:27:54 +0200
+
 hugs98 (98.200503.08-1) unstable; urgency=low
 
   * New upstream release
diff -Naur orig/hugs98-98.200503.08/debian/control 
hugs98-98.200503.08/debian/control
--- orig/hugs98-98.200503.08/debian/control     2005-06-30 00:34:10.000000000 
+0200
+++ hugs98-98.200503.08/debian/control  2005-06-30 00:11:21.000000000 +0200
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Isaac Jones <[EMAIL PROTECTED]>
 Standards-Version: 3.6.1
-Build-Depends: libncurses5-dev, libreadline4-dev (>= 4.1), autotools-dev
+Build-Depends: libncurses5-dev, libreadline4-dev (>= 4.1), autotools-dev, 
xlibmesa-gl-dev, freeglut3-dev, libxt-dev
 Build-Conflicts: byacc
 
 Package: hugs
diff -Naur orig/hugs98-98.200503.08/debian/rules 
hugs98-98.200503.08/debian/rules
--- orig/hugs98-98.200503.08/debian/rules       2005-06-30 00:34:10.000000000 
+0200
+++ hugs98-98.200503.08/debian/rules    2005-06-29 23:54:54.000000000 +0200
@@ -8,7 +8,7 @@
 # Modified for Hugs-Nov2002-Nov2003 by Isaac Jones <[EMAIL PROTECTED]>
 
 install := install -o root -g root
-install_exec := $(install) -m 755 -s
+install_exec := $(install) -m 755
 install_dir := $(install) -m 755 -d
 install_nonex = $(install) -m 644
 install_script := $(install) -m 755
@@ -17,9 +17,13 @@
 GZIP := gzip -9v
 DEBUG_OPT=
 
-ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
+ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
        DEBUG_OPT = --enable-debug
 endif
+ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
+       install_exec += -s
+endif
+
 
 package = hugs
 tmpdir    := $(shell pwd)/debian/tmp

--===============0044830448==--

---------------------------------------
Received: (at 316302-done) by bugs.debian.org; 3 Jul 2005 21:15:56 +0000
>From [EMAIL PROTECTED] Sun Jul 03 14:15:56 2005
Return-path: <[EMAIL PROTECTED]>
Received: from monk.area614.net [64.46.156.22] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DpBoi-0004xv-00; Sun, 03 Jul 2005 14:15:56 -0700
Received: from monk.area614.net (localhost.localdomain [127.0.0.1])
        by monk.area614.net (Postfix) with ESMTP
        id E65D4410811; Sun,  3 Jul 2005 17:15:39 -0400 (EDT)
Received: by monk.area614.net (Postfix, from userid 1000)
        id 7B3EB350C8E; Sun,  3 Jul 2005 14:15:57 -0700 (PDT)
To: Arjan Oosting <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Subject: Re: Bug#316302: hugs: Missing Build-Depends and small error in
 debian/rules
References: <[EMAIL PROTECTED]>
From: Isaac Jones <[EMAIL PROTECTED]>
Date: Sun, 03 Jul 2005 14:15:57 -0700
In-Reply-To: <[EMAIL PROTECTED]> (Arjan Oosting's
 message of "Thu, 30 Jun 2005 00:49:49 +0200")
Message-ID: <[EMAIL PROTECTED]>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Arjan.  Thanks for the bug report and patch!  I uploaded your patch.
Your changelog didn't include a close: line (bit of a bootstrapping
problem there ;) and I neglected to add one, but since this bug is
fixed by the patch, I'll mark it as done.  Reopen if there are any
problems.

peace,

  isaac


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to