Your message dated Sun, 14 Dec 2008 01:47:04 +0000
with message-id <[email protected]>
and subject line Bug#504704: fixed in teeworlds 0.4.3-2
has caused the Debian Bug report #504704,
regarding Crashes on big endian architectures due to incorrect data size used 
for byte swapping
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
504704: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504704
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: teeworlds
Version: 0.4.3-1
Severity: important
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Two swap_endian() calls in e_datafile.c pass the size in bytes instead of in
number of units to be swapped, resulting in memory corruption and consequent
crashes.

The attached patch fixes this and allows teeworlds to work on my PowerBook.


- -- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (102, 'experimental')
Architecture: powerpc (ppc)

Kernel: Linux 2.6.27.2
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages teeworlds depends on:
ii  libc6                  2.7-15            GNU C Library: Shared libraries
ii  libgcc1                1:4.3.2-1         GCC support library
ii  libgl1-mesa-glx [libgl 7.0.3-6           A free implementation of the OpenG
ii  libglu1-mesa [libglu1] 7.0.3-6           The OpenGL utility library (GLU)
ii  libportaudio2          19+svn20071022-3  Portable audio I/O - shared librar
ii  libstdc++6             4.3.2-1           The GNU Standard C++ Library v3
ii  libwavpack1            4.50.1-1          an audio codec (lossy and lossless
ii  libx11-6               2:1.1.5-2         X11 client-side library
ii  libxrandr2             2:1.2.3-1         X11 RandR extension library
ii  teeworlds-data         0.4.3-1           Data for Teeworlds; an online mult
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

teeworlds recommends no packages.

Versions of packages teeworlds suggests:
ii  teeworlds-server              0.4.3-1    Server for Teeworlds; an online mu

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJEtovWoGvjmrbsgARAgdFAJ9IYHfVaphwjHwb6UT9qX4897YDVQCeM/WW
bT7btidgNQ8LD9TXGz5uU1o=
=qErH
-----END PGP SIGNATURE-----
diff -up -ru teeworlds-0.4.3.orig/src/engine/e_datafile.c teeworlds-0.4.3/src/engine/e_datafile.c
--- teeworlds-0.4.3.orig/src/engine/e_datafile.c	2008-11-06 12:19:08.000000000 +0100
+++ teeworlds-0.4.3/src/engine/e_datafile.c	2008-11-06 12:07:02.000000000 +0100
@@ -137,7 +137,7 @@ DATAFILE *datafile_load(const char *file
 	}
 
 #if defined(CONF_ARCH_ENDIAN_BIG)
-	swap_endian(df->data, sizeof(int), header.swaplen);
+	swap_endian(df->data, sizeof(int), header.swaplen/sizeof(int));
 #endif
 	
 	if(DEBUG)
@@ -261,7 +261,7 @@ void *datafile_get_data_swapped(DATAFILE
 		return ptr;
 
 #if defined(CONF_ARCH_ENDIAN_BIG)
-	swap_endian(ptr, sizeof(int), size);
+	swap_endian(ptr, sizeof(int), size/sizeof(int));
 #endif
 
 	return ptr;

--- End Message ---
--- Begin Message ---
Source: teeworlds
Source-Version: 0.4.3-2

We believe that the bug you reported is fixed in the latest version of
teeworlds, which is due to be installed in the Debian FTP archive:

teeworlds-data_0.4.3-2_all.deb
  to pool/main/t/teeworlds/teeworlds-data_0.4.3-2_all.deb
teeworlds-server_0.4.3-2_i386.deb
  to pool/main/t/teeworlds/teeworlds-server_0.4.3-2_i386.deb
teeworlds_0.4.3-2.diff.gz
  to pool/main/t/teeworlds/teeworlds_0.4.3-2.diff.gz
teeworlds_0.4.3-2.dsc
  to pool/main/t/teeworlds/teeworlds_0.4.3-2.dsc
teeworlds_0.4.3-2_i386.deb
  to pool/main/t/teeworlds/teeworlds_0.4.3-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gonéri Le Bouder <[email protected]> (supplier of updated teeworlds package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 14 Dec 2008 01:55:34 +0100
Source: teeworlds
Binary: teeworlds teeworlds-server teeworlds-data
Architecture: source i386 all
Version: 0.4.3-2
Distribution: experimental
Urgency: low
Maintainer: Debian Games Team <[email protected]>
Changed-By: Gonéri Le Bouder <[email protected]>
Description: 
 teeworlds  - An online multi-player platform 2D shooter
 teeworlds-data - Data for Teeworlds; an online multi-player platform 2D shooter
 teeworlds-server - Server for Teeworlds; an online multi-player platform 2D 
shooter
Closes: 504704
Changes: 
 teeworlds (0.4.3-2) experimental; urgency=low
 .
   [ Gonéri Le Bouder ]
   * Apply Michel Dänzer patch to avoid crash on big endian arch
     (Closes: #504704)
Checksums-Sha1: 
 85ec79dda6cf1b4e0e0ad92d258de81f7b49e68f 1434 teeworlds_0.4.3-2.dsc
 119c654aea5b711ea284b30f03ba05344504f9ad 15270 teeworlds_0.4.3-2.diff.gz
 f5c21182a78c7c4c2ee698afbf7d4b8cef73dd89 169366 teeworlds_0.4.3-2_i386.deb
 88e49d4250839a392dbacb4d4d84da1aa54eee24 65642 
teeworlds-server_0.4.3-2_i386.deb
 8576b895753dfb510c515926130b6ed7b3b74ef5 4192968 teeworlds-data_0.4.3-2_all.deb
Checksums-Sha256: 
 9ab9eac05fa451bcba95b39f698e27acbba71ffb04831c2e5044c84d6cb6124b 1434 
teeworlds_0.4.3-2.dsc
 90abc9f600e80165915d6524a65beeaee8298b2230aaeb6c6526167c9d93824c 15270 
teeworlds_0.4.3-2.diff.gz
 556c65412e9d37db8aa2c3becf39993ec8b005e76a1f6f9633f4fa079a92acde 169366 
teeworlds_0.4.3-2_i386.deb
 1df8acffec8fda662778732a55e29cb16592f503472f4279ab8523a2d9050178 65642 
teeworlds-server_0.4.3-2_i386.deb
 8a29d408231dba5d1152529c1a7f08e86b8217903af059be6696b4a35ad960c6 4192968 
teeworlds-data_0.4.3-2_all.deb
Files: 
 31ea4296f8ae2dd724194f2007580d4a 1434 games optional teeworlds_0.4.3-2.dsc
 e5881ab123c7565855935dbf694e4b04 15270 games optional teeworlds_0.4.3-2.diff.gz
 d4e7be0888d23d87c1db29e7444d7095 169366 games optional 
teeworlds_0.4.3-2_i386.deb
 a80024f6a9a02248f6eb9bd69775e3e7 65642 games optional 
teeworlds-server_0.4.3-2_i386.deb
 38c4e2e77a873bdc471be524fdeac828 4192968 games optional 
teeworlds-data_0.4.3-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklEYmIACgkQsKTFpDfZQSxzQgCfYF77qGyB9qTsxuu9UN752b3o
J7QAoJhTCwCetwa36mp+1C9NnjerSYyX
=NADu
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to