Your message dated Tue, 23 Dec 2008 10:47:03 +0000
with message-id <[email protected]>
and subject line Bug#509533: fixed in speech-dispatcher 0.6.7-3
has caused the Debian Bug report #509533,
regarding speech-dispatcher: spd_open() leaks a socket on error path
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
509533: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=509533
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: speech-dispatcher
Version: 0.6.7~rc1-1
Severity: important
Tag: patch
In src/c/api/libspeechd.c:spd_open() you have
---<snip>---
connection = xmalloc(sizeof(SPDConnection));
/* Prepare a new socket */
address.sin_addr.s_addr = inet_addr("127.0.0.1");
address.sin_port = htons(port);
address.sin_family = AF_INET;
connection->socket = socket(AF_INET, SOCK_STREAM, 0);
#ifdef LIBSPEECHD_DEBUG
[...]
#endif /* LIBSPEECHD_DEBUG */
/* Connect to server */
ret = connect(connection->socket, (struct sockaddr *)&address,
sizeof(address));
if (ret == -1){
SPD_DBG("Error: Can't connect to server: %s", strerror(errno));
return NULL;
}
---<snip>---
Which leads to a leaked socket (and memory?) whenever the speech-dispatcher
daemon is not currently running. With a fast retry interval, this can easily
lead to a client app running out of file descriptors (observed with BRLTTY and
the SD driver).
--- speech-dispatcher-0.6.7~rc1/src/c/api/libspeechd.c.orig 2008-04-09
13:39:06.000000000 +0200
+++ speech-dispatcher-0.6.7~rc1/src/c/api/libspeechd.c 2008-12-23
01:49:27.000000000 +0100
@@ -136,6 +136,7 @@
ret = connect(connection->socket, (struct sockaddr *)&address,
sizeof(address));
if (ret == -1){
SPD_DBG("Error: Can't connect to server: %s", strerror(errno));
+ close(connection->socket);
return NULL;
}
-- System Information:
Debian Release: 5.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages speech-dispatcher depends on:
ii adduser 3.110 add and remove users and groups
ii libasound2 1.0.16-2 ALSA library
ii libaudio2 1.9.1-5 Network Audio System - shared libr
ii libc6 2.7-16 GNU C Library: Shared libraries
ii libdotconf1.0 1.0.13-2 Configuration file parser library
ii libespeak1 1.37-1 A multi-lingual software speech sy
ii libflite1 1.2-release-2.4 a small run-time speech synthesis
ii libglib2.0-0 2.16.6-1 The GLib library of C routines
ii libpulse0 0.9.10-3 PulseAudio client libraries
ii libspeechd2 0.6.7~rc1-1 Speech Dispatcher: Shared librarie
ii lsb-base 3.2-20 Linux Standard Base 3.2 init scrip
speech-dispatcher recommends no packages.
Versions of packages speech-dispatcher suggests:
pn speech-dispatcher-doc-cs <none> (no description available)
pn speech-dispatcher-festival <none> (no description available)
-- no debconf information
--
CYa,
⡍⠁⠗⠊⠕ | Debian Developer <URL:http://debian.org/>
.''`. | Get my public key via finger mlang/[email protected]
: :' : | 1024D/7FC1A0854909BCCDBE6C102DDFFC022A6B113E44
`. `'
`- <URL:http://delysid.org/> <URL:http://www.staff.tugraz.at/mlang/>
--- End Message ---
--- Begin Message ---
Source: speech-dispatcher
Source-Version: 0.6.7-3
We believe that the bug you reported is fixed in the latest version of
speech-dispatcher, which is due to be installed in the Debian FTP archive:
cl-speech-dispatcher_0.6.7-3_all.deb
to pool/main/s/speech-dispatcher/cl-speech-dispatcher_0.6.7-3_all.deb
libspeechd-dev_0.6.7-3_amd64.deb
to pool/main/s/speech-dispatcher/libspeechd-dev_0.6.7-3_amd64.deb
libspeechd2_0.6.7-3_amd64.deb
to pool/main/s/speech-dispatcher/libspeechd2_0.6.7-3_amd64.deb
python-speechd_0.6.7-3_all.deb
to pool/main/s/speech-dispatcher/python-speechd_0.6.7-3_all.deb
speech-dispatcher-doc-cs_0.6.7-3_all.deb
to pool/main/s/speech-dispatcher/speech-dispatcher-doc-cs_0.6.7-3_all.deb
speech-dispatcher-festival_0.6.7-3_all.deb
to pool/main/s/speech-dispatcher/speech-dispatcher-festival_0.6.7-3_all.deb
speech-dispatcher_0.6.7-3.diff.gz
to pool/main/s/speech-dispatcher/speech-dispatcher_0.6.7-3.diff.gz
speech-dispatcher_0.6.7-3.dsc
to pool/main/s/speech-dispatcher/speech-dispatcher_0.6.7-3.dsc
speech-dispatcher_0.6.7-3_amd64.deb
to pool/main/s/speech-dispatcher/speech-dispatcher_0.6.7-3_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Milan Zamazal <[email protected]> (supplier of updated speech-dispatcher package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 23 Dec 2008 10:21:16 +0100
Source: speech-dispatcher
Binary: speech-dispatcher libspeechd2 libspeechd-dev cl-speech-dispatcher
python-speechd speech-dispatcher-festival speech-dispatcher-doc-cs
Architecture: source all amd64
Version: 0.6.7-3
Distribution: experimental
Urgency: low
Maintainer: Milan Zamazal <[email protected]>
Changed-By: Milan Zamazal <[email protected]>
Description:
cl-speech-dispatcher - Common Lisp interface to Speech Dispatcher
libspeechd-dev - Speech Dispatcher: Development libraries and header files
libspeechd2 - Speech Dispatcher: Shared libraries
python-speechd - Python interface to Speech Dispatcher
speech-dispatcher - Common interface to speech synthesizers
speech-dispatcher-doc-cs - Speech Dispatcher documentation in Czech
speech-dispatcher-festival - Festival support for Speech Dispatcher
Closes: 509533
Changes:
speech-dispatcher (0.6.7-3) experimental; urgency=low
.
* Fix memory leak on connection error in libspeechd. Thanks to Mario
Lang <[email protected]>. Closes: #509533.
Checksums-Sha1:
47fff1a66529a46d214445faf8904cac9b677eba 1575 speech-dispatcher_0.6.7-3.dsc
f7f0e856a81893b8f3c017d064ec3d5f8cbbb746 10370
speech-dispatcher_0.6.7-3.diff.gz
618c1804c8a7621bfc7fb66514e01dc52c531a7a 13434
cl-speech-dispatcher_0.6.7-3_all.deb
692dfc21b8f856b0d3cd9dad12e272fdcb0b7483 42224 python-speechd_0.6.7-3_all.deb
3ae5b0a85565472075ccf7fa699f6e47e689217f 5476
speech-dispatcher-festival_0.6.7-3_all.deb
3b6f3f520eeb2d6d48f0569f9d9ce82380bbfd0d 31388
speech-dispatcher-doc-cs_0.6.7-3_all.deb
e0a745f99dc86c58ad829708f2d09c76d3f05d89 567380
speech-dispatcher_0.6.7-3_amd64.deb
a918cc35547d8a331f30a4389252fc1d594d0cc5 60164 libspeechd2_0.6.7-3_amd64.deb
633d434575272959f8a03e4fa8c0a63905682f8c 61112 libspeechd-dev_0.6.7-3_amd64.deb
Checksums-Sha256:
ae513ef3a3bbdf3630faddad99bd1fd7f8e9576cac083c2222cfd732428cebd1 1575
speech-dispatcher_0.6.7-3.dsc
885db4c10c9f6cfa1501dc226feddc82bbf695ac917d211eef6194f437cddc97 10370
speech-dispatcher_0.6.7-3.diff.gz
e2fd8de350dd532a573975f48882cfd2fbce49a3a8b2027356e53d147a597df6 13434
cl-speech-dispatcher_0.6.7-3_all.deb
3af415c3798872d6dff2f5eacc9ea45e09a83cc98535a49f5452c6a661d50299 42224
python-speechd_0.6.7-3_all.deb
616a6f2f8fb4fa195c82430c0ff6522762172df62feb5c1291b74be02e889b6c 5476
speech-dispatcher-festival_0.6.7-3_all.deb
6dc359b7a07853f9e0a21f8de293af9b66949c8183ebc6edb3359f38c87f5704 31388
speech-dispatcher-doc-cs_0.6.7-3_all.deb
00ca13d5a58447926ad804b54915338090f66e73f702de3065284e3fc0d19b45 567380
speech-dispatcher_0.6.7-3_amd64.deb
0cf35eb333ed05862212067abcf1a6412b3fb33b62f7aaa28de0ed910d2a5363 60164
libspeechd2_0.6.7-3_amd64.deb
c47c2ee5b1703469ad37f3fc8d1d073c59bf6839856fd8a8db18a795ae8e767d 61112
libspeechd-dev_0.6.7-3_amd64.deb
Files:
9c145cf6a761054334f38b845a0017e5 1575 sound extra speech-dispatcher_0.6.7-3.dsc
a67e3cc1dc5226028d3fe209343dad90 10370 sound extra
speech-dispatcher_0.6.7-3.diff.gz
fdf624c4ecf2d683127905d3419cfe98 13434 devel extra
cl-speech-dispatcher_0.6.7-3_all.deb
6368bcb5f96ef9d342b3cb11790c925d 42224 python extra
python-speechd_0.6.7-3_all.deb
8a83e9ff9a6f29b09a8ca657958084b3 5476 sound extra
speech-dispatcher-festival_0.6.7-3_all.deb
675e897dbc47e41440c2674bb1f835b5 31388 doc extra
speech-dispatcher-doc-cs_0.6.7-3_all.deb
a1b1690cb5221899326611bf1a29c912 567380 sound extra
speech-dispatcher_0.6.7-3_amd64.deb
61e0db1980d72b047a179d036ed9acd3 60164 libs extra libspeechd2_0.6.7-3_amd64.deb
23cf445a4f1bf12290d7c124133534f8 61112 libdevel extra
libspeechd-dev_0.6.7-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAklQvmYACgkQkSkk/j3Cm0GalwCgidEZs6CalyaoHx6Ed12jurLB
bfUAn3h2lz5fzb8pTGHEdPZTYbjPtKoH
=kAK1
-----END PGP SIGNATURE-----
--- End Message ---
