Your message dated Sat, 3 Jan 2009 19:44:00 +0100
with message-id <[email protected]>
and subject line Bug still here in 3.2.* but fixed in 3.3.* (samba bug #4665)
has caused the Debian Bug report #408001,
regarding umount.cifs: mtab locking needs improvement
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
408001: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=408001
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: smbfs
Version: 3.0.23d-4
Severity: important

The mtab locking code gives up too easily. If it can't obtain the lock
it just bails out without retrying, sometimes resulting in a dirty mtab
with the mount entry still there.

This causes autofs to think that the mount is still active and it
doesn't try to mount the autofs entry again when accessed.

I looked in the source code for umount (package: mount) and umount.cifs
(package: smbfs) for how each does the mtab locking. umount tries to get
the lock for a few seconds before giving up. umount.cifs just gives up.
So, if there are two umount processes running and one of them is
umount.cifs, and they both need to update mtab, umount.cifs will leave
its mtab entry there because it wasn't patient enough when trying to get
the lock.

I don't have a patch right now, but if nobody takes action by the end of
the week I may do one. It's probably just copy/pasting from umount into
umount.cifs with a few changes.

The relevant functions in umount.cifs source code:
File: source/client/umount.cifs.c
Functions: lock_mtab, unlock_mtab

The relevant functions in umount source code:
File: mount/fstab.c
Functions: lock_mtab, unlock_mtab

The other functions seem to do their jobs right so far.

-- System Information:
Debian Release: 4.0
 APT prefers testing
 APT policy: (990, 'testing'), (50, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-k7
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ANSI_X3.4-1968)

Versions of packages smbfs depends on:
ii  libc6    2.3.6.ds1-8                     GNU C Library: Shared libraries
ii libcomer 1.39+1.40-WIP-2006.11.14+dfsg-1 common error description library
ii  libkrb53 1.4.4-6                         MIT Kerberos runtime libraries
ii  libldap2 2.1.30-13.2                     OpenLDAP libraries
ii  netbase  4.28                            Basic TCP/IP networking system
ii samba-co 3.0.23d-4 Samba common files used by both th

smbfs recommends no packages.

-- no debconf information



--- End Message ---
--- Begin Message ---
Version: 2:3.3.0~pre2-1

Steve (French), this is samba bug #4665 (umount.cifs: gives up too quickly when 
mtab is locked by another process)

Just a small mail to confirm that this bug is still here in 3.2.5 and
subsequent releases, but is fixed in 3.3.0 pre-releases where the
locking code has been apparently entirely rewritten.

There are probably several other bugs (reported in Debian and
forwarded to Samba's Bugzilla) related to mtab that are fixed in 3.3.*
as well.

-- 




Attachment: signature.asc
Description: Digital signature


--- End Message ---

Reply via email to