Your message dated Sun, 04 Jan 2009 21:32:07 +0000
with message-id <[email protected]>
and subject line Bug#468320: fixed in ddclient 3.7.3-5
has caused the Debian Bug report #468320,
regarding ddclient has inconsistent logic for default refresh intervals
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
468320: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468320
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ddclient
Version: 3.7.3-4
Severity: normal
Tags: patch-available

I think there is a logic bug in ddclient's sanity checking of
max-interval and min-interval. At the moment both checks use the max of
the default value and the configured value, which doesn't limit the
possible range. My assumption is that what the author intended was to
use the max of the configured and default values for min-interval, and
the min of the configured and default values for max-interval, thereby
limiting the range effectively. A patch to this effect is attached. 

Whatever the desired intention, this limiting needs to be mentioned in
the help somewhere. At the moment most of the help is via the -help
switch of ddclient, rather than the man page.  

This bug was discovered because DynDNS is writing to tell me that my
account is due to expire after 30 days of inactivity, yet my
/etc/ddclient.conf has max-interval=15d, which should force an update of
my IP every 15 days. 

CC

> -----Original Message-----
> From: Chris Carr [mailto:[email protected]] 
> Sent: 28 February 2008 07:55
> To: Peter Denison; Carr, Chris
> Subject: ddclient 
> 
> Noz says:
> Think I may have found the problem - it's a logic problem.
> Noz says:
>      $opt{'max-interval'}       = max(interval(opt('max-interval')), 
> interval(default('max-interval')));
>      $opt{'min-interval'}       = max(interval(opt('min-interval')), 
> interval(default('min-interval')));
>      $opt{'min-error-interval'} =
> max(interval(opt('min-error-interval')),
> interval(default('min-error-interval')));
> 
> Noz says:
> Surely you want to take the *minimum* of any maxima 
> specified, and the maximum of any minima specified ?? Don't you?
> Noz says:
> Line 1003 in /usr/sbin/ddclient on baba
> --------
> Well, what this logic says is that you can set the 
> max-interval higher than the default but not lower, and you 
> can similarly set the min-interval higher than the default 
> but not lower. That could be what they want - but they need 
> to explain it somewhere. It's not mentioned on the ddclient 
> man page or in the copious output of ddclient -help.
> 
> Will submit a bug report when I get to work.
> 
> CC
 

Attachment: ddclient.patch
Description: ddclient.patch


--- End Message ---
--- Begin Message ---
Source: ddclient
Source-Version: 3.7.3-5

We believe that the bug you reported is fixed in the latest version of
ddclient, which is due to be installed in the Debian FTP archive:

ddclient_3.7.3-5.diff.gz
  to pool/main/d/ddclient/ddclient_3.7.3-5.diff.gz
ddclient_3.7.3-5.dsc
  to pool/main/d/ddclient/ddclient_3.7.3-5.dsc
ddclient_3.7.3-5_all.deb
  to pool/main/d/ddclient/ddclient_3.7.3-5_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Torsten Landschoff <[email protected]> (supplier of updated ddclient package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 04 Jan 2009 22:11:08 +0100
Source: ddclient
Binary: ddclient
Architecture: source all
Version: 3.7.3-5
Distribution: unstable
Urgency: low
Maintainer: Torsten Landschoff <[email protected]>
Changed-By: Torsten Landschoff <[email protected]>
Description: 
 ddclient   - Update IP addresses at dynamic DNS services
Closes: 206272 230768 468320
Changes: 
 ddclient (3.7.3-5) unstable; urgency=low
 .
   * Acknowledge uploads by the l10n team. Thanks, guys!
   * Adjust wording for ddclient/interface option (closes: #230768).
   * debian/patches/daemon_doc.diff: Document that the daemon option
     takes any interval (closes: #206272). Taken from upstream SVN,
     revision 90.
   * Patch bug468320_minmax_logic.diff: Include the patch provided
     by Chris Carr to fix the sanity check on max-interval
     (closes: #468320).
Checksums-Sha1: 
 6663f4c170b9ce4e1812cfe844d9ee7dde4c906c 1051 ddclient_3.7.3-5.dsc
 73998696783847dad6d0880e9b12ee5de0608b96 35629 ddclient_3.7.3-5.diff.gz
 c19f10ce4f989e032cbfa8fc26ad865e737d6679 59514 ddclient_3.7.3-5_all.deb
Checksums-Sha256: 
 f344e350e9bdc8d617ac2bc7fa941c7a43cf9cf0e646487b63f34704607358fc 1051 
ddclient_3.7.3-5.dsc
 687ef867b219f9bc453c2bed02f90b6e7e7f7b3a667f309dadd00dce15aadee0 35629 
ddclient_3.7.3-5.diff.gz
 291c1ed5cfffd4716dc36661ade10c89175213f8a04a1d0d0003dea29be5d189 59514 
ddclient_3.7.3-5_all.deb
Files: 
 4a5d27321588d1261e0370253b8e584e 1051 net extra ddclient_3.7.3-5.dsc
 58c0444ae558ef83649a1543dd94336b 35629 net extra ddclient_3.7.3-5.diff.gz
 a67028dd403f1adf440a06a85e0df784 59514 net extra ddclient_3.7.3-5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJYSYOdQgHtVUb5EcRAmKLAJ0d2Y+3Ic65LAP+1krqwAoR9WvH9ACfaBm1
XGjSTHCAM81OC7/NuGnBF0Y=
=lwrA
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to