Your message dated Thu, 29 Jan 2009 22:02:11 +0000
with message-id <[email protected]>
and subject line Bug#511389: fixed in playmp3list 0.95-5
has caused the Debian Bug report #511389,
regarding playmp3list: crashes on playlist with empty line
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
511389: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=511389
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: playmp3list
Version: 0.95-4.1+b1
Severity: normal
Tags: patch
When a playlist which has a blank line is opened, playmp3list segfaults.
The attached patch fixes this.
Steps to reproduce:
$ echo -e "a.mp3\n\nb.mp3" > test.m3u
$ playmp3list -d test.m3u
Reading rc file: /etc/playmp3listrc...
Loading theme: 'Ocean'
Attempting to compile playlist test.m3u...Caught signal SIGSEGV
(Segmentaion fault)
Please re-create this error, with debug logging enabled - i.e. run with
command-line option -d, then e-mail ~/playmp3list.debug together with a
description of what happened to the author, [email protected]
$ cat ~/playmp3list.debug
Loading playlist 'test.m3u'...
Caught signal: 11
-- System Information:
Debian Release: 5.0
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.28
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages playmp3list depends on:
ii libc6 2.7-18 GNU C Library: Shared libraries
ii libgcc1 1:4.3.2-1.1 GCC support library
ii libncurses5 5.7+20081220-1 shared libraries for terminal hand
ii libstdc++6 4.3.2-1.1 The GNU Standard C++ Library v3
ii mpg321 [mpg123] 0.2.10.6 mpg123 clone that doesn't use floa
playmp3list recommends no packages.
playmp3list suggests no packages.
-- no debconf information
>From ff62aa4618c684a30143117a725c94f524990ab0 Mon Sep 17 00:00:00 2001
From: Rabin Vincent <[email protected]>
Date: Sat, 10 Jan 2009 16:08:21 +0530
Subject: [PATCH] Fix crash on empty lines in playlist
---
playlist.cc | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/playlist.cc b/playlist.cc
index 48d8982..d6db5a9 100644
--- a/playlist.cc
+++ b/playlist.cc
@@ -294,8 +294,11 @@ mp3playlist::load_playlist(char *filename, bool pID3v1, bool pAlpha, bool pSortB
add_item(".","../",FT_DIR); // add standard entry
char line[256];
- while (fgets(line, 255, file)) // add all entries
- add_item(strtok(line,"\n\r"),pID3v1);
+ while (fgets(line, 255, file)) { // add all entries
+ char *p = strtok(line, "\n\r");
+ if (!p) continue;
+ add_item(p,pID3v1);
+ }
fclose(file);
--
1.5.6.5
--- End Message ---
--- Begin Message ---
Source: playmp3list
Source-Version: 0.95-5
We believe that the bug you reported is fixed in the latest version of
playmp3list, which is due to be installed in the Debian FTP archive:
playmp3list_0.95-5.diff.gz
to pool/main/p/playmp3list/playmp3list_0.95-5.diff.gz
playmp3list_0.95-5.dsc
to pool/main/p/playmp3list/playmp3list_0.95-5.dsc
playmp3list_0.95-5_i386.deb
to pool/main/p/playmp3list/playmp3list_0.95-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Barry deFreese <[email protected]> (supplier of updated playmp3list package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 29 Jan 2009 16:03:17 -0500
Source: playmp3list
Binary: playmp3list
Architecture: source i386
Version: 0.95-5
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <[email protected]>
Changed-By: Barry deFreese <[email protected]>
Description:
playmp3list - Another front-end to mpg123 with theme support
Closes: 300803 407699 511389
Changes:
playmp3list (0.95-5) unstable; urgency=low
.
* QA upload.
+ Set maintainer to Debian QA Group <[email protected]>.
* Acknowledge NMUs.
* Make clean not ignore errors.
* Clean up debian/copyright. (Add copyright years and holder).
* Use dh_installman instead of deprecated dh_installmanpages.
* Drop reference to deprecated dh_undocumented.
* Quote strings in menu file.
* interfaces.cc - Don't crash on dir access. (Closes: #407699).
+ Thanks to Rabin Vincent for the fix.
* playlist.cc - Don't crash on empty playlist line. (Closes: #511389).
+ Thanks to Rabin Vincent for the fix.
* playlist.cc - Don't crash on no file extension. (Closes: #300803).
+ Thanks to Rabin Vincent for the fix.
* Escape minus used as hyphen in manpage.
* Remove duplicate garbage in rules file.
* Remove unneeded debian/conffiles.
* Bump debhelper build-dep version to >= 5.
+ Move DH_COMPAT from rules to debian/compat and set to 5.
* Bump Standards Version to 3.8.0.
+ Menu policy transition.
Checksums-Sha1:
e232b06566feaa48ee07d016ecff2859594f58a7 1005 playmp3list_0.95-5.dsc
51e6be7c015987e6a85486096ea0b23f733373a0 6902 playmp3list_0.95-5.diff.gz
87d59b8e462836b142a73db7de77c4bbb9726392 41896 playmp3list_0.95-5_i386.deb
Checksums-Sha256:
ab32d2e879d8c40ce8e75a0e775e00e4f7c40932056720aea9692e26458690d0 1005
playmp3list_0.95-5.dsc
eb6293d0713b09f5e36716638076043ab88c98eccb07c6fb6e8d130d120b35f5 6902
playmp3list_0.95-5.diff.gz
be30e160f16a2b4cef60cd13b27e7d4dc3532cb8c3b28692935bfcc7e57d7080 41896
playmp3list_0.95-5_i386.deb
Files:
c7206ca212cee5647eafa9c899494086 1005 sound optional playmp3list_0.95-5.dsc
a09b58a01b07920b0fa8c90af81d0eb9 6902 sound optional playmp3list_0.95-5.diff.gz
16fd42fee96110a3f3bed06dc13d53e5 41896 sound optional
playmp3list_0.95-5_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkmCJPsACgkQ5ItltUs5T34wCACg0kCFDdX877IXJBSWHsH9wMAa
QU0AoOmSDzrE8uYzs7N5984qi+xlsihh
=jRE1
-----END PGP SIGNATURE-----
--- End Message ---
