Your message dated Fri, 30 Jan 2009 22:32:05 +0000
with message-id <[email protected]>
and subject line Bug#513605: fixed in libvirt 0.5.1-5
has caused the Debian Bug report #513605,
regarding should allow for non default ssh ports
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
513605: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513605
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libvirt0
Version: 0.5.1-4
Severity: major

(major since it makes it unusable if you move ssh to a non-standard
port)

For some bizarre reason, libvirt forces the port when it calls ssh to
22.  Why they don't just leave it empty I don't know - 22 _is_ the
default and you could always override it in ~/.ssh/config.

Anyway, this turns off this silly bit of code.  If it gains the
ability to _override_ the port in future, then fine.

Thanks for packaging this - now I look forward to being able to use
virt-manager (which also had this dumb hardcoding but went a step
further in that it also talked as root because remote root access is
such a _good_ idea!)

Adrian
-- 
Email: [email protected]  -*-  GPG key available on public key servers
Debian GNU/Linux - the maintainable distribution   -*-  www.debian.org
--- src/remote_internal.c.orig	2009-01-30 17:19:20.000000000 +0000
+++ src/remote_internal.c	2009-01-30 17:22:23.000000000 +0000
@@ -353,9 +353,6 @@
     } else if (transport == trans_tcp) {
         port = strdup (LIBVIRTD_TCP_PORT);
         if (!port) goto out_of_memory;
-    } else if (transport == trans_ssh) {
-        port = strdup ("22");
-        if (!port) goto out_of_memory;
     } else
         port = NULL;           /* Port not used for unix, ext. */
 
@@ -654,14 +651,16 @@
             goto out_of_memory;
 
         // Generate the final command argv[] array.
-        //   ssh -p $port [-l $username] $hostname $netcat -U $sockname [NULL]
+        //   ssh [-p $port] [-l $username] $hostname $netcat -U $sockname [NULL]
         if (VIR_ALLOC_N(cmd_argv, nr_args) < 0)
             goto out_of_memory;
 
         j = 0;
         cmd_argv[j++] = strdup (command);
-        cmd_argv[j++] = strdup ("-p");
-        cmd_argv[j++] = strdup (port);
+        if (port) {
+            cmd_argv[j++] = strdup ("-p");
+            cmd_argv[j++] = strdup (port);
+        }
         if (username) {
             cmd_argv[j++] = strdup ("-l");
             cmd_argv[j++] = strdup (username);

--- End Message ---
--- Begin Message ---
Source: libvirt
Source-Version: 0.5.1-5

We believe that the bug you reported is fixed in the latest version of
libvirt, which is due to be installed in the Debian FTP archive:

libvirt-bin_0.5.1-5_powerpc.deb
  to pool/main/libv/libvirt/libvirt-bin_0.5.1-5_powerpc.deb
libvirt-dev_0.5.1-5_powerpc.deb
  to pool/main/libv/libvirt/libvirt-dev_0.5.1-5_powerpc.deb
libvirt-doc_0.5.1-5_all.deb
  to pool/main/libv/libvirt/libvirt-doc_0.5.1-5_all.deb
libvirt0-dbg_0.5.1-5_powerpc.deb
  to pool/main/libv/libvirt/libvirt0-dbg_0.5.1-5_powerpc.deb
libvirt0_0.5.1-5_powerpc.deb
  to pool/main/libv/libvirt/libvirt0_0.5.1-5_powerpc.deb
libvirt_0.5.1-5.diff.gz
  to pool/main/libv/libvirt/libvirt_0.5.1-5.diff.gz
libvirt_0.5.1-5.dsc
  to pool/main/libv/libvirt/libvirt_0.5.1-5.dsc
python-libvirt_0.5.1-5_powerpc.deb
  to pool/main/libv/libvirt/python-libvirt_0.5.1-5_powerpc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated libvirt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 30 Jan 2009 23:06:29 +0100
Source: libvirt
Binary: libvirt-bin libvirt0 libvirt0-dbg libvirt-doc libvirt-dev python-libvirt
Architecture: source all powerpc
Version: 0.5.1-5
Distribution: experimental
Urgency: low
Maintainer: Debian Libvirt Maintainers 
<[email protected]>
Changed-By: Guido Günther <[email protected]>
Description: 
 libvirt-bin - the programs for the libvirt library
 libvirt-dev - development files for the libvirt library
 libvirt-doc - documentation for the libvirt library
 libvirt0   - library for interfacing with different virtualization systems
 libvirt0-dbg - library for interfacing with different virtualization systems
 python-libvirt - libvirt Python bindings
Closes: 512721 513605
Changes: 
 libvirt (0.5.1-5) experimental; urgency=low
 .
   * [d4a69d1] don't fail on missing locales (Closes: #512721)
   * [cecac4c] don't hardcode ssh port - based on a patch by Adrian
     Bridgett. (Closes: #513605)
   * [4565a65] drop superflous headers and footers from remaining patches
Checksums-Sha1: 
 35705b6a195b74e2e51fdb3288dcd09ec3f63807 1633 libvirt_0.5.1-5.dsc
 55baf9a76f3832ba88dc6bc50cf2a1d717ce7288 16649 libvirt_0.5.1-5.diff.gz
 8dc7c0cff96635fbb198db6bf6ba0c39587dd062 602700 libvirt-doc_0.5.1-5_all.deb
 b8fb53608d089139f98e99c43581d030ddaa888c 360232 libvirt-bin_0.5.1-5_powerpc.deb
 09eec7654ba4292c88dd06e2ec6739034dc3d7d7 330204 libvirt0_0.5.1-5_powerpc.deb
 b3b2f888bda51127aba72b64974e69998e0ee61d 520434 
libvirt0-dbg_0.5.1-5_powerpc.deb
 6f4995032f9ef56f9a9d9212ecf4f28049d35e0d 381858 libvirt-dev_0.5.1-5_powerpc.deb
 f07b895e5c8a1707501d3f65b9ff265412caf0da 191474 
python-libvirt_0.5.1-5_powerpc.deb
Checksums-Sha256: 
 4552ad458237cac6643a740420a963c059e8c9b53dcab55557a4fa70ea139bad 1633 
libvirt_0.5.1-5.dsc
 5e941754707eee6cee49ba69cb4af81958e5a6258342ecf7e46be6b766885fc6 16649 
libvirt_0.5.1-5.diff.gz
 8c5c5e3d893a88375346d92510a47174477247d6830b0e66da2fde6a1202d09f 602700 
libvirt-doc_0.5.1-5_all.deb
 0f2c6296ab29d57433a04a1dcc370804cbe5ec12e3b499198c097b38cdc00351 360232 
libvirt-bin_0.5.1-5_powerpc.deb
 044868d7974471d2f887537269d56200fe6aa39ea62c62fcf1d6c83ca9ca744a 330204 
libvirt0_0.5.1-5_powerpc.deb
 9dc3305669ce0a4321ef190d77108a5209a5a66d9b39ad3a1116f29679829d92 520434 
libvirt0-dbg_0.5.1-5_powerpc.deb
 2728d2aad60e1e8052cdd0897f79c41e8528165646848827b279b900d3dec159 381858 
libvirt-dev_0.5.1-5_powerpc.deb
 331a79cda6f6895c5db5d68372f64afe6fb1ed3cf10a57245565e1141902c391 191474 
python-libvirt_0.5.1-5_powerpc.deb
Files: 
 965006f5598de6d76afe5c85b6c14e51 1633 libs optional libvirt_0.5.1-5.dsc
 2bd7aa54ba484dfec76ce9e300f03c62 16649 libs optional libvirt_0.5.1-5.diff.gz
 f3ea14a0f3c50b8bfeec63a0f3c610fe 602700 doc optional 
libvirt-doc_0.5.1-5_all.deb
 ed77f250f10206983eced25a391d5736 360232 admin optional 
libvirt-bin_0.5.1-5_powerpc.deb
 a9ad66e20107749382384fd75d1f5f4b 330204 libs optional 
libvirt0_0.5.1-5_powerpc.deb
 3526f46eea48b9dc06c7b5e4646ef39f 520434 libs extra 
libvirt0-dbg_0.5.1-5_powerpc.deb
 d7803d897bdb36b958a98ddafe7c7e90 381858 libdevel optional 
libvirt-dev_0.5.1-5_powerpc.deb
 17a3dd59634aa61cf2e376f564c4cb11 191474 python optional 
python-libvirt_0.5.1-5_powerpc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJg33rn88szT8+ZCYRAl8dAJ465vpSf83XkEU3n5on9Gweq9q7vgCeN3EV
J7tMIAf27Tv8VK6TiqU3L9k=
=dHE1
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to