Your message dated Fri, 20 Feb 2009 23:17:39 +0000
with message-id <[email protected]>
and subject line Bug#511971: fixed in wiipdf 1.2-2
has caused the Debian Bug report #511971,
regarding Should check return code from system() calls
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
511971: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=511971
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: wiipdf
Version: 1.1-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jaunty ubuntu-patch
Hi,
In Ubuntu the buildds build everything with -D_FORTIFY_SOURCE=2
by default, which among other things turns on warnings when return
codes of functions with the __warn_unused attribute set are not
checked.
Your package hit this check as it doesn't check the return code of
system(). Attached is a patch to correct this.
Please consider applying it.
Thanks,
James
diff -u wiipdf-1.1/debian/changelog wiipdf-1.1/debian/changelog
only in patch2:
unchanged:
--- wiipdf-1.1.orig/wiipdf.c
+++ wiipdf-1.1/wiipdf.c
@@ -51,7 +51,10 @@
fprintf(stderr, "Error allocating memory\n");
exit(1);
}
- system(buffer);
+ if (!system(buffer)) {
+ fprintf(stderr, "Error executing xpdf\n");
+ exit(1);
+ }
}
static void quit_xpdf() {
@@ -60,7 +63,10 @@
fprintf(stderr, "Error allocating memory\n");
exit(1);
}
- system(buffer);
+ if (!system(buffer)) {
+ fprintf(stderr, "Error executing xpdf\n");
+ exit(1);
+ }
}
/*
--- End Message ---
--- Begin Message ---
Source: wiipdf
Source-Version: 1.2-2
We believe that the bug you reported is fixed in the latest version of
wiipdf, which is due to be installed in the Debian FTP archive:
wiipdf_1.2-2.diff.gz
to pool/main/w/wiipdf/wiipdf_1.2-2.diff.gz
wiipdf_1.2-2.dsc
to pool/main/w/wiipdf/wiipdf_1.2-2.dsc
wiipdf_1.2-2_i386.deb
to pool/main/w/wiipdf/wiipdf_1.2-2_i386.deb
wiipdf_1.2.orig.tar.gz
to pool/main/w/wiipdf/wiipdf_1.2.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Stapelberg <[email protected]> (supplier of updated wiipdf
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 20 Feb 2009 03:04:13 +0100
Source: wiipdf
Binary: wiipdf
Architecture: source i386
Version: 1.2-2
Distribution: unstable
Urgency: low
Maintainer: Michael Stapelberg <[email protected]>
Changed-By: Michael Stapelberg <[email protected]>
Description:
wiipdf - present a PDF file using your wiimote
Closes: 500901 511971
Changes:
wiipdf (1.2-2) unstable; urgency=low
.
* Correctly set dependencies (debhelper)
.
wiipdf (1.2-1) unstable; urgency=low
.
* Returncode of system() is now checked (Closes: #511971)
.
wiipdf (1.1-1) unstable; urgency=low
.
* Handling filenames with spaces works now
.
wiipdf (1.0-3) unstable; urgency=low
.
* Add README.Debian with instructions
.
wiipdf (1.0-2) unstable; urgency=low
.
* Closes: #500901
.
wiipdf (1.0-1) unstable; urgency=low
.
* First release
Checksums-Sha1:
f8d11533a47a33673bb77c9b449edc61fcd64356 990 wiipdf_1.2-2.dsc
fa50e935b5743bd18a20eaa4c35280e5bd3ac843 2830 wiipdf_1.2.orig.tar.gz
1d7d45ba510156bf457da71e619d88a8032ba6a7 2565 wiipdf_1.2-2.diff.gz
5adb18ef6bd47b2f632569e3c927e7d38993094a 6350 wiipdf_1.2-2_i386.deb
Checksums-Sha256:
7f96a0b706b237c10898ecfa7502672f37e813f3e2d0b5ba40e7cfaafb6ac4f4 990
wiipdf_1.2-2.dsc
a3c88d31ee7ac8e9042afab4f962f2b5fe33b6c61b98798a319f9df5a5348f9b 2830
wiipdf_1.2.orig.tar.gz
088da48d0e2e4acf307947d5328a43056ee44bf9a2de9ba5d52c6ceb16c2e555 2565
wiipdf_1.2-2.diff.gz
c7471d8e69af4ae6829c3fc230c15ec724556bf110176971dcfac664e76951e9 6350
wiipdf_1.2-2_i386.deb
Files:
1af32758862a16afa49d5d5596af4eb3 990 utils optional wiipdf_1.2-2.dsc
ed9d0df2926e5933d1ba2134ea6a30d3 2830 utils optional wiipdf_1.2.orig.tar.gz
a1ca2375e77ceae3825886a6c39cbebb 2565 utils optional wiipdf_1.2-2.diff.gz
ddab93b9d02f5bfc0db2cdc8b4c81f54 6350 utils optional wiipdf_1.2-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkmfNk0ACgkQCV53xXnMZYYiMwCglUD3XUPeZKbzpnc6BYx3eX3s
XNgAoOX77PdACpSKmKu37q79y9t9oytR
=Psgg
-----END PGP SIGNATURE-----
--- End Message ---
