Your message dated Mon, 02 Mar 2009 21:47:09 +0000
with message-id <[email protected]>
and subject line Bug#516846: fixed in htop 0.8.1-4
has caused the Debian Bug report #516846,
regarding htop: feature openvz - veid listing doesnt work on OpenVZ kernels  
greater than 2.6.18
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
516846: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516846
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: htop
Version: 0.8.1-3


On OpenVZ enabled kernels greater then 2.6.18, VEID is zero;
patch solves this issue.

Bye,
 Thorsten
--
OpenVZ Power User with a swirl
http://debian.systs.org/category/openvz/
diff -Naur htop-0.8.1.orig/ProcessList.c htop-0.8.1/ProcessList.c
--- htop-0.8.1.orig/ProcessList.c	2008-09-23 08:23:14.000000000 +0200
+++ htop-0.8.1/ProcessList.c	2009-02-24 00:09:37.000000000 +0100
@@ -625,20 +625,28 @@
                process->vpid = process->pid;
                process->veid = 0;
             } else {
-               snprintf(statusfilename, MAX_NAME, "%s/%s/stat", dirname, name);
+               snprintf(statusfilename, MAX_NAME, "%s/%s/status", dirname, name);
                status = ProcessList_fopen(this, statusfilename, "r");
                if (status == NULL) 
                   goto errorReadingProcess;
-               num = ProcessList_fread(this, status, 
-                  "%*u %*s %*c %*u %*u %*u %*u %*u %*u %*u "
-                  "%*u %*u %*u %*u %*u %*u %*u %*u "
-                  "%*u %*u %*u %*u %*u %*u %*u %*u "
-                  "%*u %*u %*u %*u %*u %*u %*u %*u "
-                  "%*u %*u %*u %*u %*u %*u %*u %*u "
-                  "%*u %*u %*u %*u %*u %*u %*u "
-                  "%u %u",
-                  &process->vpid, &process->veid);
-               fclose(status);
+               else {
+                  char buffer[256];
+                  process->veid = 0;
+                  while (!feof(status)) {
+                     char* ok = fgets(buffer, 255, status);
+                     if (!ok)
+                        break;
+
+                     if (String_startsWith(buffer, "envID:")) {
+                        int veid;
+                        int ok = ProcessList_read(this, buffer, "envID:\t%d", &veid);
+                        if (ok >= 1) {
+                           process->veid = veid;
+                        }
+                     }
+                  }
+                  fclose(status);
+               }
             }
             #endif
 

--- End Message ---
--- Begin Message ---
Source: htop
Source-Version: 0.8.1-4

We believe that the bug you reported is fixed in the latest version of
htop, which is due to be installed in the Debian FTP archive:

htop_0.8.1-4.diff.gz
  to pool/main/h/htop/htop_0.8.1-4.diff.gz
htop_0.8.1-4.dsc
  to pool/main/h/htop/htop_0.8.1-4.dsc
htop_0.8.1-4_amd64.deb
  to pool/main/h/htop/htop_0.8.1-4_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Eugene V. Lyubimkin <[email protected]> (supplier of updated htop package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 02 Mar 2009 23:17:04 +0200
Source: htop
Binary: htop
Architecture: source amd64
Version: 0.8.1-4
Distribution: unstable
Urgency: low
Maintainer: Eugene V. Lyubimkin <[email protected]>
Changed-By: Eugene V. Lyubimkin <[email protected]>
Description: 
 htop       - interactive processes viewer
Closes: 516846 516847
Changes: 
 htop (0.8.1-4) unstable; urgency=low
 .
   * debian/patches:
     - New 600-openvz-veid-on-kernels-gt-2.6.18.patch: fix determining veid on
       openvz-enabled kernels greater than 2.6.18. Patch by
       Thorsten Schifferdecker <[email protected]>. (Closes: #516846)
     - New 610-rename-veid-to-ctid.patch: openvz: renames 'veid' -> 'ctid' since
       it's now a preferred term. Patch by
       Thorsten Schifferdecker <[email protected]>. (Closes: #516847)
     - New 700-ltrace-support.patch: add ltrace(1) support in addition to strace
       support. Patch by <[email protected]>.
     - New 800-tree-view-with-userland-threads.patch: patch to fix tree view 
when
       userland threads are hidden, taken from Ubuntu.
Checksums-Sha1: 
 5583bbe4e81ff5d01382853c2bc4d92831d54d37 1054 htop_0.8.1-4.dsc
 bfa1272824ca093a7da11595ddb85f11ab6c1fd0 8024 htop_0.8.1-4.diff.gz
 03e20525b38a3be295ca944bf07004605bb60fa2 59960 htop_0.8.1-4_amd64.deb
Checksums-Sha256: 
 990508d4db682ca70834e4755f1f1bce02c06292bf0b145acda7da50bde03e44 1054 
htop_0.8.1-4.dsc
 b89740872acb7a52024cdecaab3d7f0d379add8a86483d1051082e81638a228a 8024 
htop_0.8.1-4.diff.gz
 95a1a55a67c4130fb606f7b42be5c91b9bbe8645023dd86aad0340b7daf88af4 59960 
htop_0.8.1-4_amd64.deb
Files: 
 9c43fb4b3f816ac3076233107272ec5b 1054 utils optional htop_0.8.1-4.dsc
 b53423c91c097aab1893b9f8e1c9259b 8024 utils optional htop_0.8.1-4.diff.gz
 425d246a693e35921b798f9e632aa62f 59960 utils optional htop_0.8.1-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmsUa0ACgkQchorMMFUmYyZfgCeMehJ2GYevW5QDm5p09+2/2su
wykAn3+y0H+jq6SMcCNOrgyJN7VeOCN2
=GjYm
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to