Your message dated Thu, 12 Mar 2009 19:12:32 +1100
with message-id <[email protected]>
and subject line Re: dh-make: The generated rules template could use
abstraction: $(INSTALL_DATA)
has caused the Debian Bug report #335318,
regarding dh-make: The generated rules template could use abstraction:
$(INSTALL_DATA) etc.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
335318: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=335318
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-make
Version: 0.40
Severity: wishlist
The currently generated rules file read something like:
install: build
dh_testdir
dh_testroot
dh_clean -k
dh_installdirs
...
Where developers naturally want to write:
install -s -m 755 xproc-src/gxproc $(xproc-base)/usr/bin
install -s -m 755 gtk-shell $(gshell-base)/usr/bin
install -m 755 ftp.sh $(base)/usr/share/gxedit
SUGGESTION
=======================
Add common variables that can be used in the generate template for
better abtraction. Like this:
#!/usr/bin/make -f
# -*- makefile -*-
# Sample debian/rules that uses debhelper.
# This file was originally written by Joey Hess and Craig Small.
# As a special exception, when this file is copied by dh-make into a
# dh-make output file, you may use that output file without restriction.
# This special exception was added by Craig Small in version 0.37 of
dh-make.
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
+ INSTALL = /usr/bin/install
+ INSTALL_BIN = $(INSTALL) -m 755
+ INSTALL_DATA = $(INSTALL) -m 644
+ INSTALL_DIR = $(INSTALL_BIN) -d
...
Which hopefully leads programmers to take advantage of the in the 'install'
target.
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-1-686
Locale: LANG=C, LC_CTYPE=C (charmap=ISO-8859-1) (ignored: LC_ALL set to en_US)
Versions of packages dh-make depends on:
ii debhelper 4.9.13 helper programs for debian/rules
ii dpkg-dev 1.13.11 package building tools for Debian
ii make 3.80-11 The GNU version of the "make" util
ii perl 5.8.7-7 Larry Wall's Practical Extraction
dh-make recommends no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
Hello,
I have looked at this suggestion but I believe that it will add a lot
of clutter to the rules file which is already pretty busy. Most
packages that I have seen the rules file for just do make install in
their install target anyhow.
There would be times that the parameters would be used, but thats no-way
near as common as the make target.
- Craig
--
Craig Small GnuPG:1C1B D893 1418 2AF4 45EE 95CB C76C E5AC 12CA DFA5
http://www.enc.com.au/ csmall at : enc.com.au
http://www.debian.org/ Debian GNU/Linux, software should be Free
--- End Message ---
