Your message dated Wed, 13 Jul 2005 00:27:00 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Closing bug
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Oct 2003 12:08:35 +0000
>From [EMAIL PROTECTED] Thu Oct 23 07:08:33 2003
Return-path: <[EMAIL PROTECTED]>
Received: from poulet.zoy.org [80.65.228.129]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1ACeGX-0000ie-00; Thu, 23 Oct 2003 07:08:33 -0500
Received: from c18.via.ecp.fr (localhost.localdomain [127.0.0.1])
by poulet.zoy.org (Postfix) with ESMTP
id E6C6DB254D; Thu, 23 Oct 2003 14:08:31 +0200 (CEST)
Received: by c18.via.ecp.fr (Postfix, from userid 1000)
id 0FF0442906; Thu, 23 Oct 2003 14:08:30 +0200 (CEST)
Content-Type: multipart/mixed; boundary="===============1031325675=="
MIME-Version: 1.0
From: Sam Hocevar <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: libsdlnet1.2-dev: SDLNet_(Read|Write)(16|32) assume host endianness
X-Mailer: reportbug 2.34
Date: Thu, 23 Oct 2003 14:08:30 +0200
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Status: No, hits=-6.9 required=4.0
tests=BAYES_60,HAS_PACKAGE,PATCH_UNIFIED_DIFF
autolearn=ham version=2.53-bugs.debian.org_2003_10_21
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_10_21
(1.174.2.15-2003-03-30-exp)
This is a multi-part MIME message sent by reportbug.
--===============1031325675==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: libsdlnet1.2-dev
Version: 1.2.5-3
Severity: important
Tags: patch
When SDL_DATA_ALIGNED is defined, SDLNet_Read16 etc. are defined as
byte-swapping macros. However, since network order is big endian, these
macros should not swap anything on big endian systems. Patch attached.
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux c18 2.4.21-rc5 #2 Wed May 28 22:10:14 CEST 2003 i686
Locale: LANG=C, LC_CTYPE=fr_FR
--===============1031325675==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="/home/sam/treenor/treenor/patch-sdlnet-endianness.diff"
--- /usr/include/SDL/SDL_net.h 2003-10-08 05:22:54.000000000 +0200
+++ SDL_net.h 2003-10-23 13:46:44.000000000 +0200
@@ -332,7 +332,6 @@
#define SDLNet_Write16(value, areap) \
(*(Uint16 *)(areap) = SDL_SwapBE16(value))
#else
-#if SDL_BYTEORDER == SDL_BIG_ENDIAN
#define SDLNet_Write16(value, areap) \
do \
{ \
@@ -340,15 +339,6 @@
area[0] = (value >> 8) & 0xFF; \
area[1] = value & 0xFF; \
} while ( 0 )
-#else
-#define SDLNet_Write16(value, areap) \
-do \
-{ \
- Uint8 *area = (Uint8 *)(areap); \
- area[1] = (value >> 8) & 0xFF; \
- area[0] = value & 0xFF; \
-} while ( 0 )
-#endif
#endif /* !SDL_DATA_ALIGNED */
/* Write a 32 bit value to network packet buffer */
@@ -356,7 +346,6 @@
#define SDLNet_Write32(value, areap) \
*(Uint32 *)(areap) = SDL_SwapBE32(value);
#else
-#if SDL_BYTEORDER == SDL_BIG_ENDIAN
#define SDLNet_Write32(value, areap) \
do \
{ \
@@ -366,17 +355,6 @@
area[2] = (value >> 8) & 0xFF; \
area[3] = value & 0xFF; \
} while ( 0 )
-#else
-#define SDLNet_Write32(value, areap) \
-do \
-{ \
- Uint8 *area = (Uint8 *)(areap); \
- area[3] = (value >> 24) & 0xFF; \
- area[2] = (value >> 16) & 0xFF; \
- area[1] = (value >> 8) & 0xFF; \
- area[0] = value & 0xFF; \
-} while ( 0 )
-#endif
#endif /* !SDL_DATA_ALIGNED */
/* Read a 16 bit value from network packet buffer */
@@ -384,13 +362,8 @@
#define SDLNet_Read16(areap) \
(SDL_SwapBE16(*(Uint16 *)(areap)))
#else
-#if SDL_BYTEORDER == SDL_BIG_ENDIAN
#define SDLNet_Read16(areap) \
((((Uint8 *)areap)[0] << 8) | ((Uint8 *)areap)[1] << 0)
-#else
-#define SDLNet_Read16(areap) \
- ((((Uint8 *)areap)[1] << 8) | ((Uint8 *)areap)[0] << 0)
-#endif
#endif /* !SDL_DATA_ALIGNED */
/* Read a 32 bit value from network packet buffer */
@@ -398,15 +371,9 @@
#define SDLNet_Read32(areap) \
(SDL_SwapBE32(*(Uint32 *)(areap)))
#else
-#if SDL_BYTEORDER == SDL_BIG_ENDIAN
#define SDLNet_Read32(areap) \
((((Uint8 *)areap)[0] << 24) | (((Uint8 *)areap)[1] << 16) | \
(((Uint8 *)areap)[2] << 8) | ((Uint8 *)areap)[3] << 0)
-#else
-#define SDLNet_Read32(areap) \
- ((((Uint8 *)areap)[3] << 24) | (((Uint8 *)areap)[2] << 16) | \
- (((Uint8 *)areap)[1] << 8) | ((Uint8 *)areap)[0] << 0)
-#endif
#endif /* !SDL_DATA_ALIGNED */
#ifdef MACOS_OPENTRANSPORT
--===============1031325675==--
---------------------------------------
Received: (at 217221-done) by bugs.debian.org; 12 Jul 2005 22:27:02 +0000
>From [EMAIL PROTECTED] Tue Jul 12 15:27:02 2005
Return-path: <[EMAIL PROTECTED]>
Received: from poulet.zoy.org [80.65.228.129] (postfix)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DsTDS-00069C-00; Tue, 12 Jul 2005 15:27:02 -0700
Received: from localhost (localhost.localdomain [127.0.0.1])
by poulet.zoy.org (Postfix) with ESMTP id 493F3B2585
for <[EMAIL PROTECTED]>; Wed, 13 Jul 2005 00:27:00 +0200 (CEST)
Received: from poulet.zoy.org ([127.0.0.1])
by localhost (poulet [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id 15752-05 for <[EMAIL PROTECTED]>;
Wed, 13 Jul 2005 00:27:00 +0200 (CEST)
Received: by poulet.zoy.org (Postfix, from userid 1000)
id 2F301B257B; Wed, 13 Jul 2005 00:27:00 +0200 (CEST)
Date: Wed, 13 Jul 2005 00:27:00 +0200
From: Sam Hocevar <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Closing bug
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Mail-Copies-To: never
X-No-CC: I read mailing-lists; do not CC me on replies.
X-Snort: uid=0(root) gid=0(root)
User-Agent: Mutt/1.5.9i
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at zoy.org
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
This bug was fixed by the sdl-net1.2 1.2.5-4 upload.
--
Sam.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
