Your message dated Mon, 06 Apr 2009 21:22:26 +0000
with message-id <[email protected]>
and subject line Bug#416540: fixed in webdeveloper 1.1.6+repack-4
has caused the Debian Bug report #416540,
regarding new webdeveloper feature: Forms|Insert Clean Submit Buttons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
416540: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=416540
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: webdeveloper
Severity: wishlist
Tags: patch
Modern forms that are heavily javascript-reliant often lack regular,
clickable submit buttons. It would be a nice feature for Web
Developer to have an entry in the "Forms" menu that inserts a nice
clean Submit element at the end of every form on a page.
This is especially useful for forms which submit via an "onchange"
event on a select element, if you've used webdeveloper to switch the
select element to a text input.
I'm attaching a patch which i wrote that enables this feature, based
heavily on the existing webdeveloper code. I'm licensing the patch
itself GPLv2 or later. Feel free to forward it upstream,
if that's appropriate.
Thanks for maintaining this great iceweasel extension in debian.
--dkg
-- System Information:
Debian Release: 4.0
APT prefers testing
APT policy: (500, 'testing'), (200, 'unstable'), (101, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
diff -ur webdeveloper-1.0.2+0/content_common/webdeveloper/forms.js webdeveloper-1.0.2+0.dkg/content_common/webdeveloper/forms.js
--- webdeveloper-1.0.2+0/content_common/webdeveloper/forms.js 2005-12-18 16:55:36.000000000 -0500
+++ webdeveloper-1.0.2+0.dkg/content_common/webdeveloper/forms.js 2007-03-28 15:52:23.000000000 -0400
@@ -112,6 +112,60 @@
}
}
+// Inserts simple clean "submit" button in all forms
+function webdeveloper_insertCleanSubmit()
+{
+ var submitsInserted = 0;
+ var displayFormDetailsMenu = document.getElementById("webdeveloper-display-form-details-menu");
+ var documentList = webdeveloper_getDocuments(webdeveloper_getContentWindow());
+ var documentLength = documentList.length;
+ var form = null;
+ var formLength = null;
+ var formList = null;
+ var pageDocument = null;
+
+ // Loop through the documents
+ for(var i = 0; i < documentLength; i++)
+ {
+ pageDocument = documentList[i];
+ formList = pageDocument.getElementsByTagName("form");
+ formLength = formList.length;
+
+ // Loop through all the forms
+ for(var j = 0; j < formLength; j++)
+ {
+ form = formList[j];
+ var sub = pageDocument.createElement("input");
+ sub.setAttribute('type', 'submit');
+ form.appendChild(sub);
+ submitsInserted++;
+ }
+ }
+ // Reapply the display form details style sheet if it is currently on - fixes bug with form method not updating
+ if(displayFormDetailsMenu.getAttribute("checked"))
+ {
+ webdeveloper_removeStyleSheet("webdeveloper-display-form-details", false);
+ webdeveloper_displayFormDetails(displayFormDetailsMenu, false);
+ }
+
+ // If the hide informational dialogs preference is not set
+ if(!webdeveloper_getBooleanPreference("webdeveloper.informational.dialogs.hide", true))
+ {
+ var stringBundle = document.getElementById("webdeveloper-string-bundle");
+ var title = stringBundle.getString("webdeveloper_insertCleanSubmit");
+
+ // If one element was enabled
+ if(submitsInserted == 1)
+ {
+ webdeveloper_informationalDialog(title, stringBundle.getString("webdeveloper_insertCleanSubmitSingleResult"));
+ }
+ else
+ {
+ webdeveloper_informationalDialog(title, stringBundle.getFormattedString("webdeveloper_insertCleanSubmitMultipleResult", [submitsInserted]));
+ }
+ }
+}
+
// Converts select elements to text inputs
function webdeveloper_convertSelectElementsToTextInputs()
{
diff -ur webdeveloper-1.0.2+0/content_common/webdeveloper/webdeveloper.xul webdeveloper-1.0.2+0.dkg/content_common/webdeveloper/webdeveloper.xul
--- webdeveloper-1.0.2+0/content_common/webdeveloper/webdeveloper.xul 2006-01-18 01:09:37.000000000 -0500
+++ webdeveloper-1.0.2+0.dkg/content_common/webdeveloper/webdeveloper.xul 2007-03-28 14:33:22.000000000 -0400
@@ -150,6 +150,7 @@
</menupopup>
</menu>
<menuitem label="&webdeveloper.convert.select.elements.text.inputs.label;" accesskey="&webdeveloper.convert.select.elements.text.inputs.key;" oncommand="webdeveloper_convertSelectElementsToTextInputs()"/>
+ <menuitem label="&webdeveloper.insert.clean.submit.label;" accesskey="&webdeveloper.insert.clean.submit.key;" oncommand="webdeveloper_insertCleanSubmit()"/>
<menuseparator/>
<menuitem label="&webdeveloper.enable.auto.completion.label;" accesskey="&webdeveloper.enable.auto.completion.key;" oncommand="webdeveloper_enableFormAutoCompletion()"/>
<menuitem label="&webdeveloper.enable.form.fields.label;" accesskey="&webdeveloper.enable.form.fields.key;" oncommand="webdeveloper_enableFormFields()"/>
@@ -424,6 +425,7 @@
</menupopup>
</menu>
<menuitem label="&webdeveloper.convert.select.elements.text.inputs.label;" accesskey="&webdeveloper.convert.select.elements.text.inputs.key;" oncommand="webdeveloper_convertSelectElementsToTextInputs()"/>
+ <menuitem label="&webdeveloper.insert.clean.submit.label;" accesskey="&webdeveloper.insert.clean.submit.key;" oncommand="webdeveloper_insertCleanSubmit()"/>
<menuseparator/>
<menuitem label="&webdeveloper.enable.auto.completion.label;" accesskey="&webdeveloper.enable.auto.completion.key;" oncommand="webdeveloper_enableFormAutoCompletion()"/>
<menuitem label="&webdeveloper.enable.form.fields.label;" accesskey="&webdeveloper.enable.form.fields.key;" oncommand="webdeveloper_enableFormFields()"/>
@@ -696,6 +698,7 @@
</menupopup>
</menu>
<menuitem label="&webdeveloper.convert.select.elements.text.inputs.label;" accesskey="&webdeveloper.convert.select.elements.text.inputs.key;" oncommand="webdeveloper_convertSelectElementsToTextInputs()"/>
+ <menuitem label="&webdeveloper.insert.clean.submit.label;" accesskey="&webdeveloper.insert.clean.submit.key;" oncommand="webdeveloper_insertCleanSubmit()"/>
<menuseparator/>
<menuitem label="&webdeveloper.enable.auto.completion.label;" accesskey="&webdeveloper.enable.auto.completion.key;" oncommand="webdeveloper_enableFormAutoCompletion()"/>
<menuitem label="&webdeveloper.enable.form.fields.label;" accesskey="&webdeveloper.enable.form.fields.key;" oncommand="webdeveloper_enableFormFields()"/>
diff -ur webdeveloper-1.0.2+0/debian/changelog webdeveloper-1.0.2+0.dkg/debian/changelog
--- webdeveloper-1.0.2+0/debian/changelog 2007-03-28 15:55:10.000000000 -0400
+++ webdeveloper-1.0.2+0.dkg/debian/changelog 2007-03-28 14:36:39.000000000 -0400
@@ -1,3 +1,9 @@
+webdeveloper (1.0.2+0-3~dkg1) unstable; urgency=low
+
+ * added "Insert Clean Submit Buttons" to Forms menu.
+
+ -- Daniel Kahn Gillmor <[email protected]> Wed, 28 Mar 2007 14:36:39 -0400
+
webdeveloper (1.0.2+0-2) unstable; urgency=low
* Updates of packaging for Firefox/Iceweasel rename:
diff -ur webdeveloper-1.0.2+0/locale_common/en-US/webdeveloper/menu.dtd webdeveloper-1.0.2+0.dkg/locale_common/en-US/webdeveloper/menu.dtd
--- webdeveloper-1.0.2+0/locale_common/en-US/webdeveloper/menu.dtd 2006-01-18 01:09:54.000000000 -0500
+++ webdeveloper-1.0.2+0.dkg/locale_common/en-US/webdeveloper/menu.dtd 2007-03-28 14:36:13.000000000 -0400
@@ -146,6 +146,8 @@
<!ENTITY webdeveloper.populate.form.fields.key "P">
<!ENTITY webdeveloper.remove.maximum.lengths.label "Remove Maximum Lengths">
<!ENTITY webdeveloper.remove.maximum.lengths.key "L">
+<!ENTITY webdeveloper.insert.clean.submit.label "Insert Clean Submit Buttons">
+<!ENTITY webdeveloper.insert.clean.submit.key "B">
<!-- Convert Form Methods Features -->
<!ENTITY webdeveloper.gets.posts.label "GETs To POSTs">
diff -ur webdeveloper-1.0.2+0/locale_common/en-US/webdeveloper/webdeveloper.properties webdeveloper-1.0.2+0.dkg/locale_common/en-US/webdeveloper/webdeveloper.properties
--- webdeveloper-1.0.2+0/locale_common/en-US/webdeveloper/webdeveloper.properties 2006-01-18 01:09:54.000000000 -0500
+++ webdeveloper-1.0.2+0.dkg/locale_common/en-US/webdeveloper/webdeveloper.properties 2007-03-28 15:22:41.000000000 -0400
@@ -124,6 +124,11 @@
webdeveloper_convertSelectElementsToTextInputsSingleResult=1 select element has been converted to a text input.
webdeveloper_convertSelectElementsToTextInputsMultipleResult=%S select elements have been converted to text inputs.
+# Insert Clean Submit Buttons
+webdeveloper_insertCleanSubmit=Insert Clean Submit Buttons
+webdeveloper_insertCleanSubmitSingleResult=A clean submit input element has been added to 1 form.
+webdeveloper_insertCleanSubmitMultipleResult=Clean submit elements have been added to %S forms.
+
# Delete Domain Cookies
webdeveloper_deleteDomainCookies=Delete Domain Cookies
webdeveloper_deleteDomainCookiesConfirmation=Are you sure you want to delete the domain cookies?
--- End Message ---
--- Begin Message ---
Source: webdeveloper
Source-Version: 1.1.6+repack-4
We believe that the bug you reported is fixed in the latest version of
webdeveloper, which is due to be installed in the Debian FTP archive:
iceweasel-webdeveloper_1.1.6+repack-4_all.deb
to pool/main/w/webdeveloper/iceweasel-webdeveloper_1.1.6+repack-4_all.deb
webdeveloper_1.1.6+repack-4.diff.gz
to pool/main/w/webdeveloper/webdeveloper_1.1.6+repack-4.diff.gz
webdeveloper_1.1.6+repack-4.dsc
to pool/main/w/webdeveloper/webdeveloper_1.1.6+repack-4.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Luca Falavigna <[email protected]> (supplier of updated webdeveloper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 05 Apr 2009 16:50:55 +0200
Source: webdeveloper
Binary: iceweasel-webdeveloper
Architecture: source all
Version: 1.1.6+repack-4
Distribution: unstable
Urgency: low
Maintainer: Luca Falavigna <[email protected]>
Changed-By: Luca Falavigna <[email protected]>
Description:
iceweasel-webdeveloper - web developer extension for the Iceweasel web browser
Closes: 416540 520692
Changes:
webdeveloper (1.1.6+repack-4) unstable; urgency=low
.
* debian/patches/toolbar_hidden_by_default:
- Adjust patch to not propagate collapsed attribute across browser
sessions (Closes: #520692).
* debian/patches/insert_clean_submit_button:
- Feature: allow users to add simple, clean submit buttons in every
form on the page, thanks Daniel Kahn Gillmor (Closes: #416540).
Checksums-Sha1:
2340e18372e9d6530a2e4b8d97babe259be16e8d 1170 webdeveloper_1.1.6+repack-4.dsc
a8346e8b6565402b7ec25da8037d65f481e4c802 267149
webdeveloper_1.1.6+repack-4.diff.gz
882b2f19088ec34a7749c8d4e59023914f0d3248 369436
iceweasel-webdeveloper_1.1.6+repack-4_all.deb
Checksums-Sha256:
c04ddedff347d2c0e8284e89e3bc66d26ed08c3cd8786f1d85a837c4b1ed00ba 1170
webdeveloper_1.1.6+repack-4.dsc
6582230e047153de1b7d9a807f74a66851be556f0035f57a1b48d51c3d03d940 267149
webdeveloper_1.1.6+repack-4.diff.gz
5ea7eee5dd8cf1306bff7611b655da780b0d9e31bb7d8f058e4552677ad7b0d7 369436
iceweasel-webdeveloper_1.1.6+repack-4_all.deb
Files:
d9c29e56eb670a6665e5e3d33105b671 1170 devel optional
webdeveloper_1.1.6+repack-4.dsc
e7e6211613869f3c5f016aab0a4d3b1a 267149 devel optional
webdeveloper_1.1.6+repack-4.diff.gz
53475fd3efc781ee23ae1fe1e7d1ef37 369436 devel optional
iceweasel-webdeveloper_1.1.6+repack-4_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAknaYREACgkQnXjXEYa8KlDExACbBWI28eZHa7b0fgCHFLIJvxZa
XLYAnR+aew+Zp/k0TGS6I67JSvau4pW4
=PkGb
-----END PGP SIGNATURE-----
--- End Message ---
