Your message dated Sat, 11 Apr 2009 10:02:25 +0000
with message-id <[email protected]>
and subject line Bug#521408: fixed in samba 2:3.3.3-1
has caused the Debian Bug report #521408,
regarding samba: W2k3 replies with NT_STATUS_INVALID_SID, even if other SIDs in
the list are valid.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
521408: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521408
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: samba
Version: 2:3.2.5-4
Severity: normal
Tags: patch
Please consider following patch for debian stable:
diff --git a/source/passdb/lookup_sid.c b/source/passdb/lookup_sid.c
index a7175b9..d767fa4 100644
--- a/source/passdb/lookup_sid.c
+++ b/source/passdb/lookup_sid.c
@@ -804,7 +804,7 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
} else {
/* This is a normal SID with rid component */
if (!sid_split_rid(&sid, &rid)) {
- result = NT_STATUS_INVALID_PARAMETER;
+ result = NT_STATUS_INVALID_SID;
goto fail;
}
}
diff --git a/source/rpc_server/srv_lsa_nt.c b/source/rpc_server/srv_lsa_nt.c
index 9ce992c..9d411ec 100644
--- a/source/rpc_server/srv_lsa_nt.c
+++ b/source/rpc_server/srv_lsa_nt.c
@@ -830,6 +830,10 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
&names,
&mapped_count);
+ if (NT_STATUS_IS_ERR(status)) {
+ return status;
+ }
+
/* Convert from lsa_TranslatedName2 to lsa_TranslatedName */
names_out = TALLOC_ARRAY(p->mem_ctx, struct lsa_TranslatedName,
num_sids);
More info:
https://bugzilla.samba.org/attachment.cgi?id=4009&action=view
https://bugzilla.samba.org/show_bug.cgi?id=6097
Can be applied also for testing (anyway, will be included in samba release).
Thank you,
Pavel
-- System Information:
Debian Release: 5.0
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=cs_CZ.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages samba depends on:
ii adduser 3.110 add and remove users and groups
ii debconf [debconf-2.0 1.5.24 Debian configuration management sy
ii libacl1 2.2.47-2 Access control list shared library
ii libattr1 1:2.4.43-2 Extended attribute shared library
ii libc6 2.7-18 GNU C Library: Shared libraries
ii libcomerr2 1.41.3-1 common error description library
ii libcups2 1.3.8-1lenny4.1 Common UNIX Printing System(tm) -
ii libgnutls26 2.4.2-6+lenny1 the GNU TLS library - runtime libr
ii libkrb53 1.6.dfsg.4~beta1-5 MIT Kerberos runtime libraries
ii libldap-2.4-2 2.4.11-1 OpenLDAP libraries
ii libpam-modules 1.0.1-5 Pluggable Authentication Modules f
ii libpam-runtime 1.0.1-5 Runtime support for the PAM librar
ii libpam0g 1.0.1-5 Pluggable Authentication Modules l
ii libpopt0 1.14-4 lib for parsing cmdline parameters
ii libtalloc1 1.2.0~git20080616-1 hierarchical pool based memory all
ii libwbclient0 2:3.2.5-4 client library for interfacing wit
ii logrotate 3.7.1-5 Log rotation utility
ii lsb-base 3.2-20 Linux Standard Base 3.2 init scrip
ii procps 1:3.2.7-11 /proc file system utilities
ii samba-common 2:3.2.5-4 Samba common files used by both th
ii update-inetd 4.31 inetd configuration file updater
ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime
samba recommends no packages.
Versions of packages samba suggests:
pn ldb-tools <none> (no description available)
pn openbsd-inetd | inet-superser <none> (no description available)
pn smbldap-tools <none> (no description available)
-- debconf information excluded
--- End Message ---
--- Begin Message ---
Source: samba
Source-Version: 2:3.3.3-1
We believe that the bug you reported is fixed in the latest version of
samba, which is due to be installed in the Debian FTP archive:
libpam-smbpass_3.3.3-1_i386.deb
to pool/main/s/samba/libpam-smbpass_3.3.3-1_i386.deb
libsmbclient-dev_3.3.3-1_i386.deb
to pool/main/s/samba/libsmbclient-dev_3.3.3-1_i386.deb
libsmbclient_3.3.3-1_i386.deb
to pool/main/s/samba/libsmbclient_3.3.3-1_i386.deb
libwbclient0_3.3.3-1_i386.deb
to pool/main/s/samba/libwbclient0_3.3.3-1_i386.deb
samba-common_3.3.3-1_i386.deb
to pool/main/s/samba/samba-common_3.3.3-1_i386.deb
samba-dbg_3.3.3-1_i386.deb
to pool/main/s/samba/samba-dbg_3.3.3-1_i386.deb
samba-doc-pdf_3.3.3-1_all.deb
to pool/main/s/samba/samba-doc-pdf_3.3.3-1_all.deb
samba-doc_3.3.3-1_all.deb
to pool/main/s/samba/samba-doc_3.3.3-1_all.deb
samba-tools_3.3.3-1_i386.deb
to pool/main/s/samba/samba-tools_3.3.3-1_i386.deb
samba_3.3.3-1.diff.gz
to pool/main/s/samba/samba_3.3.3-1.diff.gz
samba_3.3.3-1.dsc
to pool/main/s/samba/samba_3.3.3-1.dsc
samba_3.3.3-1_i386.deb
to pool/main/s/samba/samba_3.3.3-1_i386.deb
samba_3.3.3.orig.tar.gz
to pool/main/s/samba/samba_3.3.3.orig.tar.gz
smbclient_3.3.3-1_i386.deb
to pool/main/s/samba/smbclient_3.3.3-1_i386.deb
smbfs_3.3.3-1_i386.deb
to pool/main/s/samba/smbfs_3.3.3-1_i386.deb
swat_3.3.3-1_i386.deb
to pool/main/s/samba/swat_3.3.3-1_i386.deb
winbind_3.3.3-1_i386.deb
to pool/main/s/samba/winbind_3.3.3-1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christian Perrier <[email protected]> (supplier of updated samba package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 11 Apr 2009 10:12:23 +0200
Source: samba
Binary: samba samba-common samba-tools smbclient swat samba-doc samba-doc-pdf
smbfs libpam-smbpass libsmbclient libsmbclient-dev winbind samba-dbg
libwbclient0
Architecture: source all i386
Version: 2:3.3.3-1
Distribution: unstable
Urgency: low
Maintainer: Debian Samba Maintainers <[email protected]>
Changed-By: Christian Perrier <[email protected]>
Description:
libpam-smbpass - pluggable authentication module for Samba
libsmbclient - shared library for communication with SMB/CIFS servers
libsmbclient-dev - development files for libsmbclient
libwbclient0 - Samba winbind client library
samba - SMB/CIFS file, print, and login server for Unix
samba-common - common files used by both the Samba server and client
samba-dbg - Samba debugging symbols
samba-doc - Samba documentation
samba-doc-pdf - Samba documentation in PDF format
samba-tools - Samba testing utilities
smbclient - command-line SMB/CIFS clients for Unix
smbfs - Samba file system utilities
swat - Samba Web Administration Tool
winbind - Samba nameservice integration server
Closes: 517021 521225 521408
Changes:
samba (2:3.3.3-1) unstable; urgency=low
.
* New upstream release:
- Fix map readonly. Closes: #521225
- Add missing whitespace in mount.cifs error message. Closes: #517021
- Includes our patch to fix detection of GNU ld version. As a
consequence, we dropped fix_wrong_gnu_ld_version_check.patch
- Fix segfault in lookup_sid. Closes: #521408
Checksums-Sha1:
0abaa4dd186be76871b7caaab6a362efe5920407 2056 samba_3.3.3-1.dsc
0ef3fc63dbb6d9723110a97bec24d14ca4cc49a1 26070757 samba_3.3.3.orig.tar.gz
04f95581ae70522abe0ef7509adab645d1e031d7 229851 samba_3.3.3-1.diff.gz
89ab1f9d89760417fd0c3cb3d3839c9736ae308e 7982668 samba-doc_3.3.3-1_all.deb
87aec81e26d8314ab45352ced546834825264217 6697522 samba-doc-pdf_3.3.3-1_all.deb
4f81c125c6bc01524ba7f6af5e46c2cf7a93261b 4560792 samba_3.3.3-1_i386.deb
ac4d94cf2dde1dad48e911e4ee7ec701922a9949 4036654 samba-common_3.3.3-1_i386.deb
7e7e0c9b8e47a9159824f27ba96af51b6d168bef 5147942 samba-tools_3.3.3-1_i386.deb
1ce1380e04a51974e02459f068d337cc1bac2f16 8102540 smbclient_3.3.3-1_i386.deb
296004d932a0e43a12a900eaee26f8b4194f9a6c 1391538 swat_3.3.3-1_i386.deb
b0e6295e26bc3a08c49e7c31fc5d683f67c658fa 1506222 smbfs_3.3.3-1_i386.deb
51cbb55c5139c29ecc2b640b70cd3a1d4b62c3b5 581756 libpam-smbpass_3.3.3-1_i386.deb
51a8700b04ec9a2ac413f8bfc339dace50e04bca 1339082 libsmbclient_3.3.3-1_i386.deb
05c836a137014dc3d4c56aba49d57923d2412c78 2030124
libsmbclient-dev_3.3.3-1_i386.deb
86e3c4167ff5350a0f8a9c26a225e23bd3a026e7 3498848 winbind_3.3.3-1_i386.deb
254b7729ad7de1540372af16df483b98ec888e20 34630528 samba-dbg_3.3.3-1_i386.deb
d0ffc137540db8c05fbe0ec57ee52a1951cba99c 84466 libwbclient0_3.3.3-1_i386.deb
Checksums-Sha256:
e22ac3f8e113a85dbcbf6b59f4ab0111a3ea83e6332b83256a3790157f1dcac8 2056
samba_3.3.3-1.dsc
16179b74296b9567613ef966b56da58d971285195db6b34b5281154dcfb3a323 26070757
samba_3.3.3.orig.tar.gz
0dddfc353a9525ab68f7cb54982059a76526b9633a731d0f7c173afa29580d34 229851
samba_3.3.3-1.diff.gz
c3ac8c5fc727ba417e70975432d320c01157f8be8f96ae1ebd3ffd498ef5593d 7982668
samba-doc_3.3.3-1_all.deb
fed4b3f6148280f44f5f0235ca5cc359962a215ce4d7090f964336ef393114f3 6697522
samba-doc-pdf_3.3.3-1_all.deb
43614413284aa6b5c8a5dad959df1aedbbd8a1547e44df63717b251bad35f69b 4560792
samba_3.3.3-1_i386.deb
99aea9cb7787590cdb098c92d2375cabe4f39363383f22092d321911d77b8ae5 4036654
samba-common_3.3.3-1_i386.deb
a17e332b15dcd78a6c61aa1f81d6dd67b6e777edfce31b2083e6988be00d33af 5147942
samba-tools_3.3.3-1_i386.deb
7cd79bb6d77d5c45c252d0c62dd3bb82bb7f8981d8cefb8400100824862c7f4e 8102540
smbclient_3.3.3-1_i386.deb
3dd8c5b5a0ce8431a0287e3166069bfdac7a12cfee280408f14e95dface771c6 1391538
swat_3.3.3-1_i386.deb
a3404b1c2a09f8ce4643f4ec5a9c785aa397aaab636f2939045893fd5ea29924 1506222
smbfs_3.3.3-1_i386.deb
fe99e18e17e79afcd629a3d9eb35275df4c7c758004b1e85dd5f207079dbba62 581756
libpam-smbpass_3.3.3-1_i386.deb
32fa83bc7867460cd2b8d3613376de82919b270b79bf746497d0f2c376584dab 1339082
libsmbclient_3.3.3-1_i386.deb
c06f684cb2ae573fc9b4b666558d2b0787794cd98e2f37e846e6d8ac201c631f 2030124
libsmbclient-dev_3.3.3-1_i386.deb
87ee2d2bf71e0c649ab9038db9cf8de22fb5e298e005fa2c17aff6416fd3d009 3498848
winbind_3.3.3-1_i386.deb
c6fa37e0cd0c36b328b59f84afea758c904319542d3d95a382e96e58647a27ee 34630528
samba-dbg_3.3.3-1_i386.deb
6bd0c8385f71ad1a8b42c4e44bc34efce0377d69bed0fa63178269ef9a7e9009 84466
libwbclient0_3.3.3-1_i386.deb
Files:
9bd2808fa86fc71384f67958eba1cd95 2056 net optional samba_3.3.3-1.dsc
4d5835817416d1ffa30783af45c5a9ed 26070757 net optional samba_3.3.3.orig.tar.gz
64d045c2e92b4b2b85d75c27ed064e4a 229851 net optional samba_3.3.3-1.diff.gz
5b97aa2231793ab5d9c904356582b0db 7982668 doc optional samba-doc_3.3.3-1_all.deb
5535163cd156e1fb022cf1a3f08ecdf7 6697522 doc optional
samba-doc-pdf_3.3.3-1_all.deb
0a094fe39a73f06cb3430e9f04001d33 4560792 net optional samba_3.3.3-1_i386.deb
5fa51877af553e6c7e1856716f7772ff 4036654 net optional
samba-common_3.3.3-1_i386.deb
9097d8108bb90004c851e1f9d8fac12e 5147942 net optional
samba-tools_3.3.3-1_i386.deb
6d574f347a955ccf1c12a2dc1ba7257b 8102540 net optional
smbclient_3.3.3-1_i386.deb
5fe196bd4fe79679bff8710cba0c97b0 1391538 net optional swat_3.3.3-1_i386.deb
00094f4dca8d7abee28d8d9e3b7ba357 1506222 otherosfs optional
smbfs_3.3.3-1_i386.deb
b4aef17af9b1547585ca12cf79376d36 581756 admin extra
libpam-smbpass_3.3.3-1_i386.deb
b94d3e4f36d696a2d36b03273eeac248 1339082 libs optional
libsmbclient_3.3.3-1_i386.deb
74fd806a679772ff7c5b4f0bb22188d5 2030124 libdevel extra
libsmbclient-dev_3.3.3-1_i386.deb
96a9ae727b7a373c91ab23d1b5136f31 3498848 net optional winbind_3.3.3-1_i386.deb
121de13ed8a91c150af794ba841e5a48 34630528 debug extra
samba-dbg_3.3.3-1_i386.deb
5c60320517a40acc69a036f55c92edc8 84466 libs optional
libwbclient0_3.3.3-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEUEARECAAYFAkngYV4ACgkQ1OXtrMAUPS1FSACeK/DY9vAfotsHKQ2HZMpRQmvi
22sAmOkOeOsBEsIavlnXFHObWpw7K7I=
=jcYG
-----END PGP SIGNATURE-----
--- End Message ---