Your message dated Fri, 24 Apr 2009 21:32:04 +0000
with message-id <[email protected]>
and subject line Bug#513696: fixed in 9menu 1.8-2
has caused the Debian Bug report #513696,
regarding 9menu: please add support for more keys
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
513696: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513696
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: 9menu
Version: 1.8-1.2
Severity: wishlist
Tags: patch
Please add support for more keys to navigate, especially for KP_Enter
to trigger an item instead of only Return. (I've got an report that
in some settings X seems to only generate KP_Enter instead of Return,
if that turns out to be a more widespread problem, that might increase
the severity of this bug quite a bit in my eyes).
Attached patch adds support for
keypad up/down/enter, for
vi-like j/k and
emacs-like C-p/C-n.
And support for escape key to exit the menu.
Hochachtungsvoll,
Bernhard R. Link
#!/bin/sh -e
## 05_morekeys.dpatch by Benhard R. Link <[email protected]>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Add more keys, especially Keypad Enter
if [ $# -ne 1 ]; then
echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
exit 1
fi
[ -f debian/patches/00patch-opts ] && . debian/patches/00patch-opts
patch_opts="${patch_opts:--f --no-backup-if-mismatch}"
case "$1" in
-patch) patch $patch_opts -p1 < $0;;
-unpatch) patch $patch_opts -p1 -R < $0;;
*)
echo >&2 "`basename $0`: script expects -patch|-unpatch as
argument"
exit 1;;
esac
exit 0
@DPATCH@
diff -urNad 9menu-1.8~/9menu.c 9menu-1.8/9menu.c
--- 9menu-1.8~/9menu.c 2009-01-31 14:13:35.000000000 +0100
+++ 9menu-1.8/9menu.c 2009-01-31 14:14:24.000000000 +0100
@@ -124,6 +124,14 @@
#define CONFIG_MENU_UP_KEY XK_Up
#define CONFIG_MENU_DOWN_KEY XK_Down
#define CONFIG_MENU_SELECT_KEY XK_Return
+#define CONFIG_MENU_VI_UP_KEY XK_k
+#define CONFIG_MENU_VI_DOWN_KEY XK_j
+#define CONFIG_MENU_EMACS_UP_KEY XK_p
+#define CONFIG_MENU_EMACS_DOWN_KEY XK_n
+#define CONFIG_MENU_ALTERNATE_UP_KEY XK_KP_Up
+#define CONFIG_MENU_ALTERNATE_DOWN_KEY XK_KP_Down
+#define CONFIG_MENU_ALTERNATE_SELECT_KEY XK_KP_Enter
+#define CONFIG_MENU_ABORT_KEY XK_Escape
char *progname; /* my name */
char *displayname; /* X display */
@@ -573,13 +581,21 @@
key = XKeycodeToKeysym(dpy, ev.xkey.keycode, 0);
if (key != CONFIG_MENU_UP_KEY
&& key != CONFIG_MENU_DOWN_KEY
- && key != CONFIG_MENU_SELECT_KEY)
+ && key != CONFIG_MENU_SELECT_KEY
+ && key != CONFIG_MENU_ALTERNATE_DOWN_KEY
+ && key != CONFIG_MENU_ALTERNATE_UP_KEY
+ && key != CONFIG_MENU_ALTERNATE_SELECT_KEY
+ && key != CONFIG_MENU_EMACS_DOWN_KEY
+ && key != CONFIG_MENU_EMACS_UP_KEY
+ && key != CONFIG_MENU_VI_DOWN_KEY
+ && key != CONFIG_MENU_VI_UP_KEY
+ && key != CONFIG_MENU_ABORT_KEY)
break;
- if (key == CONFIG_MENU_UP_KEY) {
+ if (key == CONFIG_MENU_UP_KEY || key ==
CONFIG_MENU_EMACS_UP_KEY || key == CONFIG_MENU_VI_UP_KEY || key ==
CONFIG_MENU_ALTERNATE_UP_KEY) {
old = cur;
cur--;
- } else if (key == CONFIG_MENU_DOWN_KEY) {
+ } else if (key == CONFIG_MENU_DOWN_KEY || key ==
CONFIG_MENU_EMACS_DOWN_KEY || key == CONFIG_MENU_VI_DOWN_KEY || key ==
CONFIG_MENU_ALTERNATE_DOWN_KEY) {
old = cur;
cur++;
}
@@ -589,7 +605,10 @@
cur %= numitems;
- if (key == CONFIG_MENU_UP_KEY || key ==
CONFIG_MENU_DOWN_KEY) {
+ if (key == CONFIG_MENU_UP_KEY || key ==
CONFIG_MENU_DOWN_KEY
+ || key == CONFIG_MENU_EMACS_UP_KEY || key ==
CONFIG_MENU_EMACS_DOWN_KEY
+ || key == CONFIG_MENU_VI_UP_KEY || key ==
CONFIG_MENU_VI_DOWN_KEY
+ || key == CONFIG_MENU_ALTERNATE_UP_KEY || key ==
CONFIG_MENU_ALTERNATE_DOWN_KEY) {
if (cur == old)
break;
if (old >= 0 && old < numitems && cur != -1)
@@ -601,7 +620,13 @@
if (warp)
restoremouse();
- if (key == CONFIG_MENU_SELECT_KEY) {
+ if (key == CONFIG_MENU_ABORT_KEY) {
+ if (commands[cur] != labels[cur]) {
+ spawn(commands[cur]);
+ }
+ return;
+ }
+ if (key == CONFIG_MENU_SELECT_KEY || key ==
CONFIG_MENU_ALTERNATE_SELECT_KEY) {
if (strcmp(labels[cur], "exit") == 0) {
if (commands[cur] != labels[cur]) {
spawn(commands[cur]);
--- End Message ---
--- Begin Message ---
Source: 9menu
Source-Version: 1.8-2
We believe that the bug you reported is fixed in the latest version of
9menu, which is due to be installed in the Debian FTP archive:
9menu_1.8-2.diff.gz
to pool/main/9/9menu/9menu_1.8-2.diff.gz
9menu_1.8-2.dsc
to pool/main/9/9menu/9menu_1.8-2.dsc
9menu_1.8-2_i386.deb
to pool/main/9/9menu/9menu_1.8-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Barry deFreese <[email protected]> (supplier of updated 9menu package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 24 Apr 2009 17:00:40 -0400
Source: 9menu
Binary: 9menu
Architecture: source i386
Version: 1.8-2
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <[email protected]>
Changed-By: Barry deFreese <[email protected]>
Description:
9menu - Creates X menus from the shell
Closes: 513696 515354
Changes:
9menu (1.8-2) unstable; urgency=low
.
* QA upload.
+ Set maintainer to Debian QA Group <[email protected]>
* Acknowledge NMUs.
* Replace x-dev build-dep with x11proto-core-dev. (Closes: #515354).
* Replace xutils build-dep with xutils-dev.
* 05_morekeys.dpatch - Support more keys. (Closes: #513696).
+ Thanks to Bernhard R. Link for the patch.
* Make clean not ignore errors.
* Bump debhelper build-dep and compat to 5.
* Bump Standards Version to 3.8.1.
Checksums-Sha1:
83282d4601d8104ca3d6e85ad4f30400352c0069 980 9menu_1.8-2.dsc
be4f774260d373458a7d8f5590192d29440a54a1 5273 9menu_1.8-2.diff.gz
f67e7c6e754108639384f8f0eb17f0669c13482f 14514 9menu_1.8-2_i386.deb
Checksums-Sha256:
97db8d15519eabf6bc516c30eeaebe3dff11d59e8defc00d5c3062c5159e2684 980
9menu_1.8-2.dsc
d9196fda29a2327e1faaeb787630b9600328b90a491b4422cb5ea9e043cebf1d 5273
9menu_1.8-2.diff.gz
674152f670b51cdb898d36fe41d2060ed1003e78f5f04f9d8a3c49584003c0e2 14514
9menu_1.8-2_i386.deb
Files:
97c6ca7a2baf8d481cf0634ff2aaffa4 980 x11 optional 9menu_1.8-2.dsc
33957b3154151203101bebdaa2781a0c 5273 x11 optional 9menu_1.8-2.diff.gz
813aebf6515a668ed2c8f69f25017e82 14514 x11 optional 9menu_1.8-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAknyLFAACgkQ5ItltUs5T37WqgCgzkolb2f3e9eGdKpwdBLRTOtF
7lYAn077SO4bnwyvM/i/XHpSgmrDbQ8x
=ZD7o
-----END PGP SIGNATURE-----
--- End Message ---
