Your message dated Tue, 05 May 2009 09:32:17 +0000
with message-id <[email protected]>
and subject line Bug#526395: fixed in virtualbox-ose 2.2.2-dfsg-2
has caused the Debian Bug report #526395,
regarding Save ~10s in virtualbox-ose init script
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
526395: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526395
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: virtualbox-ose
Version: 2.1.4-dfsg-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jaunty ubuntu-patch
The attached patch contains an improvement to the init script, which removes
the usage of "find", which can take up to 10 seconds (or probably more).
Please forgive me that I have not actually tested this, but committed it for
Ubuntu Karmic already.
The initial bug has been reported against Ubuntu at, and includes more info
(about the benchmarking):
https://launchpad.net/bugs/369550
diff -u virtualbox-ose-2.1.4-dfsg/debian/changelog virtualbox-ose-2.1.4-dfsg/debian/changelog
diff -u virtualbox-ose-2.1.4-dfsg/debian/patches/09-initscript.dpatch virtualbox-ose-2.1.4-dfsg/debian/patches/09-initscript.dpatch
--- virtualbox-ose-2.1.4-dfsg/debian/patches/09-initscript.dpatch
+++ virtualbox-ose-2.1.4-dfsg/debian/patches/09-initscript.dpatch
@@ -4,20 +4,19 @@
## DP: Some changes to initscript.
@DPATCH@
-
-diff -Naurp virtualbox-ose-2.1.2-dfsg.orig/src/VBox/Installer/linux/vboxdrv.sh.in virtualbox-ose-2.1.2-dfsg/src/VBox/Installer/linux/vboxdrv.sh.in
---- virtualbox-ose-2.1.2-dfsg.orig/src/VBox/Installer/linux/vboxdrv.sh.in 2009-02-20 13:37:57.000000000 +0100
-+++ virtualbox-ose-2.1.2-dfsg/src/VBox/Installer/linux/vboxdrv.sh.in 2009-02-20 13:36:50.000000000 +0100
+diff -urNad virtualbox-ose-2.1.4-dfsg~/src/VBox/Installer/linux/vboxdrv.sh.in virtualbox-ose-2.1.4-dfsg/src/VBox/Installer/linux/vboxdrv.sh.in
+--- virtualbox-ose-2.1.4-dfsg~/src/VBox/Installer/linux/vboxdrv.sh.in 2009-04-30 23:11:50.143791302 +0200
++++ virtualbox-ose-2.1.4-dfsg/src/VBox/Installer/linux/vboxdrv.sh.in 2009-04-30 23:11:51.443789125 +0200
@@ -32,6 +32,8 @@
LOG="/var/log/vbox-install.log"
- NOLSB=yes
+ NOLSB=%NOLSB%
+# Include virtualbox-ose defaults if available
+[ -f /etc/default/virtualbox-ose ] && . /etc/default/virtualbox-ose
[ -f /lib/lsb/init-functions ] && NOLSB=
[ -f /etc/vbox/vbox.cfg ] && . /etc/vbox/vbox.cfg
-@@ -147,14 +149,19 @@
+@@ -147,15 +149,18 @@
{
begin_msg "Starting VirtualBox kernel module"
if ! running vboxdrv; then
@@ -30,22 +29,21 @@
- if ! modprobe vboxdrv > /dev/null 2>&1; then
- failure "modprobe vboxdrv failed. Please use 'dmesg' to find out why"
+ if [ "$LOAD_VBOXDRV_MODULE" = 1 ]; then
-+ if ! find /lib/modules/`uname -r` -name "vboxdrv\.*" 2>/dev/null|grep -q vboxdrv; then
-+ failure "No suitable module for running kernel found"
-+ fi
+ if ! rm -f $DEVICE; then
+ failure "Cannot remove $DEVICE"
+ fi
-+ if ! modprobe vboxdrv > /dev/null 2>&1; then
-+ failure "modprobe vboxdrv failed. Please use 'dmesg' to find out why"
++ if ! modprobe -n -q vboxdrv; then
++ failure "modprobe vboxdrv failed. Please use 'dmesg' to find out why."
+ fi
+ else
+ succ_msg
+ return
fi
++ # Why is sleep used here (in case of error)?
sleep .2
fi
-@@ -184,8 +191,10 @@
+ # ensure the character special exists
+@@ -184,8 +189,10 @@
rmmod vboxdrv 2>/dev/null
failure "Cannot change owner $GROUPNAME for device $DEVICE"
fi
--- End Message ---
--- Begin Message ---
Source: virtualbox-ose
Source-Version: 2.2.2-dfsg-2
We believe that the bug you reported is fixed in the latest version of
virtualbox-ose, which is due to be installed in the Debian FTP archive:
virtualbox-ose-dbg_2.2.2-dfsg-2_amd64.deb
to pool/main/v/virtualbox-ose/virtualbox-ose-dbg_2.2.2-dfsg-2_amd64.deb
virtualbox-ose-guest-source_2.2.2-dfsg-2_all.deb
to pool/main/v/virtualbox-ose/virtualbox-ose-guest-source_2.2.2-dfsg-2_all.deb
virtualbox-ose-guest-utils_2.2.2-dfsg-2_amd64.deb
to
pool/main/v/virtualbox-ose/virtualbox-ose-guest-utils_2.2.2-dfsg-2_amd64.deb
virtualbox-ose-guest-x11_2.2.2-dfsg-2_amd64.deb
to pool/main/v/virtualbox-ose/virtualbox-ose-guest-x11_2.2.2-dfsg-2_amd64.deb
virtualbox-ose-qt_2.2.2-dfsg-2_amd64.deb
to pool/main/v/virtualbox-ose/virtualbox-ose-qt_2.2.2-dfsg-2_amd64.deb
virtualbox-ose-source_2.2.2-dfsg-2_all.deb
to pool/main/v/virtualbox-ose/virtualbox-ose-source_2.2.2-dfsg-2_all.deb
virtualbox-ose_2.2.2-dfsg-2.diff.gz
to pool/main/v/virtualbox-ose/virtualbox-ose_2.2.2-dfsg-2.diff.gz
virtualbox-ose_2.2.2-dfsg-2.dsc
to pool/main/v/virtualbox-ose/virtualbox-ose_2.2.2-dfsg-2.dsc
virtualbox-ose_2.2.2-dfsg-2_amd64.deb
to pool/main/v/virtualbox-ose/virtualbox-ose_2.2.2-dfsg-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Meskes <[email protected]> (supplier of updated virtualbox-ose package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 05 May 2009 09:29:24 +0200
Source: virtualbox-ose
Binary: virtualbox-ose-qt virtualbox-ose virtualbox-ose-dbg
virtualbox-ose-source virtualbox-ose-guest-source virtualbox-ose-guest-x11
virtualbox-ose-guest-utils
Architecture: source amd64 all
Version: 2.2.2-dfsg-2
Distribution: unstable
Urgency: low
Maintainer: Debian Virtualbox Team
<[email protected]>
Changed-By: Michael Meskes <[email protected]>
Description:
virtualbox-ose - x86 virtualization solution - base binaries
virtualbox-ose-dbg - x86 virtualization solution - debugging symbols
virtualbox-ose-guest-source - x86 virtualization solution - guest addition
module source
virtualbox-ose-guest-utils - x86 virtualization solution - non-X11 guest
utilities
virtualbox-ose-guest-x11 - x86 virtualization solution - X11 guest utilities
virtualbox-ose-qt - x86 virtualization solution - Qt based user interface
virtualbox-ose-source - x86 virtualization solution - kernel module source
Closes: 526322 526395 526820
Changes:
virtualbox-ose (2.2.2-dfsg-2) unstable; urgency=low
.
* Made initscript call find only in case of an error, closes: #526395
* Removed setup option from initscript, closes: #526322
* Added upstream patch to fix bug in VBoxManage modifyhd, closes: #526820
* Merged our init script patches into one patch.
* Made initscript more verbose.
Checksums-Sha1:
ef8413900fc0d62a6e6fdd36b03d2ba21678e3c7 2243 virtualbox-ose_2.2.2-dfsg-2.dsc
42b04b3d46155525c7e765fdaba607c13f99fa27 64004
virtualbox-ose_2.2.2-dfsg-2.diff.gz
711c91f6a83d37c0d0c6075533028f1521707071 4308488
virtualbox-ose-qt_2.2.2-dfsg-2_amd64.deb
4424a159cabac9ebe93a010affe9b5bfbb97f250 5904348
virtualbox-ose_2.2.2-dfsg-2_amd64.deb
aeea5efc9ced9d27ada68e003c29599630220417 41666426
virtualbox-ose-dbg_2.2.2-dfsg-2_amd64.deb
ffdb2df7c9028e1347e9e24105e4c8085a65ff68 503442
virtualbox-ose-guest-x11_2.2.2-dfsg-2_amd64.deb
07c13351e2a59e248a299ffb56b559a853ddffe7 37858
virtualbox-ose-guest-utils_2.2.2-dfsg-2_amd64.deb
6983fa924300b72bc275fe1a2aa7307839b7aa7a 336472
virtualbox-ose-source_2.2.2-dfsg-2_all.deb
d5e038fe8e1a470a4a21f9cd6df5d6767e1d521b 278482
virtualbox-ose-guest-source_2.2.2-dfsg-2_all.deb
Checksums-Sha256:
30ddc929bce690b766bbf0db8b36e119f033c4a24551aa79e514a7cb1f856739 2243
virtualbox-ose_2.2.2-dfsg-2.dsc
8f680789a5299b43959ef35a0e7febdc079428010ce7222f036fc36c9ba3ed90 64004
virtualbox-ose_2.2.2-dfsg-2.diff.gz
c1e6f48891e7fd4604ccd9a1eabf5b1e7db1e2a7e78b432b94acc5860313da06 4308488
virtualbox-ose-qt_2.2.2-dfsg-2_amd64.deb
302ccded1b2430c3ac9bd2c5587076620c310fb0a17333aef94f02ffe357a76a 5904348
virtualbox-ose_2.2.2-dfsg-2_amd64.deb
5a19800416328e8ec24fdd8fb997295c2caaf65b1618eec14fefcf00cc2da144 41666426
virtualbox-ose-dbg_2.2.2-dfsg-2_amd64.deb
5e266b638047856d2d75d49c21d5cae6acaa9df55131e21d1c0b020e7bb02731 503442
virtualbox-ose-guest-x11_2.2.2-dfsg-2_amd64.deb
225fe84fc9e24f8fdb49751c31e7d3da1895c42f0b10fe3b563a9beeac6b5770 37858
virtualbox-ose-guest-utils_2.2.2-dfsg-2_amd64.deb
aab2293d64a308a7b9e34cee9c8ccb62d19d59f375d123fdda484b55e40347ef 336472
virtualbox-ose-source_2.2.2-dfsg-2_all.deb
97317c1cc110afbfe57f3ecdb182cfc93b12847ac470dd0a952b48d004174d0e 278482
virtualbox-ose-guest-source_2.2.2-dfsg-2_all.deb
Files:
10dd13d581334516376cb6d9edf8019b 2243 misc extra
virtualbox-ose_2.2.2-dfsg-2.dsc
9e0039be73c384a6b2637f3baf1a52a1 64004 misc extra
virtualbox-ose_2.2.2-dfsg-2.diff.gz
3a3941b00997649412eb124a60aa7b93 4308488 misc extra
virtualbox-ose-qt_2.2.2-dfsg-2_amd64.deb
2150482c18bcbf013d940603d1e09776 5904348 misc extra
virtualbox-ose_2.2.2-dfsg-2_amd64.deb
be210662926c364846afbe6889ae5704 41666426 debug extra
virtualbox-ose-dbg_2.2.2-dfsg-2_amd64.deb
6b4bcab34cbcffeaaf09201097736f17 503442 misc extra
virtualbox-ose-guest-x11_2.2.2-dfsg-2_amd64.deb
fbcdd5a783dea52c76ef1da2f4b0d3be 37858 misc extra
virtualbox-ose-guest-utils_2.2.2-dfsg-2_amd64.deb
c76dad44c472f463e4fc7852788e434c 336472 kernel extra
virtualbox-ose-source_2.2.2-dfsg-2_all.deb
3855ea993e1758c3c9c4f5f08dfe1458 278482 kernel extra
virtualbox-ose-guest-source_2.2.2-dfsg-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFJ//1YVkEm8inxm9ERAkftAJ95++zRNk1WseN0FQs7HXe4cryUbgCfWIgh
0JFArSP7MULs13wV96In4Sk=
=3rej
-----END PGP SIGNATURE-----
--- End Message ---
