Your message dated Sat, 16 May 2009 22:04:47 +0100
with message-id <[email protected]>
and subject line hermes1 has been removed from Debian, closing #268358
has caused the Debian Bug report #268358,
regarding Hermes Incorretc convert 24 to 24 bit
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
268358: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=268358
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: hermes1
version: 1.3.3
Severity: important
(hermses1 1.3.3+really1.3.2-2)
When I Start WindowMaker with 24bpp I am recv sigsegv.
Sarge distributive.
I think that you use hermes other than version 1.3.3.
Debian version Hermes contain error in function ConvertC_Generic24_Generic24
see below.
----------------Attention see context in end of letter--------------------------
} while (iface->s_height--); // this string has error. must be } while
(--iface->s_height);
--------------------------------------------------------------------
---------------------------------------
In Hermes version 1.3.3 file c_genrc.c contain:
----------------------------------------
#define CG_S_STANDARD(src_read_macro, dest_write_macro, src_byte_inc,
dest_byte_inc, convert_rgb_macro, dest_read_macro) \
do { \
count=iface->d_width; \
x = 0; \
do { \
s_pixel = src_read_macro(source + (x>>16)); \
dest_write_macro(dest, (convert_rgb_macro(s_pixel))); \
x+=dx; \
dest+=dest_byte_inc; \
} while(--count); \
dest+=iface->d_add; \
y+=dy; \
source+=(y>>16)*iface->s_pitch; \
y &= 0xffff; \
} while (--iface->d_height);
void ConvertC_Generic24_Generic24(HermesConverterInterface *iface)
{
CG_IDENTICAL( READ24, WRITE24, 3, 0 )
}
-------------------------------------------
In Debian Package file c_genrc.c contain:
-------------------------------------------
void ConvertC_Generic24_Generic24(HermesConverterInterface *iface)
{ int32 s_pixel,r,g,b;
char8 *d_ptr=(char8 *)&s_pixel;
unsigned int count;
char8 *source=iface->s_pixels,*dest=iface->d_pixels;
do {
count=iface->s_width;
do
{
s_pixel=(((int32)*(source+R_24))<<16)|
(((int32)*(source+G_24))<<8)|
((int32)*(source+B_24));
r=((s_pixel<<iface->info.r_left)>>iface->info.r_right)&
iface->mask_r;
g=((s_pixel<<iface->info.g_left)>>iface->info.g_right)&
iface->mask_g;
b=((s_pixel<<iface->info.b_left)>>iface->info.b_right)&
iface->mask_b;
s_pixel=(r|g|b);
*(dest+R_24)=*(d_ptr+R_32);
*(dest+G_24)=*(d_ptr+G_32);
*(dest+B_24)=*(d_ptr+B_32);
source+=3;
dest+=3;
} while (--count);
source+=iface->s_add;
dest+=iface->d_add;
} while (iface->s_height--); // this string has error. must be } while
(--iface->s_height);
}
--- End Message ---
--- Begin Message ---
Version: 1.3.3+really1.3.2-5.1+rm
The hermes1 package has been removed from Debian so we are closing
the bugs that were still opened against it.
For more information about this package's removal, read
http://bugs.debian.org/528826 . That bug might give the reasons why
this package was removed, and suggestions of possible replacements.
Don't hesitate to reply to this mail if you have any question.
Thank you for your contribution to Debian.
Kind regards,
--
Marco Rodrigues
--- End Message ---
