Your message dated Mon, 25 May 2009 20:33:55 +0200
with message-id <20090525183355.ga14...@yellowpig>
and subject line Re: Bug#451222: libjpeg: mass bug filing for cross build
support
has caused the Debian Bug report #451222,
regarding libjpeg: mass bug filing for cross build support
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
451222: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=451222
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libjpeg6b
Version: 6b-14
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: crossbuilt
--- Please enter the report below this line. ---
As part of the long term mass bug filing for cross building support,
(http://lists.debian.org/debian-devel/2007/11/msg00116.html), I've
prepared this patch for debian/rules.
The cross building support in Debian has been recently rewritten -
particularly in respect of how environment variables and overrides are
handled - so this patch is now needed to allow libjpeg6b to correctly
identify the cross compiler.
The patch also wraps 'make check' in a test for the 'nocheck'
DEB_BUILD_OPTION and prevents the replacement of the original 'libtool'
script when cross-compiling (the wrapper created by the package fails
to pass the correct tags to the cross compiler; using the original
script allows the cross build environment to handle the libtool call).
Note that libjpeg6b needs to be told about the cross-compiler in
--build and --host as well as in the $(CC) variable to configure, it
also requires $(CC) to be set to the cross compiler for each of the
$(MAKE) commands. I suspect this is related to #346126.
I can split these out into other bugs if you prefer but all changes
affect the same file and achieve the same purpose: supporting cross
building.
Please consider implementing this patch. Thanks.
--- libjpeg6b-6b/debian/rules
+++ libjpeg6b.new/debian/rules
@@ -6,6 +6,13 @@
export DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
+
+ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
+CROSS=CC=$(DEB_HOST_GNU_TYPE)-gcc
+confflags= --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE) $(CROSS)
+else
+confflags= --build $(DEB_BUILD_GNU_TYPE)
+endif
include debian/patch.mk
@@ -16,6 +23,12 @@
CFLAGS += -O2
endif
+ifneq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
+CHECK=
+else
+CHECK=$(MAKE) test
+endif
+
#export DH_VERBOSE=1
build: build-stamp
@@ -23,11 +36,13 @@
dh_testdir
./configure --prefix=/usr --mandir=usr/share/man \
--enable-static --enable-shared --enable-maxmem=1024 \
- --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE)
+ $(confflags)
+ifeq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
printf '#!/bin/sh\nexec libtool "$$@"\n' >libtool
- $(MAKE)
- $(MAKE) test
- $(MAKE) -C debian/extra
+endif
+ $(MAKE) $(CROSS)
+ $(CHECK)
+ $(MAKE) -C debian/extra $(CROSS)
touch build-stamp
--- System information. ---
Architecture: amd64
Kernel: Linux 2.6.22-2-amd64
Debian Release: lenny/sid
500 unstable www.linux.codehelp.co.uk
500 unstable www.emdebian.org
500 unstable ftp.uk.debian.org
--- Package information. ---
Depends (Version) | Installed
=======================-+-===========
|
--
Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/
pgpdSJQokdY97.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
On Wed, Nov 14, 2007 at 09:02:02AM +0000, Neil Williams wrote:
> Package: libjpeg6b
> Version: 6b-14
> Severity: wishlist
> Tags: patch
> User: [email protected]
> Usertags: crossbuilt
>
> --- Please enter the report below this line. ---
>
> As part of the long term mass bug filing for cross building support,
> (http://lists.debian.org/debian-devel/2007/11/msg00116.html), I've
> prepared this patch for debian/rules.
As I said before your patch is wrong and I am not inclined to argue
the point anymore, so I am closing this bug. There is no need to
NMU libjpeg to include this broken patch.
I apologize not to have done that sooner.
Cheers,
--
Bill. <[email protected]>
Imagine a large red swirl here.
signature.asc
Description: Digital signature
--- End Message ---
