Your message dated Fri, 05 Jun 2009 23:17:40 +0000
with message-id <[email protected]>
and subject line Bug#520925: fixed in wicd 1.6.0-1
has caused the Debian Bug report #520925,
regarding wicd: uses killall without depending on psmisc
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
520925: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=520925
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: wicd
Version: 1.5.9-5
Severity: important
User: [email protected]
Usertags: package-installation
Hello,
the subject says all, here the relevant part of the code:
=====
l...@gismo:~$ grep -r killall wicd-1.5.9/*
wicd-1.5.9/wicd/wicd-daemon.py: misc.Run("killall dhclient dhclient3
wpa_supplicant")
wicd-1.5.9/wicd/wnettools.py: cmd = 'killall dhclient dhclient3 pump
dhcpcd-bin'
wicd-1.5.9/wicd/wnettools.py: cmd = 'killall wpa_supplicant'
l...@gismo:~$
=====
However, I consider none of the cases above a correct use of killall.
From `man killall`:
DESCRIPTION
killall sends a signal to all processes running any of the
specified commands.
I think it is clear that killall should be regard as a last option: if I
have two processes foo and I want to kill only one of them, killall will
fail here. Actually, killall works the same as
$ kill `pidof $PROGRAM`
Indeed, `man pidof`:
NOTES
pidof is actually the same program as killall5; the program
behaves according to the name under which it is called.
When pidof is invoked with a full pathname to the program it
should find the pid of, it is reasonably safe. Otherwise it is
possible that it returns pids of running programs that happen to
have the same name as the program you're after but are actually
other programs.
The major advantage of the kill+pidof equivalent is that it both
programs are installed by default on every Debian system (the first
provided by procps, the second by sysvinit-utils, both packages priority
required). The Debian FSO team experienced the very same problem two
times in the past:
http://lists.linuxtogo.org/pipermail/smartphones-userland/2008-December/000751.html
However, as I wrote before, I would strongly discourage using killall.
Instead, since AFAIK all DHCP clients wicd can use (including udhcpc
once bug #520014 will be fixed) support a "write the PID to a file"
option, the best solution would be to check for the existence of such a
PID file (usually /var/run/$PROGRAM.$IFACE.pid) and then kill this
specific process.
I would like to find some consensus on this solution before starting to
implement it ;-)
Thx, bye,
Gismo / Luca
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: armel (armv4tl)
Kernel: Linux 2.6.29-20090303.gitb9de904e (PREEMPT)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash
Versions of packages wicd depends on:
ii adduser 3.110 add and remove users and groups
pn dhcpcd | dhcp3-client | pump <none> (no description available)
ii net-tools 1.60-23 The NET-3 networking toolkit
ii python 2.5.4-2 An interactive high-level object-o
ii python-dbus 0.83.0-1 simple interprocess messaging syst
ii python-glade2 2.14.1-1 GTK+ bindings: Glade support
ii python-gtk2 2.14.1-1 Python bindings for the GTK+ widge
ii python-support 0.8.7 automated rebuilding support for P
ii wireless-tools 29-1.1 Tools for manipulating Linux Wirel
ii wpasupplicant 0.6.4-3 Client support for WPA and WPA2 (I
wicd recommends no packages.
Versions of packages wicd suggests:
pn pm-utils <none> (no description available)
-- no debconf information
pgptP7B3mmKpe.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: wicd
Source-Version: 1.6.0-1
We believe that the bug you reported is fixed in the latest version of
wicd, which is due to be installed in the Debian FTP archive:
wicd_1.6.0-1.diff.gz
to pool/main/w/wicd/wicd_1.6.0-1.diff.gz
wicd_1.6.0-1.dsc
to pool/main/w/wicd/wicd_1.6.0-1.dsc
wicd_1.6.0-1_all.deb
to pool/main/w/wicd/wicd_1.6.0-1_all.deb
wicd_1.6.0.orig.tar.gz
to pool/main/w/wicd/wicd_1.6.0.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
David Paleino <[email protected]> (supplier of updated wicd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 06 Jun 2009 01:03:58 +0200
Source: wicd
Binary: wicd
Architecture: source all
Version: 1.6.0-1
Distribution: experimental
Urgency: low
Maintainer: [email protected]
Changed-By: David Paleino <[email protected]>
Description:
wicd - wired and wireless network manager
Closes: 516466 520014 520925 522057 524060 525542 525622 526408 528928 530505
Changes:
wicd (1.6.0-1) experimental; urgency=low
.
* New upstream version
- DBus at_console policy fixed (Closes: #530505, #525622)
- wireless channel shown in overview (Closes: #525542)
- added "Search domain" option in preferences tab (Closes: #516466)
* debian/patches/:
- 01-fix_desktop_file.patch, 07-add_resolvconf_support.patch
removed, fixed upstream
- 02-fix_logfile_perms.patch, 03-fix_lintian_manpage_warning.patch,
04-fix-scripts.patch refreshed
- 05-fix_DBus_policy.patch removed, permissions given to the
`netdev' group via a configuration option
- 06-add_LC_MESSAGES_parsing.patch removed, fixed upstream (in
wicd/translations.py)
- 09-fix_wire_plugging_detection.patch fixed (Closes: #522057)
- 10-add_udhcpc_support.patch added, thanks to "madmo" from the
Wicd forums for making it, and to Luca Capello for fixing and
porting it to 1.5.9, now ported to 1.6.0 (Closes: #520014)
* original debian/po removed, substituted by debconf's translations
* debian/config, debian/templates added, initial debconf support
(Closes: #524060)
* debian/control:
- Build-Dependency on po-debconf added
- added missing dependency on lsb-base
- added missing dependency on python-urwid, needed by wicd-curses
- added missing dependency on psmisc (Closes: #520925)
- added alternative dependency on udhcpc
* debian/postinst:
- enable debconf questions
* debian/README.Debian updated: specify that DBus should be boot-started
before wicd (Closes: #526408)
* debian/init: added support for "status" command, thanks to Peter
Eisentraut (Closes: #528928)
* debian/rules updated
* debian/watch fixed not to catch alpha/beta releases
Checksums-Sha1:
c82b9221149c7e7d8774fdfa013f55080992a404 1278 wicd_1.6.0-1.dsc
9fc3a4ca41a657c913f05d457e55519692241b12 462787 wicd_1.6.0.orig.tar.gz
64cd24b9cf97b3e6d4f9491ecc78722bca943e24 14800 wicd_1.6.0-1.diff.gz
a798b316dcf01a3a047352d3a8b941802d9a1201 424956 wicd_1.6.0-1_all.deb
Checksums-Sha256:
cab6e4f46547d159efd153faab9803b684ea12b32b3ac95b4ab5b6b9cb0d6783 1278
wicd_1.6.0-1.dsc
780b9d9261a2fcfee9f06da446b11a444f1fcce48b9a5883c0edd7cf41db298a 462787
wicd_1.6.0.orig.tar.gz
b4856fdbe083be1a9521ec08b68a91315f3cbb220909d6ac56ced3f433e7dbec 14800
wicd_1.6.0-1.diff.gz
00e406998ba4e4b783faa37e9f5ad702cee796a60c86cb3279bfca33a27e92a1 424956
wicd_1.6.0-1_all.deb
Files:
19cded3ef41312cf1f70851658775a7c 1278 net optional wicd_1.6.0-1.dsc
38a68300a37eb1ba8fb85a9c02bb9355 462787 net optional wicd_1.6.0.orig.tar.gz
d3cb85b945185f004d1f3a80a65a239f 14800 net optional wicd_1.6.0-1.diff.gz
1d2144a85952ac99082c85bad7f42e9d 424956 net optional wicd_1.6.0-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkoppPcACgkQ5qqQFxOSsXRPQwCgmDePFVg4/dERXvjKBNvuqm5h
tgQAoJF0Wi57WySRt+PDRLQ6p4Gec5Fv
=m6QI
-----END PGP SIGNATURE-----
--- End Message ---
