Your message dated Sun, 21 Jun 2009 13:47:11 +0000
with message-id <[email protected]>
and subject line Bug#530542: fixed in tuxtype 1.7.5.dfsg1-1
has caused the Debian Bug report #530542,
regarding Tustype: Please use tuxtype.desktop in upstream tarball along with 
their new .png icon
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
530542: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530542
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tuxtype
Version: 1.7.4.dfsg1



Tuxtype upstream tarball already provides a .desktop file, while the one presently installed by Debian doesn't have upstream translations and rely on a non-standard directory (/usr/share/tuxtype, instead of the default /usr/share/pixmaps), thus having to specify a full path to the icon (should be Icon=tuxtype without extension, provided the icon is either in PNG, SVG or the old XPM format kept for backwards compability reasons).

While doing that, let's use the new icon for tuxtype (in the upstream tarball, named "tuxtype.png") which would clean the diff.gz and be more informative.

Attached are the files in debian affected by the change, debian/tuxtype.xpm and debian/tuxtype.desktop can be simply removed. I propose creating usr/share/applications in debian/tuxtype.dirs instead of an mkdir in debian/rules, since debian/tuxtype.dirs exists and is already used for two directories. You'll also note that upstream has changed the menu categories to Education/Languages - although the Languages subcategory isn't really pertinent, see : http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry


Diffs:
diff tuxtype-1.7.4.dfsg1/debian/rules rules
66,68c66,67
< cp $(CURDIR)/debian/tuxtype.xpm $(CURDIR)/debian/tuxtype/usr/share/tuxtype/tuxtype.xpm
<    mkdir -p $(CURDIR)/debian/tuxtype/usr/share/applications
<    cp $(CURDIR)/debian/tuxtype.desktop \
---
> cp $(CURDIR)/icon.png $(CURDIR)/debian/tuxtype/usr/share/pixmaps/tuxtype.png
>    cp $(CURDIR)/tuxtype.desktop \

diff tuxtype-1.7.4.dfsg1/debian/tuxtype.dirs tuxtype.dirs
2c2,3
< usr/share/tuxtype
---
> usr/share/pixmaps
> usr/share/applications

diff tuxtype-1.7.4.dfsg1/debian/menu menu
1,3c1,3
< ?package(tuxtype):needs="X11" section="Games/Action"\
<   icon="/usr/share/tuxtype/tuxtype.xpm" \
<   title="Tuxtype" command="/usr/games/tuxtype"
---
> ?package(tuxtype):needs="X11" section="Education/Languages"\
>   icon="/usr/share/pixmaps/tuxtype.png" \
>   title="Tux Typing" command="/usr/games/tuxtype"
?package(tuxtype):needs="X11" section="Education/Languages"\
  icon="/usr/share/pixmaps/tuxtype.png" \
  title="Tux Typing" command="/usr/games/tuxtype"
#!/usr/bin/make -f
# -*- makefile -*-
# Sample debian/rules that uses debhelper.
# This file was originally written by Joey Hess and Craig Small.
# As a special exception, when this file is copied by dh-make into a
# dh-make output file, you may use that output file without restriction.
# This special exception was added by Craig Small in version 0.37 of dh-make.

# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1

# These are used for cross-compiling and for saving the configure script
# from having to guess our platform (since we know it already)
DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)


CFLAGS = -Wall -g

ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
        CFLAGS += -O0
else
        CFLAGS += -O2
endif

config.status: 
        dh_testdir
        QUILT_PATCHES=debian/patches quilt push -a || test $$? = 2
        # Add here commands to configure the package.
        CFLAGS="$(CFLAGS)" ./configure --host=$(DEB_HOST_GNU_TYPE) 
--build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man 
--infodir=\$${prefix}/share/info --bindir=\$${prefix}/games


build: build-arch build-indep


build-arch: build-arch-stamp

build-arch-stamp:  config.status
        dh_testdir
        # Add here commands to compile the package.
        $(MAKE)
        touch build-arch-stamp

build-indep: build-indep-stamp
build-indep-stamp:  config.status
        touch build-indep-stamp

clean:
        dh_testdir
        dh_testroot
        QUILT_PATCHES=debian/patches quilt pop -a -R || test $$? = 2
        rm -f build-arch-stamp build-indep-stamp install-stamp
        [ ! -f Makefile ] || $(MAKE) distclean
        dh_clean 


install:
        dh_testdir
        dh_testroot
        dh_clean -k 
        dh_installdirs 
        # Add here commands to install the package into debian/tuxtype.
        $(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
        dh_installdirs -ptuxtype-data  usr/share/
        dh_installdirs
        cp $(CURDIR)/icon.png 
$(CURDIR)/debian/tuxtype/usr/share/pixmaps/tuxtype.png
        cp $(CURDIR)/tuxtype.desktop \
                $(CURDIR)/debian/tuxtype/usr/share/applications/tuxtype.desktop
        rm $(CURDIR)/debian/tmp/usr/share/tuxtype/fonts -Rf

        touch install-stamp

install-arch: install
install-indep: install
        
binary-common:
        dh_testdir
        dh_testroot
        dh_installchangelogs ChangeLog
        dh_installdocs
        dh_installmenu
        dh_installman
        dh_install --sourcedir=debian/tmp
        dh_link
        dh_strip
        dh_compress
        dh_fixperms
        dh_installdeb
        dh_shlibdeps
        dh_gencontrol
        dh_md5sums
        dh_builddeb

# Build architecture-independent files here.
binary-indep: build-indep install-indep
        $(MAKE) -f debian/rules DH_OPTIONS=-i binary-common

# Build architecture-dependent files here.
binary-arch: build-arch install-arch
        $(MAKE) -f debian/rules DH_OPTIONS=-a binary-common

binary: binary-indep binary-arch
.PHONY: build clean binary-indep binary-arch binary install tuxtype-data
usr/games
usr/share/pixmaps
usr/share/applications

--- End Message ---
--- Begin Message ---
Source: tuxtype
Source-Version: 1.7.5.dfsg1-1

We believe that the bug you reported is fixed in the latest version of
tuxtype, which is due to be installed in the Debian FTP archive:

tuxtype-data_1.7.5.dfsg1-1_all.deb
  to pool/main/t/tuxtype/tuxtype-data_1.7.5.dfsg1-1_all.deb
tuxtype_1.7.5.dfsg1-1.diff.gz
  to pool/main/t/tuxtype/tuxtype_1.7.5.dfsg1-1.diff.gz
tuxtype_1.7.5.dfsg1-1.dsc
  to pool/main/t/tuxtype/tuxtype_1.7.5.dfsg1-1.dsc
tuxtype_1.7.5.dfsg1-1_i386.deb
  to pool/main/t/tuxtype/tuxtype_1.7.5.dfsg1-1_i386.deb
tuxtype_1.7.5.dfsg1.orig.tar.gz
  to pool/main/t/tuxtype/tuxtype_1.7.5.dfsg1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Levsen <[email protected]> (supplier of updated tuxtype package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 11 Jun 2009 16:06:56 +0200
Source: tuxtype
Binary: tuxtype tuxtype-data
Architecture: source all i386
Version: 1.7.5.dfsg1-1
Distribution: unstable
Urgency: low
Maintainer: Holger Levsen <[email protected]>
Changed-By: Holger Levsen <[email protected]>
Description: 
 tuxtype    - Educational Typing Tutor Game Starring Tux
 tuxtype-data - Data files for the Educational Typing Tutor Game Starring Tux
Closes: 530542 531753
Changes: 
 tuxtype (1.7.5.dfsg1-1) unstable; urgency=low
 .
   * New upstream release, addressing several issues, primarily translation
     issues and handling of the xml lesson files.
   * Add build-depends for librsvg2-dev.
   * Drop automake and quilt from build-depends, all patches have been applied
     upstream.
   * Install .mo files into /usr/share/locale/ so that translations become
     available. (Closes: #531753)
   * Use the new upstream icon and .desktop file, thanks to Loïc Martin.
     (Closes: #530542)
   * Use "set -e" in tuxtype.postinst to appease lintian.
Checksums-Sha1: 
 bb2ad73db56feea3b7cbf98fc4e5f13063596b91 1262 tuxtype_1.7.5.dfsg1-1.dsc
 96bcb1a30f4734673e42f623ef56b95a2d5bd13d 7743501 
tuxtype_1.7.5.dfsg1.orig.tar.gz
 63e71dbdcb76ee196089a2d90f2e8548b003ce01 11447 tuxtype_1.7.5.dfsg1-1.diff.gz
 c5ea82b47f96de3ed5c416313d772f208099d753 5977918 
tuxtype-data_1.7.5.dfsg1-1_all.deb
 1adb55d1e6b3b03eb0d4377e8979f874c188d8d8 76878 tuxtype_1.7.5.dfsg1-1_i386.deb
Checksums-Sha256: 
 acccf8801efafbe104c9073a4f4372f8205b2a4e3162f6cda6689994f4efd2db 1262 
tuxtype_1.7.5.dfsg1-1.dsc
 d34f76ae78af0c8e7c4faf88f512e1fe3c81c49745b20901ffa0c80dca1e8001 7743501 
tuxtype_1.7.5.dfsg1.orig.tar.gz
 ceca725d1e03abb1df0459355a8a580b724649fa8ba0e7367d5c4bbcc1db3b04 11447 
tuxtype_1.7.5.dfsg1-1.diff.gz
 1f331c0bea12896ed0dc2443d5e247238d15d4750bcda10046f349776e0313dd 5977918 
tuxtype-data_1.7.5.dfsg1-1_all.deb
 e3549c13dcc40d738412022b73128c7c5c30fa3ac09147564b65294270581255 76878 
tuxtype_1.7.5.dfsg1-1_i386.deb
Files: 
 552acafbdbbe7f339020bf827e8d5f1c 1262 games optional tuxtype_1.7.5.dfsg1-1.dsc
 5ddadde5bf73a6196c7b0e019abace3f 7743501 games optional 
tuxtype_1.7.5.dfsg1.orig.tar.gz
 56f501949e704870f80fca5ef59b259e 11447 games optional 
tuxtype_1.7.5.dfsg1-1.diff.gz
 6296b5e38d5b66588ab3461d86022eed 5977918 games optional 
tuxtype-data_1.7.5.dfsg1-1_all.deb
 9782b35b51244903dacb56763a8f634b 76878 games optional 
tuxtype_1.7.5.dfsg1-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFKPjS6UHLQNqxYNSARAjU8AJsHYYZ19vX9fqChEwT+DtEGdRgrMACgvZ0c
dylpG/Wgy9vfOTFNZjvAyR0=
=NWur
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to