Your message dated Tue, 30 Jun 2009 17:17:05 +0000
with message-id <[email protected]>
and subject line Bug#534565: fixed in debhelper 7.2.19
has caused the Debian Bug report #534565,
regarding debhelper: dh_install does not properly handle dangling symlinks
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
534565: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=534565
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 7.2.16
Severity: serious
Hi!
On dh_install, when using compat level >= 7, passing an absolute path
(like “$(CURDIR)/debian/tmp”) to --sourcedir, the first result of the
glob is a dangling symlink (like when it points to another directory,
which then makes it need to be an absolute path, for example
“debian/tmp/usr/lib/libfoo.so” pointing to “/lib/libfoo.so.1”), the
automatic fallback to look into “debian/tmp” makes the destination
path end up in something like “/debian/tmp/<path>”.
Arguably this can be fixed by just dropping the --sourcedir
argument, but still, it breaks the packages pretty badly, thus the
serious severity.
I didn't notice this on few of my packages (libpmount, libaio, etc) on
my build system because I've the shared library packages installed,
which makes the absolute symlinks not be dangling ones.
Attached patch should fix this.
regards,
guillem
diff --git a/dh_install b/dh_install
index 5a3a7f5..3aa748a 100755
--- a/dh_install
+++ b/dh_install
@@ -153,7 +153,7 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
my @found = glob "$srcdir/$glob";
if (! compat(6)) {
# Fall back to looking in debian/tmp.
- if (! @found || ! -e $found[0]) {
+ if (! @found || ! (-e $found[0] || -l $found[0])) {
@found = glob "debian/tmp/$glob";
}
}
--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 7.2.19
We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive:
debhelper_7.2.19.dsc
to pool/main/d/debhelper/debhelper_7.2.19.dsc
debhelper_7.2.19.tar.gz
to pool/main/d/debhelper/debhelper_7.2.19.tar.gz
debhelper_7.2.19_all.deb
to pool/main/d/debhelper/debhelper_7.2.19_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joey Hess <[email protected]> (supplier of updated debhelper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 30 Jun 2009 12:56:52 -0400
Source: debhelper
Binary: debhelper
Architecture: source all
Version: 7.2.19
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <[email protected]>
Changed-By: Joey Hess <[email protected]>
Description:
debhelper - helper programs for debian/rules
Closes: 534565
Changes:
debhelper (7.2.19) unstable; urgency=low
.
* dh_install: Handle correctly the case where a glob expands to
a dangling symlink, installing the dangling link as requested.
Closes: #534565
* dh_install: Fix fallback use of debian/tmp in v7 mode; a bug caused
it to put files inside a debian/tmp directory in the package build
directory, now that prefix is stripped. (See #534565)
Checksums-Sha1:
8cd34a50077eae8dd9689fee41ba8e7e25dbae9d 910 debhelper_7.2.19.dsc
7b4731c690a8a64b4a3c7628e84438f530598b44 296739 debhelper_7.2.19.tar.gz
b3661259ef41704910a634a732f50eb36217a76a 543764 debhelper_7.2.19_all.deb
Checksums-Sha256:
badbaf134b3657a68a8a0716712d5094e2c00bdcaddbed3854a4da08a255e751 910
debhelper_7.2.19.dsc
a99f4ce337e509291967a211d61940a2ed7ead48a447e08f2d2ab2d981a3e78a 296739
debhelper_7.2.19.tar.gz
a23f415de83c27ee767c82de5a08eed37139293bbbe7e455a8606b2f4ca56b8f 543764
debhelper_7.2.19_all.deb
Files:
ff7bb2ab875e2e6320b21f905d2975a4 910 devel optional debhelper_7.2.19.dsc
7107b37e6b9a9e1d9525060e523df11b 296739 devel optional debhelper_7.2.19.tar.gz
fac859f864bee618e51c5b8e2893b70d 543764 devel optional debhelper_7.2.19_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFKSkVy2tp5zXiKP0wRAsK8AKDD5o4dDONOLy6y40DOx4oZEQa0gQCeL0+b
Xq8KKmXefSAWDqtdvGSBZn8=
=6xHh
-----END PGP SIGNATURE-----
--- End Message ---
