Your message dated Sat, 25 Jul 2009 14:25:51 -0400
with message-id <[email protected]>
and subject line Re: Bug#538115: test suite fails with perl critic complaint
has caused the Debian Bug report #538115,
regarding test suite fails with perl critic complaint
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
538115: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538115
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libtest-distmanifest-perl
Version: 1.1.2
Severity: normal
This package does not build depend on perl critic, but
if it happens to be installed, it FTBFS:
t/01critic..........
# Failed test 'Test::Perl::Critic for "blib/lib/Test/DistManifest.pm"'
# at /usr/share/perl5/Test/Perl/Critic.pm line 99.
t/01critic..........NOK 1/1#
# Perl::Critic found these violations in "blib/lib/Test/DistManifest.pm":
Can't call method "config" on an undefined value at
/usr/share/perl5/Test/Perl/Critic.pm line 83.
# Looks like you failed 1 test of 1.
# Looks like your test died just after 1.
t/01critic..........dubious
Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED test 1
Failed 1/1 tests, 0.00% okay
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.30-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--
see shy jo
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Oops, forgot to mail -done.
On Sat, Jul 25, 2009 at 2:25 PM, Jonathan Yu<[email protected]> wrote:
> Hi Joey:
>
> I finally tracked down this bug!
>
> On Sat, Jul 25, 2009 at 11:18 AM, Joey Hess<[email protected]> wrote:
>> Jonathan Yu wrote:
>>> I can't reproduce this using libtest-distmanifest-perl built inside a
>>> chroot. Is it possible that you have an older version? Could you
>>> please repeat the build with the latest version (1.2.2)?
>>
>> I typoed the version; my build was on 1.2.2.
>>
>>> If you continue having FTBFS issues please let me know. The latest
>>> version does have the perlcritic tests in B-D-I:
>>> libtest-perl-critic-perl (>= 1.01), libperl-critic-perl (>= 1.098),
>>
>> That explains how perl critic got installed on my chroot.
>
> As it turns out, it's because of two things... Firstly, that I have
> taint mode enabled in t/01critic.t (the -T flag to perl). Second, it's
> because you had the Pod::Spell and other dependencies installed.
>
> This explains why I wasn't able to reproduce it.
>
> Basically, it was trying to do some sort of spell check, but had to
> fork out to the environment to look around for 'aspell' and run it. In
> the course of that, it was emitting this message:
>
> Insecure $ENV{PATH} while running with -T switch at
> /usr/share/perl5/Perl/Critic/Policy/Documentation/PodSpelling.pm line
> 221, <GEN0> line 5.
>
>>
>> I can't reproduce it in a clean squeeze chroot. Odd..
> That, would be because you don't have the PodSpelling policy's
> dependency chain installed inside a clean chroot.
>
> There are two things you can do to work around this:
> 1. Remove the -T flag from t/01critic.t's shebang
> 2. Exclude the PodSpelling tests (via 01critic.rc -- I'll be doing
> this for future releases)
>
> I'll be fixing this in the upstream version and pushing a release
> shortly, so I'm marking this bug as done. If you have any other
> concerns or if the above workaround doesn't work (outside of your
> clean chroot) then please let me know :-)
>
> Thanks again
>>
>> --
>> see shy jo
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.9 (GNU/Linux)
>>
>> iD8DBQFKayJMd8HHehbQuO8RAjChAJ9+rthuFq/6p0xq5IcpxLtOTWceSgCg7B2O
>> 3ZYSwOmNbUwmP4FQ+4yAK7U=
>> =vflv
>> -----END PGP SIGNATURE-----
>>
>>
>
--- End Message ---
