Your message dated Tue, 11 Aug 2009 05:47:14 +0000
with message-id <[email protected]>
and subject line Bug#536165: fixed in jack 3.1.1+cvs20050801-26
has caused the Debian Bug report #536165,
regarding jack: does not display the correct list of categories on freedb submit
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
536165: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=536165
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: jack
Version: 3.1.1+cvs20050801-25
Severity: normal
Tags: patch
Hi!
When I try to send a submission to a freedb server, the list of
categories appearing on the screen does not contain 'blues' (which is a
freedb category) and contains 'null' (which is not a freedb category).
I think that a few changes must be made to jack_freedb.py:
* when the list is fetched from the server, it is unnecessarily
initialised with "null"
* subtract 1 to the index to get the correct category
* When the list is displayed, the index is running from 1 to len(cat)-1,
missing the first item.
The attached patch solved the problem for me, to be applied after the
already very long list of patches.
Best regards,
Cédric
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (990, 'unstable'), (700, 'experimental'), (500, 'testing')
Architecture: powerpc (ppc)
Kernel: Linux 2.6.29-1-powerpc
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages jack depends on:
ii cdda2wav 9:1.1.9-1 Dummy transition package for iceda
ii cdparanoia 3.10.2+debian-5 audio extraction tool for sampling
ii flac 1.2.1-1.2 Free Lossless Audio Codec - comman
ii python 2.5.4-2 An interactive high-level object-o
ii python-cddb 1.4-5.1+b1 Python interface to CD-IDs and Fre
ii python-eyed3 0.6.17-1 Python module for id3-tags manipul
ii python-pyvorbis 1.3-2 A Python interface to the Ogg Vorb
ii python-support 1.0.2 automated rebuilding support for P
ii vorbis-tools 1.2.0-6 several Ogg Vorbis tools
jack recommends no packages.
jack suggests no packages.
-- no debconf information
--- jack-3.1.1+cvs20050801/jack_freedb.py 2009-07-07 21:04:06.000000000 +0200
+++ jack-3.1.1+cvs20050801-cb/jack_freedb.py 2009-07-07 21:03:22.000000000 +0200
@@ -761,11 +761,11 @@
def choose_cat(cat = ["blues", "classical", "country", "data", "folk", "jazz", "misc", "newage", "reggae", "rock", "soundtrack"]):
print "choose a category:"
cat.sort()
- for i in range(1, len(cat)):
- print "%2d" % i + ".) " + cat[i]
+ for i in range(0, len(cat)):
+ print "%2d" % (i+1) + ".) " + cat[i]
x = -1
- while x < 0 or x > len(cat) - 1:
+ while x < 0 or x > len(cat):
if jack_progress.status_all.has_key('freedb_cat') and jack_progress.status_all['freedb_cat'][-1] in cat:
input = raw_input(" 0.) none of the above (default='%s'): " % jack_progress.status_all['freedb_cat'][-1])
if not input:
@@ -782,7 +782,7 @@
print "ok, aborting."
sys.exit(0)
- return cat[x]
+ return cat[x-1]
def do_freedb_submit(file, cd_id, cat = None):
import httplib
@@ -798,7 +798,7 @@
cat = choose_cat()
elif buf[0:3] == "210":
- cat = ["null", ]
+ cat = []
while 1:
buf = f.readline()
if not buf:
--- End Message ---
--- Begin Message ---
Source: jack
Source-Version: 3.1.1+cvs20050801-26
We believe that the bug you reported is fixed in the latest version of
jack, which is due to be installed in the Debian FTP archive:
jack_3.1.1+cvs20050801-26.diff.gz
to pool/main/j/jack/jack_3.1.1+cvs20050801-26.diff.gz
jack_3.1.1+cvs20050801-26.dsc
to pool/main/j/jack/jack_3.1.1+cvs20050801-26.dsc
jack_3.1.1+cvs20050801-26_amd64.deb
to pool/main/j/jack/jack_3.1.1+cvs20050801-26_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Martin Michlmayr <[email protected]> (supplier of updated jack package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 10 Aug 2009 19:18:27 -1000
Source: jack
Binary: jack
Architecture: source amd64
Version: 3.1.1+cvs20050801-26
Distribution: unstable
Urgency: low
Maintainer: Michael Banck <[email protected]>
Changed-By: Martin Michlmayr <[email protected]>
Description:
jack - Rip and encode CDs with one command
Closes: 536165
Changes:
jack (3.1.1+cvs20050801-26) unstable; urgency=low
.
* debian/patches/99a_correct-category-list.patch: Make sure the correct
FreeDB categories are displayed when submitting a CD. Thanks to
Cédric Boutillier for the patch; closes: #536165.
* debian/control (Depends): Add ${shlibs:Depends} (for glibc) and
${misc:Depends} (for debhelper).
* debian/copyright: Update to reflect that the license is GPL 2 or
later rather than GPL 2 only.
Checksums-Sha1:
d4dad725fc469f3c06c8b33acda58cdefe1b8f48 1151 jack_3.1.1+cvs20050801-26.dsc
291bfae7b69a842107acf6f520a9ef1b9e6bacae 63702
jack_3.1.1+cvs20050801-26.diff.gz
b0244b365dbd7f9588f1695757da0df2f5e16851 156458
jack_3.1.1+cvs20050801-26_amd64.deb
Checksums-Sha256:
1c5a0be6d348e9978c5a63becf26549653c0db97ddec91fc4eb5a9f7c6fdb16f 1151
jack_3.1.1+cvs20050801-26.dsc
c72f9fc1109fcca750b0452efe53670387c3dc1aceb97c07cdd543ef0a286491 63702
jack_3.1.1+cvs20050801-26.diff.gz
753fa4411a4bd0dcb33c1d02cf7650613df5297ae4212c58127e9a5cf66ca8f6 156458
jack_3.1.1+cvs20050801-26_amd64.deb
Files:
7dedffe9ed873fbf8b07f4ab91526afd 1151 sound optional
jack_3.1.1+cvs20050801-26.dsc
27a4e3bfdbff6229d3bc6cb48a35efb3 63702 sound optional
jack_3.1.1+cvs20050801-26.diff.gz
34439641bed92f2956c7458bebd016e0 156458 sound optional
jack_3.1.1+cvs20050801-26_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkqBApYACgkQKb5dImj9VJ/KEwCgoSuC/xRqCbRPp1s9JpyxnJ7n
VHoAn0ZYRTlb0WXBQS4uABbRocqQvAVu
=a+cH
-----END PGP SIGNATURE-----
--- End Message ---
