Your message dated Thu, 03 Sep 2009 18:47:26 +0000
with message-id <[email protected]>
and subject line Bug#539089: fixed in libxdg-basedir 1.0.2-1
has caused the Debian Bug report #539089,
regarding libxdg-basedir: Memory leak even after calling xdgWipeHandle()
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
539089: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=539089
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libxdg-basedir
Severity: normal
Tags: patch
Hello,
When running valgrind on my program using libxdg-basedir, it reports the
following memory leak:
==25556== 19 bytes in 1 blocks are definitely lost in loss record 1 of 3
==25556== at 0x402601E: malloc (vg_replace_malloc.c:207)
==25556== by 0x40440A5: xdgGetEnv (basedir.c:187)
==25556== by 0x4044524: xdgUpdateData (basedir.c:321)
==25556== by 0x40446CB: xdgInitHandle (basedir.c:125)
==25556== by 0x804DC46: parse_command_line_parameters (pcompmgr.c:128)
==25556== by 0x804DF29: main (pcompmgr.c:226)
I guess it's because cacheHome on line 187 (basedir.c) is never freed. I
have attached to this email a patch that works fine for me, e.g.
valgrind is happy with it, but as I'm not so familiar with
libxdg-basedir source code so I might be wrong.
Regards,
Arnaud Fontaine
-- System Information:
Debian Release: squeeze/sid
APT prefers experimental
APT policy: (990, 'experimental'), (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.26-maggie-1
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
From a22a544c38e4bff9b05c53bf5874de6515d14e39 Mon Sep 17 00:00:00 2001
From: Arnaud Fontaine <[email protected]>
Date: Wed, 29 Jul 2009 01:33:18 +0200
Subject: [PATCH] Fixed memory leak on cacheHome.
---
src/basedir.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/basedir.c b/src/basedir.c
index b85a2d1..222d10c 100644
--- a/src/basedir.c
+++ b/src/basedir.c
@@ -153,6 +153,11 @@ static void xdgFreeData(xdgCachedData *cache)
free(cache->configHome);
cache->configHome = 0;
}
+ if (cache->cacheHome)
+ {
+ free(cache->cacheHome);
+ cache->cacheHome = 0;
+ }
xdgFreeStringList(cache->searchableDataDirectories);
cache->searchableDataDirectories = 0;
xdgFreeStringList(cache->searchableConfigDirectories);
--
1.6.3.3
pgpwJpk0EjtIH.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: libxdg-basedir
Source-Version: 1.0.2-1
We believe that the bug you reported is fixed in the latest version of
libxdg-basedir, which is due to be installed in the Debian FTP archive:
libxdg-basedir-dev_1.0.2-1_amd64.deb
to pool/main/libx/libxdg-basedir/libxdg-basedir-dev_1.0.2-1_amd64.deb
libxdg-basedir1-dbg_1.0.2-1_amd64.deb
to pool/main/libx/libxdg-basedir/libxdg-basedir1-dbg_1.0.2-1_amd64.deb
libxdg-basedir1_1.0.2-1_amd64.deb
to pool/main/libx/libxdg-basedir/libxdg-basedir1_1.0.2-1_amd64.deb
libxdg-basedir_1.0.2-1.diff.gz
to pool/main/libx/libxdg-basedir/libxdg-basedir_1.0.2-1.diff.gz
libxdg-basedir_1.0.2-1.dsc
to pool/main/libx/libxdg-basedir/libxdg-basedir_1.0.2-1.dsc
libxdg-basedir_1.0.2.orig.tar.gz
to pool/main/libx/libxdg-basedir/libxdg-basedir_1.0.2.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mark Nevill <[email protected]> (supplier of updated libxdg-basedir package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 03 Sep 2009 16:03:16 +0200
Source: libxdg-basedir
Binary: libxdg-basedir-dev libxdg-basedir1 libxdg-basedir1-dbg
Architecture: source amd64
Version: 1.0.2-1
Distribution: unstable
Urgency: low
Maintainer: Mark Nevill <[email protected]>
Changed-By: Mark Nevill <[email protected]>
Description:
libxdg-basedir-dev - implementation of the XDG Base Directory Specifications
libxdg-basedir1 - implementation of the XDG Base Directory Specifications
libxdg-basedir1-dbg - implementation of the XDG Base Directory Specifications
Closes: 539089 544843
Changes:
libxdg-basedir (1.0.2-1) unstable; urgency=low
.
* New upstream bugfix release
* Closes: #539089, #544843
* Update Standards-Version to 3.8.3
Checksums-Sha1:
0d933b08288ea572a7526c8fd484721881804367 1195 libxdg-basedir_1.0.2-1.dsc
8c75931d0abcf7fefae50f22d06299ca1f06d1da 312855
libxdg-basedir_1.0.2.orig.tar.gz
1e90ab398606f0348a46d80fa6674d91b18bfa41 19496 libxdg-basedir_1.0.2-1.diff.gz
e6637e3e928dc631bfc360d2ce81a266c2d81600 32058
libxdg-basedir-dev_1.0.2-1_amd64.deb
fae92e2d7f8fbb8c572f5438e7f27fcd6b47fb0f 8910 libxdg-basedir1_1.0.2-1_amd64.deb
e381022be661d3757b8b1c7450639645aeee8abf 11308
libxdg-basedir1-dbg_1.0.2-1_amd64.deb
Checksums-Sha256:
b574a50c648a7438234a98c9a2f444ad93e2eada2d8d67aca11c8100f76a2fc2 1195
libxdg-basedir_1.0.2-1.dsc
31dd8bbe032fcefb2f50932f699f50005d9ddd63283a5ac06c0f09a1d65f2b3a 312855
libxdg-basedir_1.0.2.orig.tar.gz
bceb53cb3fdfabb419f4c1b4f74e4d9870ea06e7e5c6d4ac50a972ca1f3c0e18 19496
libxdg-basedir_1.0.2-1.diff.gz
ae52b65def98bbecb93136c5e2a679613f47f70857311e1e1857ec14daf83fe1 32058
libxdg-basedir-dev_1.0.2-1_amd64.deb
e5a3d063cd5faeda8da3f758cfc3fde5aad2ed738417f43a891df1ee60b49c21 8910
libxdg-basedir1_1.0.2-1_amd64.deb
df33ade4420da07c98f4fe03bcb1b5e2848c32268ef4cb6406f4ac8aeca7655b 11308
libxdg-basedir1-dbg_1.0.2-1_amd64.deb
Files:
2b438c73d2556e61474a709a0d2f1be2 1195 libs optional libxdg-basedir_1.0.2-1.dsc
944202425e5359666f268d18671303d4 312855 libs optional
libxdg-basedir_1.0.2.orig.tar.gz
3b3a69e4dcf19aa6a8a63981354e59fa 19496 libs optional
libxdg-basedir_1.0.2-1.diff.gz
58e7cfd713c986ad6a3d2d9619b17204 32058 libdevel optional
libxdg-basedir-dev_1.0.2-1_amd64.deb
91894c644f59a15a66d282e4b4f6c312 8910 libs optional
libxdg-basedir1_1.0.2-1_amd64.deb
51caf71a907f71dfeb3e3cdf4d67f2ee 11308 debug extra
libxdg-basedir1-dbg_1.0.2-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkqgAdIACgkQfbltLjbuCGGxdwCfXU/IShHBsw9AKVR404GTENRm
1JAAoLhYtH8V7acL6UXbkzFGyjk1pjVd
=DXyn
-----END PGP SIGNATURE-----
--- End Message ---
