Your message dated Sun, 25 Oct 2009 18:38:03 +0200
with message-id <[email protected]>
and subject line Re: Bug#537055: asterisk: Bug in bristuff priority jumping
patch
has caused the Debian Bug report #537055,
regarding asterisk: Bug in bristuff priority jumping patch
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
537055: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537055
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: asterisk
Version: 1:1.4.21.2~dfsg-3
Severity: normal
Tags: patch
The bristuff/app-dial-priority-202 patch does not check that priority
jumping is actually enabled before attempting to jump to n+201.
The bristuff patches are not shipped in unstable right now, but if
they ever get put back, this should be fixed first. :)
Please find attached a patch to fix this. I can't actually figure out
where to send this upstream...
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages asterisk depends on:
ii 3.110 add and remove users and groups
ii 2.2~20090605+locanet5d82546~2.gbp939f asterisk configureation for Gemein
ii 1:1.6.1.0~dfsg-1 Core Sound files for Asterisk (Eng
ii 1.0.20-3 shared library for ALSA applicatio
ii 8:2007b~dfsg-1.1+b1 c-client library for mail protocol
ii 2.9-19 GNU C Library: Shared libraries
ii 1:2.16-5 support for getting/setting POSIX.
ii 7.19.5-1 Multi-protocol file transfer libra
ii 1:4.4.0-10 GCC support library
ii 1.0.12-1 Shared libraries for GSM speech co
ii 1.2-4 C library for the Jabber IM platfo
ii 5.7+20090607-1 shared libraries for terminal hand
ii 0.52.10-4 Not Erik's Windowing Toolkit - tex
ii 1.1.3-5 Ogg Bitstream Library
ii 1.14-4 lib for parsing cmdline parameters
ii 8.4.0-1 PostgreSQL C client library
ii 0.5.6-1 Enhanced RADIUS client library
ii 5.4.1~dfsg-12 SNMP (Simple Network Management Pr
ii 1.2~rc1-1 The Speex codec runtime library
ii 1.2~rc1-1 The Speex extended runtime library
ii 2.8.17-4 SQLite shared library
ii 0.9.8k-3 SSL shared libraries
ii 4.4.0-10 The GNU Standard C++ Library v3
ii 1.2.0.dfsg-5 The Vorbis General Audio Compressi
ii 1.2.0.dfsg-5 The Vorbis General Audio Compressi
ii 4.2.41-1 Voicetronix telephony hardware use
ii 2.2.11-16+b1 ODBC tools libraries
ii 1:1.2.3.3.dfsg-14 compression library - runtime
asterisk recommends no packages.
Versions of packages asterisk suggests:
pn asterisk-dev <none> (no description available)
pn asterisk-doc <none> (no description available)
pn asterisk-h323 <none> (no description available)
ii ekiga 3.2.1~git20090515.9d0263-1 H.323 and SIP compatible VoIP clie
pn kphone <none> (no description available)
pn ohphone <none> (no description available)
pn twinkle <none> (no description available)
-- no debconf information
Index: debian/patches/bristuff/app-dial-priority-202
===================================================================
--- debian/patches/bristuff/app-dial-priority-202 (revision 7415)
+++ debian/patches/bristuff/app-dial-priority-202 (working copy)
@@ -21,7 +21,7 @@
" k - Allow the called party to enable parking of the call by sending\n"
" the DTMF sequence defined for call parking in features.conf.\n"
" K - Allow the calling party to enable parking of the call by sending\n"
-@@ -1292,14 +1297,16 @@ static int dial_exec_full(struct ast_cha
+@@ -1292,14 +1297,18 @@ static int dial_exec_full(struct ast_cha
}
if (!outgoing) {
@@ -32,7 +32,9 @@
goto out;
}
+ /* See if there is a special message */
-+ ast_goto_if_exists(chan, chan->context, chan->exten, chan->priority + 201);
++ if (ast_opt_priority_jumping || ast_test_flag(&opts, OPT_PRIORITY_JUMP)) {
++ ast_goto_if_exists(chan, chan->context, chan->exten, chan->priority + 201);
++ }
} else {
/* Our status will at least be NOANSWER */
- strcpy(status, "NOANSWER");
--- End Message ---
--- Begin Message ---
Version: 1:1.6.1.0~dfsg~rc3-1
Tim Retout wrote:
> The bristuff/app-dial-priority-202 patch does not check that priority
> jumping is actually enabled before attempting to jump to n+201.
Ouch! Sorry about that.
> The bristuff patches are not shipped in unstable right now, but if
> they ever get put back, this should be fixed first. :)
Over my dead body. We've had enough!
> Please find attached a patch to fix this. I can't actually figure out
> where to send this upstream...
bristuff's upstream was never responsive and we were mostly fixing the
bugs on our own. I wouldn't expect to reach anyone in the post-bristuff
(i.e. 1.6) era.
Thanks,
Faidon
--- End Message ---
