Your message dated Sat, 14 Nov 2009 17:33:09 +0000
with message-id <[email protected]>
and subject line Bug#555517: fixed in vsftpd 2.2.2~pre1-1
has caused the Debian Bug report #555517,
regarding /etc/init.d/vsftpd will not stop process if vsftpd.conf is changed 
while running
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
555517: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=555517
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: vsftpd
Version: 2.2.0-4
Severity: normal
Tags: patch


The init.d script that comes with vsftpd aborts all processing unless
listen=yes in the configuration file. As a result, if you do the
following:

    1. Start vsftpd in standalone mode
    2. Comment out listen=yes, or change it to listen=no
    3. Attempt to stop or restart the service by calling the
       init-script

the script will exit cleanly, but the vsftpd process will still be
running. There is no feedback provided to the administrator that the
commands have been ignored.

The attached patch moves the logic of the standalone check into a
function to be called by the start/restart logic, and ensures that the
administrator is given appropriate feedback if the script will not be
started.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (700, 'unstable'), (600, 'stable'), (550, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages vsftpd depends on:
ii  adduser                       3.111      add and remove users and groups
ii  debconf [debconf-2.0]         1.5.28     Debian configuration management sy
ii  libc6                         2.10.1-5   GNU C Library: Shared libraries
ii  libcap2                       1:2.17-2   support for getting/setting POSIX.
ii  libpam-modules                1.1.0-4    Pluggable Authentication Modules f
ii  libpam0g                      1.1.0-4    Pluggable Authentication Modules l
ii  libssl0.9.8                   0.9.8k-5   SSL shared libraries
ii  libwrap0                      7.6.q-18   Wietse Venema's TCP wrappers libra
ii  netbase                       4.37       Basic TCP/IP networking system

Versions of packages vsftpd recommends:
ii  logrotate                     3.7.8-4    Log rotation utility

vsftpd suggests no packages.

-- debconf information excluded
--- /etc/init.d/vsftpd
+++ /etc/init.d/vsftpd
@@ -14,11 +14,16 @@
 
 set -e
 
-# Exit if vsftpd.conf doesn't have listen=yes or listen_ipv6=yes
-# (mandatory for standalone operation)
-if [ -f /etc/vsftpd.conf ] && ! egrep -iq "^ *listen(_ipv6)? *= *yes" 
/etc/vsftpd.conf; then 
-    exit 0
-fi
+# Returns 1 if not configured for standalone operation.
+check_standalone_mode () {
+  # Exit if vsftpd.conf doesn't have listen=yes or listen_ipv6=yes
+  # (mandatory for standalone operation)
+  local CONFFILE='/etc/vsftpd.conf'
+  if [ -f "$CONFFILE" ] && ! egrep -iq "^ *listen(_ipv6)? *= *yes" 
"$CONFFILE"; then 
+    echo "$CONFFILE: listen disabled : service will not start" 
+    return 1
+  fi
+}
 
 DAEMON=/usr/sbin/vsftpd
 NAME=vsftpd
@@ -37,6 +42,7 @@
 
 case "$1" in
   start)
+    check_standalone_mode || exit
     echo -n "Starting FTP server: "
     [ -d ${CHROOT} ] || mkdir -p ${CHROOT}
     start-stop-daemon --start --background -m --oknodo --pidfile 
/var/run/vsftpd/vsftpd.pid --exec $DAEMON
@@ -49,9 +55,12 @@
     echo "${NAME}."
       ;;
   restart)
-    echo -n "Restarting FTP server: "
+    echo -n "Stopping FTP server: "
     start-stop-daemon --stop --pidfile /var/run/vsftpd/vsftpd.pid --oknodo 
--exec $DAEMON
     rm -f /var/run/vsftpd/vsftpd.pid
+    echo "${NAME}."
+    check_standalone_mode || exit
+    echo -n "Starting FTP server: "
     start-stop-daemon --start --background -m --pidfile 
/var/run/vsftpd/vsftpd.pid --exec $DAEMON
     echo "${NAME}."
     ;;

--- End Message ---
--- Begin Message ---
Source: vsftpd
Source-Version: 2.2.2~pre1-1

We believe that the bug you reported is fixed in the latest version of
vsftpd, which is due to be installed in the Debian FTP archive:

vsftpd_2.2.2~pre1-1.diff.gz
  to main/v/vsftpd/vsftpd_2.2.2~pre1-1.diff.gz
vsftpd_2.2.2~pre1-1.dsc
  to main/v/vsftpd/vsftpd_2.2.2~pre1-1.dsc
vsftpd_2.2.2~pre1-1_i386.deb
  to main/v/vsftpd/vsftpd_2.2.2~pre1-1_i386.deb
vsftpd_2.2.2~pre1.orig.tar.gz
  to main/v/vsftpd/vsftpd_2.2.2~pre1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated vsftpd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 14 Nov 2009 18:21:08 +0100
Source: vsftpd
Binary: vsftpd
Architecture: source i386
Version: 2.2.2~pre1-1
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Description: 
 vsftpd     - lightweight, efficient FTP server written for security
Closes: 555517
Changes: 
 vsftpd (2.2.2~pre1-1) unstable; urgency=low
 .
   * Applying patch from Todd A. Jacobs <[email protected]> to give
     proper return values in initscript (Closes: #555517.
   * Cleaning up init script (intentations, variables, bashisms, etc.).
   * Merging upstream version 2.2.2~pre1.
Checksums-Sha1: 
 8b335fbf0f97894319f2549c5bb649780dcd6903 1327 vsftpd_2.2.2~pre1-1.dsc
 d7710a2fb11546d82e56d4ebf24f3435c9ace36e 185554 vsftpd_2.2.2~pre1.orig.tar.gz
 bbce32fb0b2cbb7b53df8b9c648018d1a70cc6ac 21287 vsftpd_2.2.2~pre1-1.diff.gz
 e15aca5b13845b74d1324f837e7275e681150ea8 137554 vsftpd_2.2.2~pre1-1_i386.deb
Checksums-Sha256: 
 6941bba1e6765c26b188cb3a1f1d2cefdacc7813972c96becae058846e1c4b8b 1327 
vsftpd_2.2.2~pre1-1.dsc
 bd9739eddfdb0026ae8065461945a049aec8eb36e3d8226fc6d441d12fff490a 185554 
vsftpd_2.2.2~pre1.orig.tar.gz
 3fec14af0fed757fb243123e13fea3e7274574ecdf06a4cf18a00c562cc74883 21287 
vsftpd_2.2.2~pre1-1.diff.gz
 288ed3505664fded88511dfd7db8ad4efcb3b2284de7d5b09919bc80b2274c02 137554 
vsftpd_2.2.2~pre1-1_i386.deb
Files: 
 2a1d718a2a726b08b0fbcc6fa80fdf2d 1327 net extra vsftpd_2.2.2~pre1-1.dsc
 5ddb7808dd0a9066bfa0d2dbfc5ebc09 185554 net extra vsftpd_2.2.2~pre1.orig.tar.gz
 2c85f34f88c5f6d05bc831870a78f856 21287 net extra vsftpd_2.2.2~pre1-1.diff.gz
 b9ad31bc0002f66ed756356f40cf7b63 137554 net extra vsftpd_2.2.2~pre1-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkr+508ACgkQ+C5cwEsrK56NOQCfVTxZ2lSlRlQuJc8hZPx14wTB
7gcAoN8/vFMFBIcPrgPmTYH4BqHqTAXz
=MBGu
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to