Your message dated Tue, 17 Nov 2009 01:18:00 +0000
with message-id <[email protected]>
and subject line Bug#556569: fixed in ethtool 6+20090323-3
has caused the Debian Bug report #556569,
regarding ethtool if-up script should exit immediately if IFACE=lo
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
556569: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=556569
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ethtool
Version: 6+20090323-2
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu karmic ubuntu-patch
Hi folks,
The ethtool package currently installs if-up and if-pre-up hooks that
postprocess various env vars to tune the underlying ethernet device. This
obviously makes no sense to do when the interface is the loopback interface,
because we know lo never has ethernet hardware.
The attached patch has been applied in Ubuntu to short-circuit these
scripts, according to the convention used in other if-up scripts. Changelog
entry for this change is:
* debian/ethtool.if-up, debian/ethtool.if-pre-up: exit if the interface is
lo, there's no sense in spending time parsing the env with awk in this
case.
I would recommend doing the same in the Debian package, since this gives a
measurable reduction in boot time due to the overhead of the awk commands.
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -u ethtool-6+20090323/debian/ethtool.if-pre-up ethtool-6+20090323/debian/ethtool.if-pre-up
--- ethtool-6+20090323/debian/ethtool.if-pre-up
+++ ethtool-6+20090323/debian/ethtool.if-pre-up
@@ -4,6 +4,8 @@
test -x $ETHTOOL || exit 0
+[ "$IFACE" != "lo" ] || exit 0
+
# Gather together the mixed bag of settings applied with -s/--change
SETTINGS="\
${IF_ETHERNET_PORT:+ port $IF_ETHERNET_PORT}\
diff -u ethtool-6+20090323/debian/ethtool.if-up ethtool-6+20090323/debian/ethtool.if-up
--- ethtool-6+20090323/debian/ethtool.if-up
+++ ethtool-6+20090323/debian/ethtool.if-up
@@ -4,6 +4,8 @@
test -x $ETHTOOL || exit 0
+[ "$IFACE" != "lo" ] || exit 0
+
# Find settings with a given prefix and print them as they appeared in
# /etc/network/interfaces, only with the prefix removed.
gather_settings () {
--- End Message ---
--- Begin Message ---
Source: ethtool
Source-Version: 6+20090323-3
We believe that the bug you reported is fixed in the latest version of
ethtool, which is due to be installed in the Debian FTP archive:
ethtool_6+20090323-3.diff.gz
to main/e/ethtool/ethtool_6+20090323-3.diff.gz
ethtool_6+20090323-3.dsc
to main/e/ethtool/ethtool_6+20090323-3.dsc
ethtool_6+20090323-3_amd64.deb
to main/e/ethtool/ethtool_6+20090323-3_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Anibal Monsalve Salazar <[email protected]> (supplier of updated ethtool
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 17 Nov 2009 11:32:53 +1100
Source: ethtool
Binary: ethtool
Architecture: source amd64
Version: 6+20090323-3
Distribution: unstable
Urgency: low
Maintainer: Anibal Monsalve Salazar <[email protected]>
Changed-By: Anibal Monsalve Salazar <[email protected]>
Description:
ethtool - display or change Ethernet device settings
Closes: 556569
Changes:
ethtool (6+20090323-3) unstable; urgency=low
.
* Exit immediately if IFACE=lo in if-up script
Patch by Steve Langasek
Closes: 556569
Checksums-Sha1:
ac6003e1ae6cc8f08b5019a63da8c25f8d64d93c 1111 ethtool_6+20090323-3.dsc
a588aa0f9f7bc703807dff42763f0beaac68838e 9041 ethtool_6+20090323-3.diff.gz
23d95e927ae381cb61acad3df3b3ea147e76732f 72092 ethtool_6+20090323-3_amd64.deb
Checksums-Sha256:
9068b4e2f415b874fc933b9d18ff4ba01037ca865297b06f78f6f76406089544 1111
ethtool_6+20090323-3.dsc
f801f0baf6d368b88da19383214c03a5e218431cd43d365070cb41dbcec892c0 9041
ethtool_6+20090323-3.diff.gz
ab98b0ea4efab51954c8751cfac3a27e7c51a38f14595c530eb4ccfc64a3015c 72092
ethtool_6+20090323-3_amd64.deb
Files:
5aeb82c046d9c8e2fa6b019841024981 1111 utils optional ethtool_6+20090323-3.dsc
c94051f2e6b4510b9a3e85635de1523d 9041 utils optional
ethtool_6+20090323-3.diff.gz
3fd3e50d983c4e94f6f6e599ef600775 72092 utils optional
ethtool_6+20090323-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAksB9WMACgkQgY5NIXPNpFWAMACfV0qHGlYvUPQnykzsAR5TPdug
60IAn292gu5VM/LBNZxWBVGFLvM2czBm
=3bq1
-----END PGP SIGNATURE-----
--- End Message ---
