Your message dated Wed, 02 Dec 2009 22:03:11 +0000
with message-id <[email protected]>
and subject line Bug#555123: fixed in plastex 0.9.2-1
has caused the Debian Bug report #555123,
regarding python-plastex: plastex copies links to icons into icons directory 
rather than copying files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
555123: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=555123
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-plastex
Version: 0.9.1-1
Severity: normal
Tags: patch

Hi!

When using plastex to compile documentation, for example:

  TEXINPUTS= plastex -d html pyxplot.tex

the html/icons directory is full of links to the actual icons:

  blank.gif -> 
/usr/share/python-support/python-plastex/plasTeX/Renderers/XHTML/Themes/default/icons/blank.gif

which only makes sense if the package depends on plastex as well as using it
to build the documentation. Since plastex uses python-support to build, any 
change in python-support such as changing the location of shared files to
/usr/share/pyshared/ (which has already recently happened) will also break all
these links. In a plastex-rendered document, these probably should be the real
files not symlinks, and I'm pretty sure this is what is intended by the upstream
authors for plastex and we are getting symlinks in Debian only because Debian
supports multiple python versions using symlink farms.

In a makefile using plastex, these symlinks can be reverted to real files
using a snippet like:

      find doc/html -type l \
          -exec sh -c 'cp --remove-destination "$$(readlink {})" "{}"' \;

but that's pretty ugly to have to do.

The problem seems to come from around line 322 in 
Renderers/PageTemplate/__init__.py
where the theme files are just blindly copied across rather than the symlinks
being dereferenced. Changing the copytree call to not make symlinks and the
copy call to a copyfile call as per the attached patch solves this problem.

Since upstream have explicitly used copytree in a way that it should copy over
symlinks, it might be worthwhile dicussing this change with them prior to 
patching the Debian package, although I don't believe that it was upstream's
intention to end up with broken symlinks like this.

cheers
Stuart
--- Renderers/PageTemplate/__init__.py-orig     2009-11-08 15:15:03.000000000 
+0000
+++ Renderers/PageTemplate/__init__.py  2009-11-08 15:31:51.000000000 +0000
@@ -328,7 +328,7 @@
                             if not os.path.isdir(os.path.join(cwd,item)):
                                 os.makedirs(os.path.join(cwd,item))
-                            copytree(item, cwd, True)
+                            copytree(item, cwd, False)
                         elif os.path.splitext(item)[-1].lower() not in 
extensions:
-                            shutil.copy(item, os.path.join(cwd,item))
+                            shutil.copyfile(item, os.path.join(cwd,item))
                     os.chdir(cwd)
 

--- End Message ---
--- Begin Message ---
Source: plastex
Source-Version: 0.9.2-1

We believe that the bug you reported is fixed in the latest version of
plastex, which is due to be installed in the Debian FTP archive:

plastex_0.9.2-1.diff.gz
  to main/p/plastex/plastex_0.9.2-1.diff.gz
plastex_0.9.2-1.dsc
  to main/p/plastex/plastex_0.9.2-1.dsc
plastex_0.9.2.orig.tar.gz
  to main/p/plastex/plastex_0.9.2.orig.tar.gz
python-plastex-doc_0.9.2-1_all.deb
  to main/p/plastex/python-plastex-doc_0.9.2-1_all.deb
python-plastex_0.9.2-1_all.deb
  to main/p/plastex/python-plastex_0.9.2-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Carl Fürstenberg <[email protected]> (supplier of updated plastex package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 17 Nov 2009 17:30:15 +0100
Source: plastex
Binary: python-plastex python-plastex-doc
Architecture: source all
Version: 0.9.2-1
Distribution: unstable
Urgency: low
Maintainer: Carl Fürstenberg <[email protected]>
Changed-By: Carl Fürstenberg <[email protected]>
Description: 
 python-plastex - LaTeX document processing framework in Python
 python-plastex-doc - LaTeX document processing framework in Python - 
documentation fil
Closes: 555123
Changes: 
 plastex (0.9.2-1) unstable; urgency=low
 .
   [ Carl Fürstenberg ]
   * New upstream release
   * Added patch to resolve problem copying of icons (Closes: #555123)
   * Migrate from Dpatch to Quilt
   * Bumping Standards-Version to 3.8.3 (no change)
 .
   [ Sandro Tosi ]
   * debian/control
     - switch Vcs-Browser field to viewsvn
Checksums-Sha1: 
 4191569ca4ed579fa0a00662f0a4aa581ceec3ef 1473 plastex_0.9.2-1.dsc
 0c31769164018961e81276648efcf954419bad72 865856 plastex_0.9.2.orig.tar.gz
 ae4a5ad9dcb91754e9279fecb3edb6fa490a16d9 15388 plastex_0.9.2-1.diff.gz
 5106023f31e0a33ecd0f82d84aed58e4790e9dd0 558918 python-plastex_0.9.2-1_all.deb
 ff50296ad5e949d9f179c76f66215ddcb9ba8fea 289028 
python-plastex-doc_0.9.2-1_all.deb
Checksums-Sha256: 
 2096fa81c43138c126c08f63ae0887b43d6f270e20ca2c49f5afaeb95ed2be48 1473 
plastex_0.9.2-1.dsc
 0f3cfb88b395fe706e0abaf57a4fc85d8bec6f4753681ea064fc02c911fd2d23 865856 
plastex_0.9.2.orig.tar.gz
 a3b198734838385c228932843a48a259327fc95786f87763680c16c388a2b592 15388 
plastex_0.9.2-1.diff.gz
 08ae203a3a9dc16214cf7ebee16499af61477b9133abe3355df45ea3baa469b7 558918 
python-plastex_0.9.2-1_all.deb
 e87ca43bb36fed1745a6a1117cfc5b4e6e1f9efaf8236165e997b384b0c78bdd 289028 
python-plastex-doc_0.9.2-1_all.deb
Files: 
 fc3765ec6c6a16694659b0be9c18b0e4 1473 tex optional plastex_0.9.2-1.dsc
 31a568374a9e08b6aac48aa1173b79ab 865856 tex optional plastex_0.9.2.orig.tar.gz
 c6456699b4dd0147f3cb50a87bb7a4dd 15388 tex optional plastex_0.9.2-1.diff.gz
 fe5f76f47a76b91b8802f2bdae0ff315 558918 tex optional 
python-plastex_0.9.2-1_all.deb
 b215ee7f0e9914444c345598f53bc134 289028 doc optional 
python-plastex-doc_0.9.2-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAksW4F0ACgkQB01zfu119ZlahwCfS47ApmP05LRpvOhyQmmbnkoZ
uz4AoJpsHewRx8IYIAnJOKOvPZ1lhebd
=CD1m
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to