Your message dated Tue, 22 Dec 2009 10:21:43 +0100
with message-id <[email protected]>
and subject line Re: Bug#537955: Please don't assume cross compilation
has caused the Debian Bug report #537807,
regarding irssi: Please don't assume cross compilation
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
537807: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537807
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: irssi
Version: 0.8.13-2
Severity: minor
Tags: patch
Hi!
While building irssi, you specify both the --build and --host options
to configure. This, while not incorrect, is unneeded in non-cross
compilation scenarios, since it is sufficient to specify just --build
when not cross compiling.
The attached patch detects whether the package is being cross
compiled, and adapts accordingly.
HTH.
Kumar
>From a19308dada3db8290066dba25f5cf50d65b245e5 Mon Sep 17 00:00:00 2001
From: Kumar Appaiah <[email protected]>
Date: Mon, 20 Jul 2009 20:12:42 -0500
Subject: [PATCH] Check if we actually are cross compiling.
Specifying both the --build and --host options to configure is needed
only when cross compiling, which causes the proper
<arch>-<machine>-gnu-gcc compiler to be used (like
x86_64-linux-gnu-gcc). Therefore, we check if we are cross compiling
(i.e., whether the host machine and target machine are of different
types). If they are different, both options are passed to the
configure script. Else, only the --build option is passed, which
results in the correct compiler (gcc) being used.
Signed-off-by: Kumar Appaiah <[email protected]>
---
debian/rules | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/debian/rules b/debian/rules
index d5841ad..898f41c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,6 +9,12 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
+ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
+CROSS= --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE)
+else
+CROSS= --build $(DEB_BUILD_GNU_TYPE)
+endif
+
include /usr/share/quilt/quilt.make
# These are used for cross-compiling and for saving the configure script
@@ -28,7 +34,7 @@ endif
config.status: patch configure
dh_testdir
# Add here commands to configure the package.
- CFLAGS="$(CFLAGS)" ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
+ CFLAGS="$(CFLAGS)" ./configure $(CROSS) \
--prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info \
--sysconfdir=/etc \
--without-servertest --enable-ipv6 --with-bot --with-proxy \
--
1.5.6.5
--- End Message ---
--- Begin Message ---
* Gerfried Fuchs <[email protected]> [2009-10-02 22:21:22 CEST]:
> * Kumar Appaiah <[email protected]> [2009-10-02 18:53:13 CEST]:
> > Actually, after filing this report, it was pointed out to me by
> > someone else as well that it's not an absolute necessity to have this
> > in place, as long as it does not affect the working of the
> > package. So, I don't consider this request legitimate anymore, and
> > won't mind if you do close this bug.
>
> Thanks, and sorry for responding late; but on the other hand I still
> can get away with that I'm not the listed maintainer of the package. ;)
> About closing, it would had been as appropriate for you to close it
> right ahead as it is for me, doing it now.
Found another of those in one of my packages - maybe you want to track
down your multiple "cross compilation" bugs and close them yourself
alltogether. :)
So long!
Rhonda
--- End Message ---
