Your message dated Tue, 09 Aug 2005 06:17:08 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#238737: fixed in fvwm 1:2.5.13-0.CVS.2005.08.08.01-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 18 Mar 2004 17:43:04 +0000
>From [EMAIL PROTECTED] Thu Mar 18 09:43:04 2004
Return-path: <[EMAIL PROTECTED]>
Received: from topaz.cx (mail.topaz.cx) [66.220.6.227] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1B41Xs-0003CN-00; Thu, 18 Mar 2004 09:43:04 -0800
Received: from tytlal.hmsonline.com
([207.43.94.202] helo=tytlal ident=Debian-exim)
by mail.perlsupport.com with asmtp (Exim 3.35 #1 (Debian))
id 1B41Xs-0008Gf-00; Thu, 18 Mar 2004 09:43:04 -0800
Received: from chip by tytlal with local (Exim 4.30)
id 1B41Xo-0000rm-QK; Thu, 18 Mar 2004 12:43:00 -0500
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Chip Salzenberg <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: GotoDesk doesn't wrap around like docs say it should
X-Mailer: reportbug 2.53
Date: Thu, 18 Mar 2004 12:43:00 -0500
Message-Id: <[EMAIL PROTECTED]>
Sender: Chip Salzenberg <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_12
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_12
X-Spam-Level:
Package: fvwm
Version: 2.5.8-0.3
Severity: normal
Tags: experimental patch
The docs on GotoDesk say that when the movement is relative, it should
wrap around instead of truncating. That doesn't work right (you always
end up at the end or beginning). Here's a patch.
--- fvwm-2.5.8-0.3/fvwm/virtual.c 2003-09-25 04:21:28.000000000 -0400
+++ fvwm-2.5.8/fvwm/virtual.c 2004-03-18 11:27:29.000000000 -0500
@@ -112,4 +112,5 @@
int n;
int m;
+ int rel;
int desk;
int val[4];
@@ -138,4 +139,5 @@
/* absolute desk number */
desk = val[1];
+ rel = 0;
}
else
@@ -143,4 +145,5 @@
/* relative desk number */
desk += val[0];
+ rel = 1;
}
@@ -169,7 +172,19 @@
max = val[m];
}
+ if (rel)
+ {
+ /* Relative moves wrap around. */
+ if (desk < min)
+ {
+ desk += (max - min + 1);
+ }
+ else if (desk > max)
+ {
+ desk -= (max - min + 1);
+ }
+ }
if (desk < min)
{
- /* Relative move outside of range, wrap around. */
+ /* Move outside of range, truncate. */
if (val[0] < 0)
{
@@ -183,5 +198,5 @@
else if (desk > max)
{
- /* Relative move outside of range, wrap around. */
+ /* Move outside of range, truncate. */
if (val[0] > 0)
{
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.4bk4
Locale: LANG=C, LC_CTYPE=C
Versions of packages fvwm depends on:
ii libc6 2.3.2.ds1-11 GNU C Library: Shared libraries an
ii libice6 4.3.0-5 Inter-Client Exchange library
ii libpng12-0 1.2.5.0-5 PNG library - runtime
ii libsm6 4.3.0-5 X Window System Session Management
ii libx11-6 4.3.0-5 X Window System protocol client li
ii libxext6 4.3.0-5 X Window System miscellaneous exte
ii libxpm4 4.3.0-5 X pixmap library
ii xlibs 4.3.0-6 X Window System client libraries m
ii zlib1g 1:1.2.1-5 compression library - runtime
-- debconf information excluded
---------------------------------------
Received: (at 238737-close) by bugs.debian.org; 9 Aug 2005 13:20:25 +0000
>From [EMAIL PROTECTED] Tue Aug 09 06:20:25 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1E2Tye-0002JB-00; Tue, 09 Aug 2005 06:17:08 -0700
From: Manoj Srivastava <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#238737: fixed in fvwm 1:2.5.13-0.CVS.2005.08.08.01-1
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Tue, 09 Aug 2005 06:17:08 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: fvwm
Source-Version: 1:2.5.13-0.CVS.2005.08.08.01-1
We believe that the bug you reported is fixed in the latest version of
fvwm, which is due to be installed in the Debian FTP archive:
fvwm-gnome_2.5.13-0.CVS.2005.08.08.01-1_i386.deb
to pool/main/f/fvwm/fvwm-gnome_2.5.13-0.CVS.2005.08.08.01-1_i386.deb
fvwm_2.5.13-0.CVS.2005.08.08.01-1.diff.gz
to pool/main/f/fvwm/fvwm_2.5.13-0.CVS.2005.08.08.01-1.diff.gz
fvwm_2.5.13-0.CVS.2005.08.08.01-1.dsc
to pool/main/f/fvwm/fvwm_2.5.13-0.CVS.2005.08.08.01-1.dsc
fvwm_2.5.13-0.CVS.2005.08.08.01-1_i386.deb
to pool/main/f/fvwm/fvwm_2.5.13-0.CVS.2005.08.08.01-1_i386.deb
fvwm_2.5.13-0.CVS.2005.08.08.01.orig.tar.gz
to pool/main/f/fvwm/fvwm_2.5.13-0.CVS.2005.08.08.01.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Manoj Srivastava <[EMAIL PROTECTED]> (supplier of updated fvwm package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 8 Aug 2005 20:55:52 -0500
Source: fvwm
Binary: fvwm fvwm-gnome
Architecture: source i386
Version: 1:2.5.13-0.CVS.2005.08.08.01-1
Distribution: unstable
Urgency: low
Maintainer: Manoj Srivastava <[EMAIL PROTECTED]>
Changed-By: Manoj Srivastava <[EMAIL PROTECTED]>
Description:
fvwm - F(?) Virtual Window Manager, version 2.5
fvwm-gnome - F(?) Virtual Window Manager, version 2.5
Closes: 238737
Changes:
fvwm (1:2.5.13-0.CVS.2005.08.08.01-1) unstable; urgency=low
.
* New upstream CVS version.
- Fvwm now officially supports 64-bit architertures.
* Fixed a Solaris compiler error introduced in 2.5.13
* Fixed a hang with layers set by applications (e.g. AbiWord).
* Bug fix: "GotoDesk doesn't wrap around like docs say it should",
thanks to Chip Salzenberg. GotoDesk with a relative page argument now
wraps around at the end of the given range as documented. (Closes:
#238737).
Files:
ba63bcfd0878ecfd11960aa7fddcefd4 1035 x11 optional
fvwm_2.5.13-0.CVS.2005.08.08.01-1.dsc
3a49cf8a17913dc0275202bf7af5962a 2275207 x11 optional
fvwm_2.5.13-0.CVS.2005.08.08.01.orig.tar.gz
e64cf13642281292063a42766d580673 561204 x11 optional
fvwm_2.5.13-0.CVS.2005.08.08.01-1.diff.gz
0543118d468683e45b392418d66959ca 3048054 x11 optional
fvwm_2.5.13-0.CVS.2005.08.08.01-1_i386.deb
2536e92090c035200f4758a29fb55805 3048664 x11 optional
fvwm-gnome_2.5.13-0.CVS.2005.08.08.01-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFC+KdoIbrau78kQkwRAnF/AJ4iWJVlG80f8A5ZADomes9FICV60QCg3YLP
7BDLIDefsamQUQ5CdvzClEo=
=gSF3
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
