Your message dated Wed, 30 Dec 2009 21:17:27 +0000
with message-id <[email protected]>
and subject line Bug#486265: fixed in amideco 0.31e-3.1
has caused the Debian Bug report #486265,
regarding amideco: unexpected compression flag causes program to exit with "Bad
Table [2]"
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
486265: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=486265
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: amideco
Version: 0.31e-3
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Some of the newer BIOS files I have seem to use a compression flag value
unknown to amideco for some of their parts. amideco will attempt to
decompress these parts using its built-in lzh decompression. This fails
with the message "Bad Table [2]" and the program exits immediately,
thereby failing to write any parts.
The attached patch "fixes" this by ignoring the unknown flag and
printing a warning. I have not been able to find any description of
the file format, but my experiments so far indicates that treating the
"IsComprs" byte as a bitmap instead of a two-value byte is correct.
The only value I have observed in addition to 0x00 and 0x80 is 0x90.
It is commonly used for values of class 11 (P6 Microcode), 15 (Memory
Sizing) and 30 (Font Database).
I assume the 0x10 bit has some significance, so I believe it is
appropriate to issue a warning when handling these parts.
Bjørn
- -- System Information:
Debian Release: lenny/sid
APT prefers stable
APT policy: (700, 'stable'), (650, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.24-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages amideco depends on:
ii libc6 2.7-10 GNU C Library: Shared libraries
amideco recommends no packages.
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFIVCBT10rqkowbIskRAiHrAJ94rrbUiPHWvjgVkEndTHBNRDGq9wCdGFV/
4qbcR6qua0xCJ0FnTvXXNsE=
=ViCE
-----END PGP SIGNATURE-----
--- amideco-0.31e/src/amifunc.c.old 2008-06-14 20:59:45.000000000 +0200
+++ amideco-0.31e/src/amifunc.c 2008-06-14 21:16:44.000000000 +0200
@@ -339,11 +339,11 @@
part.PartID,
PartTotal,
GetModuleName(part.PartID),
- (part.IsComprs!=0x80)?(part.ROMSize):(part.CSize),
- (part.IsComprs!=0x80)?(part.ROMSize):(part.CSize),
- (part.IsComprs!=0x80)?(part.ExpSize):(part.CSize),
- (part.IsComprs!=0x80)?(part.ExpSize):(part.CSize),
- (part.IsComprs!=0x80)?(IDSign):(" "),
+ ((part.IsComprs&0x80)==0)?(part.ROMSize):(part.CSize),
+ ((part.IsComprs&0x80)==0)?(part.ROMSize):(part.CSize),
+ ((part.IsComprs&0x80)==0)?(part.ExpSize):(part.CSize),
+ ((part.IsComprs&0x80)==0)?(part.ExpSize):(part.CSize),
+ ((part.IsComprs&0x80)==0)?(IDSign):(" "),
Offset-ConstOff
);
@@ -376,7 +376,7 @@
interface.dicbit = 13;
interface.method = 5;
- if(part.IsComprs!=0x80)
+ if((part.IsComprs&0x80)==0)
decode(interface);
else
{
@@ -385,6 +385,9 @@
fread(&Buf[0],1,1,ptx);
fwrite(&Buf[0],1,1,pto);
};
+ if(part.IsComprs!=0x80)
+ printf("WARNING: Ignoring unknown
compression flag (0x%02x) for part id %02X\n",
+ part.IsComprs, part.PartID);
}
fclose(pto);
break;
--- End Message ---
--- Begin Message ---
Source: amideco
Source-Version: 0.31e-3.1
We believe that the bug you reported is fixed in the latest version of
amideco, which is due to be installed in the Debian FTP archive:
amideco_0.31e-3.1.diff.gz
to main/a/amideco/amideco_0.31e-3.1.diff.gz
amideco_0.31e-3.1.dsc
to main/a/amideco/amideco_0.31e-3.1.dsc
amideco_0.31e-3.1_i386.deb
to main/a/amideco/amideco_0.31e-3.1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Barry deFreese <[email protected]> (supplier of updated amideco package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 23 Dec 2009 15:19:51 -0500
Source: amideco
Binary: amideco
Architecture: source i386
Version: 0.31e-3.1
Distribution: unstable
Urgency: low
Maintainer: Uwe Hermann <[email protected]>
Changed-By: Barry deFreese <[email protected]>
Description:
amideco - Decompress flashfiles equipped with an AMI BIOS
Closes: 486085 486265 532695
Changes:
amideco (0.31e-3.1) unstable; urgency=low
.
* Non-maintainer upload.
* 30_hurd.diff. Fix FTBFS on GNU/Hurd. (Closes: #532695).
* 40_bad_table.diff. Fix compression flag. (Closes: #486265).
* 50_bad_output.diff. Fix bogus output. (Closes: #486085).
+ Thanks to Bjørn Mork for the patches (40 and 50).
Checksums-Sha1:
6776fe2a98bd553a35f3ffe61eb59e8d531e6c5f 986 amideco_0.31e-3.1.dsc
37029437b2bf208d3e17f30fb0417da4de452ce2 3464 amideco_0.31e-3.1.diff.gz
10962d0bc0d0cb6216450d4a9f3ee18b61730d92 11680 amideco_0.31e-3.1_i386.deb
Checksums-Sha256:
84044e6a085cdea7aa7fb3f0b31e23836437b9b7077492c33f6161072a6a611e 986
amideco_0.31e-3.1.dsc
3dd214d41e8bf367232aca2f3198981113451469d0cb7b975ca007bac367e576 3464
amideco_0.31e-3.1.diff.gz
dfa8b6502c0a4683b74154043a2bebd10399c076399c48ff4e63931c7c462804 11680
amideco_0.31e-3.1_i386.deb
Files:
3b7da46f26f480149e3a133c8a0b7cd1 986 utils optional amideco_0.31e-3.1.dsc
80f34e4af74c1cdec28e8d701e60123a 3464 utils optional amideco_0.31e-3.1.diff.gz
063b2caa98868c2a56fd9c0618036cf8 11680 utils optional
amideco_0.31e-3.1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAksyfnwACgkQ5ItltUs5T34fcACgzICgH/TFDUtuf7yR5xSyk6Zh
o+gAnRJVDR+3PIbAakU8FaeOlvi/j+mi
=ZxTh
-----END PGP SIGNATURE-----
--- End Message ---
