Your message dated Sun, 28 Feb 2010 16:47:15 +0000
with message-id <[email protected]>
and subject line Bug#561004: fixed in gtk-vnc 0.3.10-3
has caused the Debian Bug report #561004,
regarding gtk-vnc: FTBFS on GNU/Hurd because of PATH_MAX usage
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
561004: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561004
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gtk-vnc
Severity: normal
Tags: patch
Hi Guido,
gtk-vnc FTBFS on the Hurd because there PATH_MAX is not defined (as
there is no limit). Since it's not guaranteed to be defined, it
should not be used unconditionally. I've created a patch to use
dynamic allocation instead of a fixed size buffer, please consider
applying it to the Debian package.
The upstream bug report is this:
https://bugzilla.gnome.org/show_bug.cgi?id=604448
Cheers,
Emilio
diff -ruNp gtk-vnc-0.3.10.orig/src/vncdisplay.c gtk-vnc-0.3.10/src/vncdisplay.c
--- gtk-vnc-0.3.10.orig/src/vncdisplay.c 2009-10-16 18:52:28.000000000 +0200
+++ gtk-vnc-0.3.10/src/vncdisplay.c 2009-12-11 11:53:44.000000000 +0100
@@ -1998,67 +1998,76 @@ static void vnc_display_init(VncDisplay
priv->gvnc = gvnc_new(&vnc_display_ops, obj);
}
-static int vnc_display_best_path(char *buf,
- int buflen,
- const char *basedir,
- const char *basefile,
- char **dirs,
- unsigned int ndirs)
+char* vnc_display_best_path(const char *basedir,
+ const char *basefile,
+ char **dirs,
+ unsigned int ndirs)
{
unsigned int i;
+ char *path;
for (i = 0 ; i < ndirs ; i++) {
struct stat sb;
- snprintf(buf, buflen-1, "%s/%s/%s", dirs[i], basedir, basefile);
- buf[buflen-1] = '\0';
- if (stat(buf, &sb) == 0)
- return 0;
+ path = g_strdup_printf ("%s/%s/%s", dirs[i], basedir, basefile);
+ if (stat(path, &sb) == 0)
+ return path;
+ g_free (path);
}
- return -1;
+ return NULL;
}
static int vnc_display_set_x509_credential(VncDisplay *obj, const char *name)
{
- char file[PATH_MAX];
- char sysdir[PATH_MAX];
+ gboolean ret = FALSE;
+ char *file;
+ char *sysdir;
#ifndef WIN32
- char userdir[PATH_MAX];
+ char *userdir;
struct passwd *pw;
char *dirs[] = { sysdir, userdir };
#else
char *dirs[] = { sysdir };
#endif
- strncpy(sysdir, SYSCONFDIR "/pki", PATH_MAX-1);
- sysdir[PATH_MAX-1] = '\0';
-
#ifndef WIN32
if (!(pw = getpwuid(getuid())))
return TRUE;
- snprintf(userdir, PATH_MAX-1, "%s/.pki", pw->pw_dir);
- userdir[PATH_MAX-1] = '\0';
+ userdir = g_strdup_printf("%s/.pki", pw->pw_dir);
#endif
- if (vnc_display_best_path(file, PATH_MAX, "CA", "cacert.pem",
- dirs, sizeof(dirs)/sizeof(dirs[0])) < 0)
- return TRUE;
+ sysdir = g_strdup_printf("%s/pki", SYSCONFDIR);
+
+ if ((file = vnc_display_best_path("CA", "cacert.pem", dirs,
+ sizeof(dirs)/sizeof(dirs[0]))) == NULL) {
+ ret = TRUE;
+ goto ret;
+ }
gvnc_set_credential_x509_cacert(obj->priv->gvnc, file);
+ g_free (file);
/* Don't mind failures of CRL */
- if (vnc_display_best_path(file, PATH_MAX, "CA", "cacrl.pem",
- dirs, sizeof(dirs)/sizeof(dirs[0])) == 0)
+ if ((file = vnc_display_best_path("CA", "cacrl.pem", dirs,
+ sizeof(dirs)/sizeof(dirs[0]))) != NULL)
gvnc_set_credential_x509_cacert(obj->priv->gvnc, file);
+ g_free (file);
/* Set client key & cert if we have them. Server will reject auth
* if it decides it requires them*/
- if (vnc_display_best_path(file, PATH_MAX, name, "private/clientkey.pem",
- dirs, sizeof(dirs)/sizeof(dirs[0])) == 0)
+ if ((file = vnc_display_best_path(name, "private/clientkey.pem", dirs,
+ sizeof(dirs)/sizeof(dirs[0]))) != NULL)
gvnc_set_credential_x509_key(obj->priv->gvnc, file);
- if (vnc_display_best_path(file, PATH_MAX, name, "clientcert.pem",
- dirs, sizeof(dirs)/sizeof(dirs[0])) == 0)
+ g_free (file);
+ if ((file = vnc_display_best_path(name, "clientcert.pem", dirs,
+ sizeof(dirs)/sizeof(dirs[0]))) != NULL)
gvnc_set_credential_x509_cert(obj->priv->gvnc, file);
+ g_free (file);
- return FALSE;
+ ret:
+#ifndef WIN32
+ g_free (userdir);
+#endif
+ g_free (sysdir);
+ return ret;
}
gboolean vnc_display_set_credential(VncDisplay *obj, int type, const gchar *data)
--- End Message ---
--- Begin Message ---
Source: gtk-vnc
Source-Version: 0.3.10-3
We believe that the bug you reported is fixed in the latest version of
gtk-vnc, which is due to be installed in the Debian FTP archive:
gtk-vnc_0.3.10-3.diff.gz
to main/g/gtk-vnc/gtk-vnc_0.3.10-3.diff.gz
gtk-vnc_0.3.10-3.dsc
to main/g/gtk-vnc/gtk-vnc_0.3.10-3.dsc
gvncviewer_0.3.10-3_i386.deb
to main/g/gtk-vnc/gvncviewer_0.3.10-3_i386.deb
libgtk-vnc-1.0-0-dbg_0.3.10-3_i386.deb
to main/g/gtk-vnc/libgtk-vnc-1.0-0-dbg_0.3.10-3_i386.deb
libgtk-vnc-1.0-0_0.3.10-3_i386.deb
to main/g/gtk-vnc/libgtk-vnc-1.0-0_0.3.10-3_i386.deb
libgtk-vnc-1.0-dev_0.3.10-3_i386.deb
to main/g/gtk-vnc/libgtk-vnc-1.0-dev_0.3.10-3_i386.deb
mozilla-gtk-vnc_0.3.10-3_i386.deb
to main/g/gtk-vnc/mozilla-gtk-vnc_0.3.10-3_i386.deb
python-gtk-vnc_0.3.10-3_i386.deb
to main/g/gtk-vnc/python-gtk-vnc_0.3.10-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated gtk-vnc package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 28 Feb 2010 17:32:47 +0100
Source: gtk-vnc
Binary: libgtk-vnc-1.0-0 libgtk-vnc-1.0-0-dbg libgtk-vnc-1.0-dev python-gtk-vnc
mozilla-gtk-vnc gvncviewer
Architecture: source i386
Version: 0.3.10-3
Distribution: unstable
Urgency: low
Maintainer: Guido Günther <[email protected]>
Changed-By: Guido Günther <[email protected]>
Description:
gvncviewer - VNC viewer using gtk-vnc
libgtk-vnc-1.0-0 - A VNC viewer widget for GTK+ (runtime libraries)
libgtk-vnc-1.0-0-dbg - A VNC viewer widget for GTK+ (runtime libraries)
libgtk-vnc-1.0-dev - A VNC viewer widget for GTK+ (development files)
mozilla-gtk-vnc - A VNC viewer widget for GTK+ (mozilla plugin)
python-gtk-vnc - A VNC viewer widget for GTK+ (Python binding)
Closes: 544003 559128 561004 571490
Changes:
gtk-vnc (0.3.10-3) unstable; urgency=low
.
* [37978f9] Make package buildable with Python 2.6 (Closes: #571490) -
thanks to Jakub Wilk for the suggestions.
* [af58b98] Split build-deps to one package per line (Closes: #559128,
#544003)
* [31c8903] New patch 0004-Don-t-use-PATH_MAX.patch Don't use PATH_MAX
(Closes: #561004) - thanks to Emilio Pozuelo Monfort
Checksums-Sha1:
c48f3324ee8cc99b4c89441d1228be614f66fec8 1429 gtk-vnc_0.3.10-3.dsc
2847fd06cd5d98091d39ce3a564a90722478943d 10150 gtk-vnc_0.3.10-3.diff.gz
c03f8883a411933b6ebf2dbe7f077a62781ac54f 83108
libgtk-vnc-1.0-0_0.3.10-3_i386.deb
8b13b8ee6a05a399ff200b03aab607e8414cab18 139992
libgtk-vnc-1.0-0-dbg_0.3.10-3_i386.deb
9f1ba366e320f73cdb4b6c19b1f62ccd8caca968 85198
libgtk-vnc-1.0-dev_0.3.10-3_i386.deb
95224bca89a3765ce3b649f22b5b99edb7cb8a4a 30444 python-gtk-vnc_0.3.10-3_i386.deb
842298543e3902ed1ed134d0281188118c62ed78 32326
mozilla-gtk-vnc_0.3.10-3_i386.deb
9629188adde02d781e775466c5edf35cc9f31e8e 32162 gvncviewer_0.3.10-3_i386.deb
Checksums-Sha256:
0e1a4deca457b6742cfa45465b61883ec42ccac1aa46fdf4b5c56373795205f1 1429
gtk-vnc_0.3.10-3.dsc
603c6dda219b96da4741744c8f50f051f7f8c294d364a6030140d91551428d5c 10150
gtk-vnc_0.3.10-3.diff.gz
4a385131dae75d275c73202b0b908026235fbf05df212b0bc06b66f1295921db 83108
libgtk-vnc-1.0-0_0.3.10-3_i386.deb
207d88bfb4ecf3bced9da1ae7f416a16b3dbcdd3286994a9e9b493394a00203e 139992
libgtk-vnc-1.0-0-dbg_0.3.10-3_i386.deb
e6c988e53f8ef4c0fa24b5b3fddbcea038413ac9301b64f236eb09a838ddf655 85198
libgtk-vnc-1.0-dev_0.3.10-3_i386.deb
c4fd4ac826529fb9b416c28f7878b38c7a779f864c23b61ef7b13d25133aa967 30444
python-gtk-vnc_0.3.10-3_i386.deb
04d43c83d17c99c3bd6f3994f64c139119b7b734034614cdcda0ea5da3f36c56 32326
mozilla-gtk-vnc_0.3.10-3_i386.deb
4f65c1fcd56cbc6cf6f122495b786a25b226d38026a229d35778e193bdd13ffd 32162
gvncviewer_0.3.10-3_i386.deb
Files:
15711f767daf4cc93405707aa9d43852 1429 gnome optional gtk-vnc_0.3.10-3.dsc
04061f0965e9eef57ba96cc31b3a7c62 10150 gnome optional gtk-vnc_0.3.10-3.diff.gz
684ffd0a2c6722d2ecde18e49cca7de8 83108 libs optional
libgtk-vnc-1.0-0_0.3.10-3_i386.deb
9683bc961f7b2c0960c776801e5c618f 139992 debug extra
libgtk-vnc-1.0-0-dbg_0.3.10-3_i386.deb
b0bef8991730a048cfdef86e717c91dc 85198 libdevel optional
libgtk-vnc-1.0-dev_0.3.10-3_i386.deb
5ad7c431940d1d1bc11111758c256177 30444 python optional
python-gtk-vnc_0.3.10-3_i386.deb
7b3df3d0ccc17917b7c2c2dcf727a4dc 32326 web optional
mozilla-gtk-vnc_0.3.10-3_i386.deb
826a5b33c181539b99f4976496732283 32162 x11 optional
gvncviewer_0.3.10-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iD8DBQFLipzVn88szT8+ZCYRAuLIAJ9CdNif1IDRMLTJqURNFCFZS466swCePyL3
FIO7UT05wM3ZqB7ccRARiOo=
=vmei
-----END PGP SIGNATURE-----
--- End Message ---
