Your message dated Sun, 28 Mar 2010 16:16:35 +0200
with message-id <20100328141635.gb16...@rivendell>
and subject line Re: Bug#575697: dpkg-dev: [PATCH] Dpkg/Vendor.pm: Add starting 
=pod tags
has caused the Debian Bug report #575697,
regarding dpkg-dev: [PATCH] Dpkg/Vendor.pm: Add starting =pod tags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
575697: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575697
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dpkg-dev
Version: 1.15.5.6
Severity: wishlist
Tags: patch


The following patch adds missing starting '=pod' tags. The POD is
usually written in BEGIN..END style:

   =pod

   <content>

   =cut

This Git patch is against:

   git://git.debian.org/git/dpkg/dpkg.git bcdb8c9 2010-03-28

Reference: perlpod(1).

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dpkg-dev depends on:
ii  base-files        5.1                    Debian base system miscellaneous f
ii  binutils          2.20.1-2               The GNU assembler, linker and bina
ii  bzip2             1.0.5-4                high-quality block-sorting file co
ii  dpkg              1.15.5.6               Debian package management system
ii  libtimedate-perl  1.2000-1               collection of modules to manipulat
ii  lzma              4.43-14                Compression method of 7z format in
ii  make              3.81-7                 An utility for Directing compilati
ii  patch             2.6-2                  Apply a diff file to an original
ii  perl [perl5]      5.10.1-11              Larry Wall's Practical Extraction 
ii  perl-modules      5.10.1-11              Core Perl modules
ii  xz-utils          4.999.9beta+20091116-1 XZ-format compression utilities

Versions of packages dpkg-dev recommends:
ii  build-essential               11.4       Informational list of build-essent
ii  fakeroot                      1.14.4-1   Gives a fake root environment
ii  gcc [c-compiler]              4:4.4.2-3  The GNU C compiler
ii  gcc-4.1 [c-compiler]          4.1.2-27   The GNU C compiler
ii  gcc-4.3 [c-compiler]          4.3.4-6    The GNU C compiler
ii  gcc-4.4 [c-compiler]          4.4.2-9    The GNU C compiler
ii  gnupg                         1.4.10-2   GNU privacy guard - a free PGP rep
ii  gpgv                          1.4.10-2   GNU privacy guard - signature veri

Versions of packages dpkg-dev suggests:
ii  debian-keyring [debian-mainta 2009.11.04 GnuPG (and obsolete PGP) keys of D

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/perl5/Dpkg/Source/Patch.pm (from dpkg-dev 
package)
debsums: changed file /usr/share/perl5/Dpkg/Source/Package/V3/quilt.pm (from 
dpkg-dev package)
>From bcdb8c9ec772023136e909699749925ae615fe9a Mon Sep 17 00:00:00 2001
From: Jari Aalto <[email protected]>
Date: Sun, 28 Mar 2010 15:18:49 +0300
Subject: [PATCH] Dpkg/Vendor.pm: Add starting =pod tags (see perlpod)
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Jari Aalto <[email protected]>
---
 scripts/Dpkg/Vendor.pm |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/scripts/Dpkg/Vendor.pm b/scripts/Dpkg/Vendor.pm
index fb1d34f..7ff6e14 100644
--- a/scripts/Dpkg/Vendor.pm
+++ b/scripts/Dpkg/Vendor.pm
@@ -28,6 +28,8 @@ use base qw(Exporter);
 our @EXPORT_OK = qw(get_vendor_info get_current_vendor get_vendor_file
                     get_vendor_object run_vendor_hook);
 
+=pod
+
 =encoding utf8
 
 =head1 NAME
@@ -69,6 +71,8 @@ sub get_vendor_info(;$) {
     return $fields;
 }
 
+=pod
+
 =item $name = Dpkg::Vendor::get_vendor_file($name)
 
 Check if there's a file for the given vendor and returns its
@@ -108,6 +112,8 @@ sub get_current_vendor() {
     return undef;
 }
 
+=pod
+
 =item $object = Dpkg::Vendor::get_vendor_object($name)
 
 Return the Dpkg::Vendor::* object of the corresponding vendor.
@@ -137,6 +143,8 @@ sub get_vendor_object {
     return $obj;
 }
 
+=pod
+
 =item Dpkg::Vendor::run_vendor_hook($hookid, @params)
 
 Run a hook implemented by the current vendor object.
@@ -148,6 +156,8 @@ sub run_vendor_hook {
     $vendor_obj->run_hook(@_);
 }
 
+=pod
+
 =back
 
 =cut
-- 
1.7.0


--- End Message ---
--- Begin Message ---
Hi,

On Sun, 28 Mar 2010, Jari Aalto wrote:
> The following patch adds missing starting '=pod' tags. The POD is
> usually written in BEGIN..END style:

Ouch, do you really have nothing better to do with your time? :-)

Your patch modifies one file when there are dozens other which are
exactly like Vendor.pm, i.e. without useless =pod.

> Reference: perlpod(1).

Yes, read that better:

   A Pod block starts with any command paragraph, so a "=pod" command is
   usually used just when you want to start a Pod block with an ordinary
   paragraph or a verbatim paragraph.  For example:

     =item stuff()

     This function does stuff.

     =cut

     sub stuff {
       ...
     }

     =pod

     Remember to check its return value, as in:

       stuff() || die "Couldn't do stuff!";

     =cut

So, sorry, but I'm going to close this bug.

Cheers,
-- 
Raphaƫl Hertzog

Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/
My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/


--- End Message ---

Reply via email to