Your message dated Tue, 27 Apr 2010 18:38:20 +0200
with message-id <[email protected]>
and subject line Bug #561992: fixed in astyle 1.24-1
has caused the Debian Bug report #561992,
regarding [astyle] Linux style isn't the one used kernel
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
561992: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561992
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: astyle
Version: 1.23-1
Severity: normal

I wanted to use astyle to format my sources for the linux kernel. I noticed 
that it is really not what I would expect. For comparison use 
linux-2.6/scripts/Lindent.

I used `astyle --style=linux` for my tests which was described as "Also known 
as Kernel Normal Form (KNF) style, this is the style used in the Linux 
kernel."

First thing I noticed is that astyle uses 8 spaces for indention instead of a 
tab which should have a with of 8 spaces in an editor. Adding `--indent=tab=8` 
didn't help.

Also { after a function starts at the same line like the function header when 
the return type is a 'struct' like "struct list" - which isn't the style used 
in the kernel.

It doesn't look like 80 line width is used like in indent.

There are many other things I haven't completely understood yet. For example

Lindent:
if (NULL !=
    (val = xmlNodeGetContent(cur_node->children))) {
        used_val = 0;

astyle:
if (NULL !=
                (val = xmlNodeGetContent(cur_node->children))) {
        used_val = 0;


--- System information. ---
Architecture: amd64
Kernel:       Linux 2.6.31-1-amd64

Debian Release: squeeze/sid
  500 unstable        ftp.debian.org 

--- Package information. ---
Depends           (Version) | Installed
===========================-+-=============
libc6            (>= 2.2.5) | 2.10.2-2
libgcc1        (>= 1:4.1.1) | 1:4.4.2-6
libstdc++6       (>= 4.2.1) | 4.4.2-6

-- 
Robert Wohlrab



--- End Message ---
--- Begin Message ---
Version: 1.24-1

Hi!

This bug seems to be fixed in the new version 1.24. Feel free to re-open the 
bug if it does not work for you.

Matteo

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---

Reply via email to