Your message dated Sat, 27 Aug 2005 22:17:03 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#324461: fixed in cuetools 1.3-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 22 Aug 2005 08:42:15 +0000
>From [EMAIL PROTECTED] Mon Aug 22 01:42:15 2005
Return-path: <[EMAIL PROTECTED]>
Received: from ip212-226-168-228.adsl.kpnqwest.fi (esme.liw.iki.fi)
[212.226.168.228]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1E77sl-0007fE-00; Mon, 22 Aug 2005 01:42:15 -0700
Received: by esme.liw.iki.fi (Postfix, from userid 1000)
id 0F5E375C2B4; Mon, 22 Aug 2005 11:41:44 +0300 (EEST)
Subject: cuetools: "char c" not good enough for storing return value of
getopt_long
From: Lars Wirzenius <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Mon, 22 Aug 2005 11:41:44 +0300
Message-Id: <[EMAIL PROTECTED]>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.2
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Package: cuetools
Version: 1.3-1
>From the source:
char c;
while (-1 != (c = getopt_long(argc, argv, "hi:o:", longopts,
NULL))) {
A plain "char" type is not necessarily signed, and anyway can't contain
all the return values of getopt_long, i.e., can't contain all possible
char values *and* -1. Please change c to have type int instead.
---------------------------------------
Received: (at 324461-close) by bugs.debian.org; 28 Aug 2005 05:18:46 +0000
>From [EMAIL PROTECTED] Sat Aug 27 22:18:46 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1E9FXT-0000sy-00; Sat, 27 Aug 2005 22:17:03 -0700
From: Joshua Kwan <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#324461: fixed in cuetools 1.3-2
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 27 Aug 2005 22:17:03 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: cuetools
Source-Version: 1.3-2
We believe that the bug you reported is fixed in the latest version of
cuetools, which is due to be installed in the Debian FTP archive:
cuetools_1.3-2.diff.gz
to pool/main/c/cuetools/cuetools_1.3-2.diff.gz
cuetools_1.3-2.dsc
to pool/main/c/cuetools/cuetools_1.3-2.dsc
cuetools_1.3-2_i386.deb
to pool/main/c/cuetools/cuetools_1.3-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joshua Kwan <[EMAIL PROTECTED]> (supplier of updated cuetools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 27 Aug 2005 22:09:18 -0700
Source: cuetools
Binary: cuetools
Architecture: source i386
Version: 1.3-2
Distribution: unstable
Urgency: low
Maintainer: Joshua Kwan <[EMAIL PROTECTED]>
Changed-By: Joshua Kwan <[EMAIL PROTECTED]>
Description:
cuetools - tools for manipulating CUE/TOC files
Closes: 324461 324462 324977
Changes:
cuetools (1.3-2) unstable; urgency=low
.
* The "Overfiend" release, including the 'omnibus' 01_cuetools.dpatch by
Branden Robinson. His changelog follows. closes: #324977
.
* Make several fixes and enhancements to the cuebreakpoints, cueconvert, and
cueprint commands:
+ Fix them to use an int instead of a char to store the return value of
getopt_long(), so that the value is not truncated. closes: #324461
+ Enhance usage messages:
- Store the command synopsis in a static buffer.
- Report the command synopsis in error as well as "--help" conditions.
- Summarize the purpose of the command in the usage message.
- Note default behavior where applicable.
- Cross-reference manual page.
- Communicate in complete sentences more.
+ Standardize presentation of error messages. Always report the command
name and always say "error:" on error conditions.
+ Make some error message indicate what operation failed instead of
uttering amorphisms like "input file error".
+ Stop throwing away the value of the function that each program's main()
wraps. Instead, store it and use it as the command's exit value instead
of exiting with status zero no matter what went wrong.
+ Use strcasecmp() instead of strcmp() when attempting to parse file
format extensions, so that people pulling files from uppercase-happy
operating systems are less likely to be frustrated.
+ Add some braces in some places to prevent usage(1) from being called
whether or not the arguments have been successfully parsed or not.
closes: #324462
+ Add lots of comments.
- Document symbols required from #included system headers.
- Document the core logic of main().
- Add some TODO items with ideas that occurred to me.
+ Make style fixes:
- Kill extraneous whitespace at ends of lines.
- Wrap lines at 80 columns.
- Replace ugly multline string literals (with the newline escaped, or
GCC would have caught this) with a more idiomatic usage.
- Write function calls consistently.
- Use idiomatic multi-line comment style.
- Use complete sentences in non-TODO comments.
- Refer to argv[0] as argv[0] instead of *argv (idiom again).
.
* Make several fixes and enhancements to the cuebreakpoints, cueconvert, and
cueprint manual pages:
+ Fix .TH directive:
- Use the command's own name, not "cuetools".
- Add the date of last modification and the upstream source
distribution.
+ Fix the NAME section:
+ Move the command's short description here from the DESCRIPTION
section, so that whatis(1) and apropos(1) have a chance of finding
these
manual pages.
+ Fix the SYNOPSIS section to more usefully synopsize the command's
usage. "[ option ... ] [ file ... ]" is only appropriate for very
complex commands, in my opinion.
+ Move material from non-standard section names into the DESCRIPTION
section.
+ Move the DESCRIPTION section to precede the OPTIONS section.
+ Fix the items in the OPTIONS section so that they present correctly.
+ Add an EXIT STATUS section.
+ Fix markup of cross-references in SEE ALSO section.
+ Add myself to AUTHORS section, identifying what I did.
.
* Make several fixes to debian/rules:
+ Kill off trailing whitespace from lines in debian/rules.
+ Fix phony targets to only depend on stamp targets in debian/rules.
+ Add configure (phony) and configure-stamp targets to run ./configure,
and make the build target depend on it.
.
* Also bump Standards-Version to 3.6.2, no changes required.
* Add Build-Depends on dpatch for Branden's patch.
Files:
659bd7e0432333cbac1791b74fa4e8f6 1208 utils extra cuetools_1.3-2.dsc
4248da9f3c215419cbb3f12914a97848 10799 utils extra cuetools_1.3-2.diff.gz
520c188f47d4e2f495e375cb3972e327 78934 utils extra cuetools_1.3-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iQIVAwUBQxFHbKOILr94RG8mAQIHUBAAms/5WYNtC+Dn+70bAqlT2RZl6UJO0tTT
vx1N/oaE6u9QbZAZXT+Lqf524tLM2n7N16vwex04TMsD/+xr6CeG+Ixq0tqj6Yvk
U4GmzEpXWSjCChgnhXmEZlBeCWIM2Ml0CjxARI7+qolf2xsaxj5lSQzf3xbzsGXp
1PhZw1JLDJa4WY4NhmjinPcPiF541bFhKs1NMufYmYjnZ9faEhJL8dtyDrgBLgO9
pmDGMHGjydLrE/65ltK7gaNLEHqsM7NCyLdTH/p/JpFuaEQoqwty9AsZ0b1VzhKl
QCLT7Wx7iantVUZmmEtx2lj/ToV9qZIOwg6Up6OGZKfA0YhvHv+G5QLMSWFGPcXN
ISoQktH564Ps9mFgc42SRd1Bxf4Ar2VKr8m9l25J0wU/yFmBYYNpLqZRV6JEqrXB
s2p00CC0ccvd9m9hMchJnUAunlUQlG+8VddCXSVw7mzC9dbPVIOAMYzQj7jz1i1H
Z16pz4NpT1LxW8zzH9tD+aJKF9q6uox38DMuzhLhq7WCMrrYEF/Vk3OW5pcB+rcv
c9z23xbTFZl6aJyg1StwKpHNWwaahnauqTamxFn7xj4/69XtVwbrRF5U84HvZxeo
/e4jR1bActxpk3flwUtUF0xB6ZXFbOCluTlR0UsnDL8A/X5+5Kc8cyfJtMmFGwBR
A34uWs4h8Xo=
=2DIu
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
