Your message dated Sun, 28 Aug 2005 11:49:07 +0200
with message-id <[EMAIL PROTECTED]>
and subject line fixed wget #319088: off by one when parsing ftp listing.
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 19 Jul 2005 19:49:34 +0000
>From [EMAIL PROTECTED] Tue Jul 19 12:49:34 2005
Return-path: <[EMAIL PROTECTED]>
Received: from mail2.webmessenger.it (mail2a.webresidence.it) [193.70.193.55] 
        by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
        id 1Duy5u-0008WM-00; Tue, 19 Jul 2005 12:49:34 -0700
Received: from bohr.pisa.iol.it (193.76.233.84) by mail2a.webresidence.it 
(7.2.059.5) (authenticated as [EMAIL PROTECTED])
        id 42C23AC00000C701; Tue, 19 Jul 2005 21:49:02 +0200
Received: from giuseppe by bohr.pisa.iol.it with local (Exim 4.52)
        id 1Duy5N-0000Qn-RN; Tue, 19 Jul 2005 21:49:01 +0200
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: giuseppe bonacci <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: wget: off by one when parsing ftp listing.
X-Mailer: reportbug 3.15
Date: Tue, 19 Jul 2005 21:49:01 +0200
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02

Package: wget
Version: 1.10-3+1.10.1beta1
Severity: normal
Tags: patch


This might be related to bug #296760.

There's an off-by-one error in ftp_parse_unix_ls().

The result of the error is that shorter files are mirrored correctly,
while longer ones are found 0 bytes long on remote, and downloaded again
and again, disrupting mirroring.

I did not check ftp_parse_winnt_ls().

Please apply the following patch. 
Best regards.
G.B.

--- wget-1.10/src/ftp-ls.c.orig 2005-05-12 18:24:33.000000000 +0200
+++ wget-1.10/src/ftp-ls.c      2005-07-19 21:38:30.657076296 +0200
@@ -220,6 +220,10 @@
                  char *t = tok - 2;
                  while (t > line && ISDIGIT (*t))
                    --t;
+                 /* if the number is preceded by exactly one blank, the last
+                  * loop landed on '\0', and we must increment. 
+                  * Otherwise, means skipping a blank (harmless). */
+                 ++t;
                  if (t == line)
                    {
                      /* Something has gone wrong during parsing. */


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.8-2-686-smp
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages wget depends on:
ii  libc6                       2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libssl0.9.7                 0.9.7e-3     SSL shared libraries

wget recommends no packages.

-- no debconf information

---------------------------------------
Received: (at 319088-done) by bugs.debian.org; 28 Aug 2005 09:49:10 +0000
>From [EMAIL PROTECTED] Sun Aug 28 02:49:10 2005
Return-path: <[EMAIL PROTECTED]>
Received: from h02.hostsharing.net (pomo.hostsharing.net) [212.21.77.2] 
        by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
        id 1E9Jmo-00048g-00; Sun, 28 Aug 2005 02:49:10 -0700
Received: from localhost (dsl-082-083-244-026.arcor-ip.net [82.83.244.26])
        (using SSLv3 with cipher RC4-MD5 (128/128 bits))
        (No client certificate requested)
        by pomo.hostsharing.net (Postfix) with ESMTP id 7C4ECA03712
        for <[EMAIL PROTECTED]>; Sun, 28 Aug 2005 11:49:10 +0200 (CEST)
Subject: fixed wget #319088: off by one when parsing ftp listing.
From: =?ISO-8859-1?Q?No=E8l_K=F6the?= <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Content-Type: multipart/signed; micalg=pgp-sha1; 
protocol="application/pgp-signature"; boundary="=-n/t2a4rXG8v4sCuseFuQ"
Organization: Debian GNU/Linux, www.debian.org
Date: Sun, 28 Aug 2005 11:49:07 +0200
Message-Id: <[EMAIL PROTECTED]>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.3 
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
        RCVD_IN_DSBL autolearn=no version=2.60-bugs.debian.org_2005_01_02


--=-n/t2a4rXG8v4sCuseFuQ
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Package: wget
Version: 1.10.1-1

Hello,

thx for your report and your help in fixing this.
The problem is fixed in upstream 1.10.1.

--=20
No=C3=A8l K=C3=B6the <noel debian.org>

--=-n/t2a4rXG8v4sCuseFuQ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQBDEYiT9/DnDzB9Vu0RApaKAJ0RqYoN6xceFynpwz2YdnvmrKtIvwCghlB1
GtlDmJED5V4mQh+6Mn9y2O4=
=jjyJ
-----END PGP SIGNATURE-----

--=-n/t2a4rXG8v4sCuseFuQ--


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to