Your message dated Tue, 20 Jul 2010 22:49:34 +0400
with message-id <[email protected]>
and subject line Re: Bug#583184: libtk-img: please rebuild against tk 8.5 in
experimental
has caused the Debian Bug report #583184,
regarding libtk-img: please rebuild against tk 8.5 in experimental
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
583184: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=583184
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libtk-img
Version: 1:1.3-release-9
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: UpgradeDefaultTclTkTo85
Hi again,
Before updating tcltk-defaults in sid from version 8.4 to 8.5, it
would be nice to see what consequences that would have, by rebuilding
all relevant packages against the version in experimental.
This requires sourceful uploads to change build-deps to explicitly
request the version from experimental, as discussed on
debian-release[1]:
Build-Depends: tk-dev (>= 8.5)
To test the change, I tried running the test suite. This revealed
that the updated version indeed does run and produce output with
libtcl8.5 and wish8.6, which is good enough for experimental ;-).
Some unexpected results:
test ico/ico-1.1 produces an icon of the same length but with a
lot more /’s than it should have (and some other differences).
test png/png-1.1:
catch {image delete i}
image create photo i -file [file join $tcltest::testsDirectory folder.png]
i data -format png
---- Result was:
iVBORw0KGgoAAAANSUhEUgAAABAAAAAMCAIAAAGTgppAAAAABGdBTUEAAYagMeiWXwAAAHxJ
REFUKJGVUMERgDAIC54D+HMDmanbuI0zxQ38uYE+uALW66N5UUISqJCE4X52ACBZS2umPkCS
pPjAdZYJCUJy3Q57LLK7vURChdEfeWulqh4dRLa6zhJEE+B0N2OcEFtGVXNYvrQV9JwauH7G
76f+WCQGurv2MCwYvuEFQANGc3uOMFYAAAAASUVORK5CYII=
---- Result should have been (exact matching):
iVBORw0KGgoAAAANSUhEUgAAABAAAAAMCAIAAAGTgppAAAAABGdBTUEAAYagMeiWXwAAAHxJ
REFUeJyVUMERgDAIC54D+HMDmanbuI0zxQ38uYE+uALW66N5UUISqJCE4X52ACBZS2umPkCS
pPjAdZYJCUJy3Q57LLK7vURChdEfeWulqh4dRLa6zhJEE+B0N2OcEFtGVXNYvrQV9JwauH7G
76f+WCQGurv2MCwYvuEFQANGc1+HFcEAAAAASUVORK5CYII=
==== png-1.1 FAILED
(Notice the REFUeJy... instead of REFUKJGV... on line 2.)
test png/png-1.2, png/png-1.3, and png/png-1.4 reproduce the same
failure as png/png-1.1.
sgi/sgi-1.1:
catch {image delete i}
image create photo i -file [file join $tcltest::testsDirectory folder.rgb]
i data -format sgi
---- Result was:
AdoBAQADABAADAADAAAAAAAAAP8AAAAAbm8gbmFtZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
mGawCQEAAQAAAAAAAgAAAAAAAAAAAAAAALmrCQAAAABPBAAAoLarCWi4qwkAAAAAAAAAAAAA
[...]
---- Result should have been (exact matching):
AdoBAQADABAADAADAAAAAAAAAP8AAAAAbm8gbmFtZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
4FASCAEAAQAAAAAAAgAAAAAAAAAAAAAAOBkSCAAAAABPBAAACBgSCKAYEggAAAAAAAAAAAAA
[...]
(Again, the differences occur early, and the rest is fine.)
sgi/sgi-1.2:
catch {image delete i}
image create photo i -data $sgidata
set data [i data -format sgi]
---- Result was:
AdoBAQADABAADAADAAAAAAAAAP8AAAAAbm8gbmFtZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
WGiwCQEAAQAAAAAAAgAAAAAAAAAAAAAAkLqrCQAAAABPBAAASLmrCfi5qwkAAAAAAAAAAAAA
[...]
---- Result should have been (exact matching):
[as before]
sgi/sgi-1.3:
i blank
i put $data
set data [i data -format sgi]
---- Result was:
AdoBAQADABAADAADAAAAAAAAAP8AAAAAbm8gbmFtZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
2GiwCQEAAQAAAAAAAgAAAAAAAAAAAAAAILyrCQAAAABPBAAA2LqrCYi7qwkAAAAAAAAAAAAA
[...]
---- Result should have been (exact matching):
[as before]
sgi/sgi-1.4:
i blank
i put $data -format sgi
set data [i data -format sgi]
---- Result was:
AdoBAQADABAADAADAAAAAAAAAP8AAAAAbm8gbmFtZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
GGmwCQEAAQAAAAAAAgAAAAAAAAAAAAAAsL2rCQAAAABPBAAAaLyrCRi9qwkAAAAAAAAAAAAA
[...]
---- Result should have been (exact matching):
[as before]
The rest of the tests passed. I haven’t tried testing against
tcl 8.4, but thought you might like to know.
[1] http://lists.debian.org/debian-release/2010/03/msg00303.html
$ uname -r
2.6.34-1-686
$ dpkg -l tcl\* tk\* libpng\* zlib1\* linux-image-2.6.34-1-686 libc6 | grep ^i
ii libc6 2.11-0exp4 Embedded GNU C Libra
ii libpng12-0 1.2.43-1 PNG library - runtim
ii libpng12-dev 1.2.43-1 PNG library - develo
ii linux-image-2.6.34-1-686 2.6.34-1~experimental.1
ii tcl 8.5.0-1 The Tool Command Lan
ii tcl-dev 8.5.0-1 The Tool Command Lan
ii tcl8.5 8.5.8-2 Tcl (the Tool Comman
ii tcl8.5-dev 8.5.8-2 Tcl (the Tool Comman
ii tcl8.6 8.6.0~b1-3 Tcl (the Tool Comman
ii tk 8.5.0-1 The Tk toolkit for T
ii tk-dev 8.5.0-1 The Tk toolkit for T
ii tk8.5 8.5.8-1 Tk toolkit for Tcl a
ii tk8.5-dev 8.5.8-1 Tk toolkit for Tcl a
ii tk8.6 8.6.0~b1-2 Tk toolkit for Tcl a
ii zlib1g 1:1.2.5.dfsg-1 compression library
ii zlib1g-dev 1:1.2.5.dfsg-1 compression library
debian/changelog | 6 ++++++
debian/control | 2 +-
2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index e0bdd40..2b0d9b7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+libtk-img (1:1.3-release-10) experimental; urgency=low
+
+ * Rebuilt against tk-dev (>= 8.5).
+
+ -- Jonathan Nieder <[email protected]> Tue, 25 May 2010 23:34:23 -0500
+
libtk-img (1:1.3-release-9) unstable; urgency=low
* Changed libjpeg62-dev to libjpeg-dev in build dependencies.
diff --git a/debian/control b/debian/control
index 2e3dbec..54c8bbd 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,7 @@ Source: libtk-img
Section: libs
Priority: optional
Maintainer: Sergei Golovan <[email protected]>
-Build-Depends: debhelper (>= 5.0.0), tk-dev (>= 8.4.0), zlib1g-dev (>=
1:1.2.1), libjpeg-dev, libtiff4-dev, libpng12-dev, quilt
+Build-Depends: debhelper (>= 5.0.0), tk-dev (>= 8.5), zlib1g-dev (>= 1:1.2.1),
libjpeg-dev, libtiff4-dev, libpng12-dev, quilt
Standards-Version: 3.8.4
Homepage: http://sourceforge.net/projects/tkimg/
--
1.7.1
--- End Message ---
--- Begin Message ---
On Wed, May 26, 2010 at 9:04 AM, Jonathan Nieder <[email protected]> wrote:
>
> Hi again,
Hi Jonatan!
>
> To test the change, I tried running the test suite. This revealed
> that the updated version indeed does run and produce output with
> libtcl8.5 and wish8.6, which is good enough for experimental ;-).
> Some unexpected results:
I've finally found the tine to run the test suite on Tcl/Tk 8.4 and it
reveals exactly the same test failures. Moreover, I did compare
the images which differ and they appeared exactly the same visually
(I just saved them in the GIMP as XPM and compared using diff).
So, I'm closing the bug as libtk-img indeed works fine on Tk 8.5
(I'm using it daily myself and it almost never crashed, except for
a few GIFs but those bugs are already fixed).
Cheers!
--
Sergei Golovan
--- End Message ---
