Your message dated Wed, 18 Aug 2010 14:35:39 +0000
with message-id <[email protected]>
and subject line Bug#593476: fixed in eblook 1:1.6.1-9
has caused the Debian Bug report #593476,
regarding eblook: incompatible pointer type, 'ssize_t *' vs 'int *'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
593476: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593476
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: eblook
Version: 1:1.6.1-8
Severity: important
Tags: upstream patch

The amd64 buildd log seems that argument 4 of 'eb_read_rawtext' and
argument 7 of 'eb_read_text' are problematic on 64bit environments,
suggested by Kazuhiro Ito.

<https://buildd.debian.org/fetch.cgi?pkg=eblook;ver=1%3A1.6.1-8;arch=amd64;stamp=1281842571>
| eblook.c: In function 'command_pbm':
| eblook.c:1187: warning: passing argument 4 of 'eb_read_rawtext' from 
incompatible pointer type
| /usr/include/eb/text.h:144: note: expected 'ssize_t *' but argument is of 
type 'int *'
| eblook.c: In function 'command_xbm':
| eblook.c:1262: warning: passing argument 4 of 'eb_read_rawtext' from 
incompatible pointer type
| /usr/include/eb/text.h:144: note: expected 'ssize_t *' but argument is of 
type 'int *'
| eblook.c: In function 'process_child':
| eblook.c:3109: warning: passing argument 7 of 'eb_read_text' from 
incompatible pointer type
| /usr/include/eb/text.h:138: note: expected 'ssize_t *' but argument is of 
type 'int *'
| eblook.c: In function 'show_candidate':
| eblook.c:3186: warning: passing argument 7 of 'eb_read_text' from 
incompatible pointer type
| /usr/include/eb/text.h:138: note: expected 'ssize_t *' but argument is of 
type 'int *'

The attached patch fixes this bug.

Thanks,
--
Tatsuya Kinoshita
Description: Fix incompatible pointer type for eb_read_* functions
Author: Kazuhiro Ito <[email protected]>, Tatsuya Kinoshita <[email protected]>

diff -urN eblook-1.6.1.orig/eblook.c eblook-1.6.1/eblook.c
--- eblook-1.6.1.orig/eblook.c	2004-06-18 01:09:01.000000000 +0900
+++ eblook-1.6.1/eblook.c	2010-08-18 00:02:36.000000000 +0900
@@ -1166,7 +1166,7 @@
 {
     static unsigned char buffer[MAX_BITMAP_SIZE];
     EB_Position pos;
-    int len;
+    ssize_t len;
     int ret;
     int i;
     int j;
@@ -1241,7 +1241,7 @@
 {
     static unsigned char buffer[MAX_BITMAP_SIZE];
     EB_Position pos;
-    int len;
+    ssize_t len;
     int ret;
     int i;
     int j;
@@ -3097,7 +3097,7 @@
 {
     EB_Error_Code error_code;
     char buf[2048];
-    int buflen;
+    ssize_t buflen;
 
 #if MULTI_DEBUG
     xprintf(">> seeking %d:%d\n", can->child_pos.page, can->child_pos.offset);
@@ -3109,7 +3109,7 @@
     error_code = eb_read_text(book, 0, &multi_candidate_hookset, NULL, 2047, buf, &buflen);
 #if MULTI_DEBUG
     xprintf(">> eb_read_text %s\n", eb_error_message(error_code));
-    xprintf(">> buflen = %d\n", buflen);
+    xprintf(">> buflen = %ld\n", (long)buflen);
     xprintf(">> ]\n");
 #endif
 
@@ -3168,7 +3168,7 @@
     EB_Position pos0;
 {
     char buf[2048];
-    int buflen;
+    ssize_t buflen;
     struct multi_can *child, *ptail;
     EB_Error_Code error_code = EB_SUCCESS;
 
@@ -3191,7 +3191,7 @@
 	return 0;
     }
 #if MULTI_DEBUG
-    xprintf(">> buflen = %d\n", buflen);
+    xprintf(">> buflen = %ld\n", (long)buflen);
 #endif
 
     tail->terminated = 1;

Attachment: pgpEKf6p15NlZ.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: eblook
Source-Version: 1:1.6.1-9

We believe that the bug you reported is fixed in the latest version of
eblook, which is due to be installed in the Debian FTP archive:

eblook_1.6.1-9.debian.tar.gz
  to main/e/eblook/eblook_1.6.1-9.debian.tar.gz
eblook_1.6.1-9.dsc
  to main/e/eblook/eblook_1.6.1-9.dsc
eblook_1.6.1-9_i386.deb
  to main/e/eblook/eblook_1.6.1-9_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tatsuya Kinoshita <[email protected]> (supplier of updated eblook package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 18 Aug 2010 23:15:43 +0900
Source: eblook
Binary: eblook
Architecture: source i386
Version: 1:1.6.1-9
Distribution: unstable
Urgency: medium
Maintainer: Tatsuya Kinoshita <[email protected]>
Changed-By: Tatsuya Kinoshita <[email protected]>
Description: 
 eblook     - electronic dictionary search command using EB Library
Closes: 593476
Changes: 
 eblook (1:1.6.1-9) unstable; urgency=medium
 .
   * debian/patches/40_eb-read-ssize.patch: Patch to fix incompatible pointer
     type ('ssize_t *' vs 'int *') for eb_read_* functions. (closes: #593476)
Checksums-Sha1: 
 7bcd9b61d9627ca0cf241caff405fea469be05d6 1044 eblook_1.6.1-9.dsc
 344c8b5a9f4046d83ad02497b73007d7b3216ca6 25030 eblook_1.6.1-9.debian.tar.gz
 939b0293119273c46b32f9443e753179e411d3e2 47098 eblook_1.6.1-9_i386.deb
Checksums-Sha256: 
 49b64e514ac0fb3c92f2aedca4c7e864841273f0295b13dd6bef07b8d1b3dd54 1044 
eblook_1.6.1-9.dsc
 71188fad964d6f618d6da60cc62bc28afdc3a1837e8b203b5810642166dd9f8d 25030 
eblook_1.6.1-9.debian.tar.gz
 6f969e475f2b77f2d7d255abc21601e80961c711808de6b4f1398d5cd8695cd9 47098 
eblook_1.6.1-9_i386.deb
Files: 
 8a2fa34475cad4966d002b0cdf929b98 1044 text optional eblook_1.6.1-9.dsc
 7c6513c6e888af8726557ef38374e726 25030 text optional 
eblook_1.6.1-9.debian.tar.gz
 977aef70b27f2b40919145613b412dbe 47098 text optional eblook_1.6.1-9_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxr7HIACgkQgV4LPvpMUpjSpwCfQxpEEEeAfN0x/ASpbTikAxNo
VAMAoLtODnlsC+MOFQk2+Dm0/jJIjFNs
=YEBx
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to