Your message dated Wed, 01 Sep 2010 13:04:19 +0000
with message-id <[email protected]>
and subject line Bug#595034: fixed in ruby1.8 1.8.7.302-2
has caused the Debian Bug report #595034,
regarding ruby1.8: puppet problem on the kFreeBSD ports
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
595034: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=595034
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ruby1.8
Version: 1.8.7.302-1
Severity: important
Tags: patch
X-Debbugs-CC: [email protected], [email protected]
User: [email protected]
Usertags: kfreebsd
Hi,
this is follow up to thread started by
http://lists.debian.org/debian-bsd/2010/08/msg00062.html
With my DSA hat on I have to say that I'm not entirely happy with what
we have so far.
The biggest pain for us currently is that puppet just does not work
reliably on kfreebsd (both i386 and amd64). This may be a ruby bug, but
it's still really, really annoying.
Aurelien have been so kind and performed some tests of proposed patches,
results are bellow. Please apply attached rb18.diff.
It have two parts
- in process.c (re-)start timer thread (after_exec) only in parent,
as in child we know for sure that there is only one thread.
The fix-up in child is performed slightly later in rb_thread_atfork().
Also unify linux with rest of the systems.
In 1.9 series the code is completely reworked.
- in signal.c use pthread_sigmask instead of sigprocmask,
behaviour of sigprocmask is undefined in threaded programs.
In 1.9 series the code already uses pthread_sigmask.
I am unsure whether severity should be important or serious.
Thanks
Petr
On Tue, 31 Aug 2010, Aurelien Jarno wrote:
Hi Petr,
I have finally found time to do the tests, here are the results:
* 1.8.7.302-1 (sid)
=> buggy
* 1.8.7.302-1 + rb18.diff
=> works
* 1.8.7.302-1 + rb18.diff + disabled 100730_disable_getsetcontext_on_nptl in
series
=> works
* 1.8.7.302-1 + rb18.diff + rb18-extra.diff
=> works
* 1.8.7.302-1 + rb18.diff + rb18-extra.diff + disabled
100730_disable_getsetcontext_on_nptl in series
=> works
So it seems rb18.diff is enough to fix the issues. Not sure it's a
proper patch to be submitted, but I have switch the 4 GNU/kFreeBSD build
daemons to this version.
Don't hesitate if you need more tests, I will try to be faster this
time.
Cheers,
Aurelien
--
Aurelien Jarno GPG: 1024D/F1BCDB73
[email protected] http://www.aurel32.net
--- ruby1.8-1.8.7.299.orig/process.c
+++ ruby1.8-1.8.7.299/process.c
@@ -1332,13 +1332,11 @@
before_exec();
pid = fork();
- after_exec();
+ if (pid != 0)
+ after_exec();
switch (pid) {
case 0:
-#ifdef linux
- after_exec();
-#endif
rb_thread_atfork();
if (rb_block_given_p()) {
int status;
--- ruby1.8-1.8.7.299.orig/signal.c
+++ ruby1.8-1.8.7.299/signal.c
@@ -21,6 +21,7 @@
#undef SIGBUS
#endif
+#define sigprocmask pthread_sigmask
#if defined HAVE_SIGPROCMASK || defined HAVE_SIGSETMASK
#define USE_TRAP_MASK 1
#else
--- End Message ---
--- Begin Message ---
Source: ruby1.8
Source-Version: 1.8.7.302-2
We believe that the bug you reported is fixed in the latest version of
ruby1.8, which is due to be installed in the Debian FTP archive:
libruby1.8-dbg_1.8.7.302-2_amd64.deb
to main/r/ruby1.8/libruby1.8-dbg_1.8.7.302-2_amd64.deb
libruby1.8_1.8.7.302-2_amd64.deb
to main/r/ruby1.8/libruby1.8_1.8.7.302-2_amd64.deb
libtcltk-ruby1.8_1.8.7.302-2_amd64.deb
to main/r/ruby1.8/libtcltk-ruby1.8_1.8.7.302-2_amd64.deb
ri1.8_1.8.7.302-2_all.deb
to main/r/ruby1.8/ri1.8_1.8.7.302-2_all.deb
ruby1.8-dev_1.8.7.302-2_amd64.deb
to main/r/ruby1.8/ruby1.8-dev_1.8.7.302-2_amd64.deb
ruby1.8-elisp_1.8.7.302-2_all.deb
to main/r/ruby1.8/ruby1.8-elisp_1.8.7.302-2_all.deb
ruby1.8-examples_1.8.7.302-2_all.deb
to main/r/ruby1.8/ruby1.8-examples_1.8.7.302-2_all.deb
ruby1.8_1.8.7.302-2.diff.gz
to main/r/ruby1.8/ruby1.8_1.8.7.302-2.diff.gz
ruby1.8_1.8.7.302-2.dsc
to main/r/ruby1.8/ruby1.8_1.8.7.302-2.dsc
ruby1.8_1.8.7.302-2_amd64.deb
to main/r/ruby1.8/ruby1.8_1.8.7.302-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lucas Nussbaum <[email protected]> (supplier of updated ruby1.8 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 01 Sep 2010 12:08:48 +0200
Source: ruby1.8
Binary: ruby1.8 libruby1.8 libruby1.8-dbg ruby1.8-dev libtcltk-ruby1.8
ruby1.8-examples ruby1.8-elisp ri1.8
Architecture: source all amd64
Version: 1.8.7.302-2
Distribution: unstable
Urgency: high
Maintainer: akira yamada <[email protected]>
Changed-By: Lucas Nussbaum <[email protected]>
Description:
libruby1.8 - Libraries necessary to run Ruby 1.8
libruby1.8-dbg - Debugging symbols for Ruby 1.8
libtcltk-ruby1.8 - Tcl/Tk interface for Ruby 1.8
ri1.8 - Ruby Interactive reference (for Ruby 1.8)
ruby1.8 - Interpreter of object-oriented scripting language Ruby 1.8
ruby1.8-dev - Header files for compiling extension modules for the Ruby 1.8
ruby1.8-elisp - ruby-mode for Emacsen
ruby1.8-examples - Examples for Ruby 1.8
Closes: 595034
Changes:
ruby1.8 (1.8.7.302-2) unstable; urgency=high
.
* Add debian/patches/100901_threading_fixes.patch. Fixes threading
problems on Debian GNU/kFreeBSD exhibited by puppet.
Thanks to Petr Salinger and Aurélien Jarno. Closes: #595034
Checksums-Sha1:
a9565e6e75813af05d132eed5c08c0233df87d58 1513 ruby1.8_1.8.7.302-2.dsc
1272f72ed64c4313029a2beb51ef0fbdaba8a3d0 48464 ruby1.8_1.8.7.302-2.diff.gz
ffda46fec3a8fcf270000ac8953ef17e43d50956 337048
ruby1.8-examples_1.8.7.302-2_all.deb
cdc25407ad842864a66ba4fb7bd29ec853a77e49 296084
ruby1.8-elisp_1.8.7.302-2_all.deb
62dcbbd5e5e346856fe091f63c8168cc8c482c2f 1424732 ri1.8_1.8.7.302-2_all.deb
a5bf45d85d730b91608964fe354d3d3f9291f589 310094 ruby1.8_1.8.7.302-2_amd64.deb
28bb4489d5a3e3fa17c6b18f50fb4880cd446ee6 2061110
libruby1.8_1.8.7.302-2_amd64.deb
0ec9017f2d47f3d12392d9f7fc525d557316202a 1506790
libruby1.8-dbg_1.8.7.302-2_amd64.deb
73f23ce485501b797b510a610941d36880bb458d 886232
ruby1.8-dev_1.8.7.302-2_amd64.deb
b5bc88c20a83c40c453d3496f946b07913075cc9 2025578
libtcltk-ruby1.8_1.8.7.302-2_amd64.deb
Checksums-Sha256:
51cbc94e5366041121ac102766a8443dcd681534f8878e468142408af904475a 1513
ruby1.8_1.8.7.302-2.dsc
d39dadf081b9b15a2b729af0715fbc6fc35a8b3c3015fd621eb04f8263be50a0 48464
ruby1.8_1.8.7.302-2.diff.gz
f6db9570590d5aec92a371ddb3db0f1c0601b56ac47ab28e8c4b3d7fb54c3e5c 337048
ruby1.8-examples_1.8.7.302-2_all.deb
a3d4b182057bf963b2ff061ea8dd2d63b84ec94826d9ecf3ceaea73b6dede2b1 296084
ruby1.8-elisp_1.8.7.302-2_all.deb
961153c3c1035ca6b28ca119719ee45ad1adffa3470eb28e290805d415099a9c 1424732
ri1.8_1.8.7.302-2_all.deb
682e4133c9e73d0e177d71e9976c3d107e4ad8fee93e1604e34e5767bf801c8c 310094
ruby1.8_1.8.7.302-2_amd64.deb
23065f26e713da93f5ff8d32b5b7b12fdc80133f6a1f95afd0b3dfa21b8c898a 2061110
libruby1.8_1.8.7.302-2_amd64.deb
970b08f9718106654b450ed8572d8ff9854a96430e4a984872d707f69dbcd9c6 1506790
libruby1.8-dbg_1.8.7.302-2_amd64.deb
eddba5a3126a63d77df652221a882c3a9e73280168590305fa0272e7d30b4a1b 886232
ruby1.8-dev_1.8.7.302-2_amd64.deb
e75bc2e5c97c0d544b1c099ac4193affbb7f6268aa1e3ffd4df424033703023e 2025578
libtcltk-ruby1.8_1.8.7.302-2_amd64.deb
Files:
941a5517ad55628f085c5a2a410de30a 1513 ruby optional ruby1.8_1.8.7.302-2.dsc
6103894580252185beb2fb7213c903d4 48464 ruby optional
ruby1.8_1.8.7.302-2.diff.gz
32060d5fca8e0d11d4fc7e866c5e9a86 337048 ruby optional
ruby1.8-examples_1.8.7.302-2_all.deb
914fe49e71c59d4a730e1b7c40d141d2 296084 ruby optional
ruby1.8-elisp_1.8.7.302-2_all.deb
987453f0afd69a077f7d4d8136f9edc0 1424732 ruby optional
ri1.8_1.8.7.302-2_all.deb
129beada231163a15338b0bfcbfe3648 310094 ruby optional
ruby1.8_1.8.7.302-2_amd64.deb
9732a878ad818b46cdbd6b2af2c78628 2061110 libs optional
libruby1.8_1.8.7.302-2_amd64.deb
731b9d355c06026409de75b8f80b97e9 1506790 debug extra
libruby1.8-dbg_1.8.7.302-2_amd64.deb
7d61724a442bd04725a9902bd0500e10 886232 ruby optional
ruby1.8-dev_1.8.7.302-2_amd64.deb
6c8a5a4558ccb17e7ae20619433b8116 2025578 ruby optional
libtcltk-ruby1.8_1.8.7.302-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iD8DBQFMfktO2hliNwI7P08RAowvAJ0ZnjAnAZPCpj2GOesAw7CA4j/+4ACdEc0+
daIE2LPe/GjUh/kfe/md6bc=
=FE1Z
-----END PGP SIGNATURE-----
--- End Message ---
