Your message dated Fri, 3 Sep 2010 11:42:51 -0700
with message-id <[email protected]>
and subject line Bug#595406: ltspfsd-core: cdpinger doesn't work well with USB
CDROM drives
has caused the Debian Bug report #595406,
regarding ltspfsd-core: cdpinger doesn't work well with USB CDROM drives
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
595406: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=595406
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ltspfsd-core
Version: 0.6-1
Severity: important
Tags: patch
cdpinger doesn't appear to properly die when the USB CDROM drive is removed,
leaving running cdpinger processes which lead to spurious mount and unmount
calls to the non-existant CDROM drive.
the following patch from upstream should resolve the issue, by calling cdpinger
with the real device name rather than the symlinked device name:
144 Gideon Romm 2010-05-11
revision-id:[email protected]
Remove commented-out code.
143 Gideon Romm 2010-05-11
revision-id:[email protected]
Fix cdrom handling.
=== modified file 'scripts/ltspfs_entry'
--- scripts/ltspfs_entry 2010-02-11 03:08:21 +0000
+++ scripts/ltspfs_entry 2010-05-11 14:53:37 +0000
@@ -130,19 +130,14 @@
}
call_cdpinger(){
- if [ ! -e /var/run/cdpinger.$1.pid ] && [ -z $(pgrep -f -l -x
"/usr/sbin/cdpinger $1") ]; then
+ if [ -z $(pgrep -f -l -x "/usr/sbin/cdpinger $1") ]; then
/usr/sbin/cdpinger $1 &
- echo $! > /var/run/cdpinger.$1.pid
return 0
fi
}
kill_cdpinger(){
- if [ -e /var/run/cdpinger.$1.pid ]; then
- pid=$(cat /var/run/cdpinger.$1.pid)
- [ -n "$pid" ] && kill -9 $pid 2>/dev/null
- rm -f /var/run/cdpinger.$1.pid 2>/dev/null
- fi
+ pkill -f -x "/usr/sbin/cdpinger $1"
}
verify_device() {
@@ -218,18 +213,8 @@
DEVICENAME="$1"
# handle CDROM devices, which do not produce udev add/remove events
if [ "${ID_TYPE}" = "cd" ]; then
- cd_device="$DEVICENAME"
- for link in $($udevinfo -q symlink -n ${DEVICENAME}) ; do
- case $link in
- cdrom*)
- cd_device="$link"
- break
- ;;
- esac
- done
-
# started new cdpinger, which will handle the rest
- call_cdpinger $cd_device
+ call_cdpinger ${DEVICENAME}
exit 0
fi
}
@@ -238,22 +223,20 @@
DEVICENAME="$1"
# handle CDROM devices, which do not produce udev add/remove events
if [ "${ID_TYPE}" = "cd" ]; then
- cd_device="$DEVICENAME"
- for link in $($udevinfo -q symlink -n ${DEVICENAME}) ; do
- case $link in
- cdrom*)
- cd_device="$link"
- break
- ;;
- esac
- done
- kill_cdpinger $cd_device
- exit 0
+ kill_cdpinger ${DEVICENAME}
fi
}
add_device() {
DEVICENAME="$1"
+ for link in $($udevinfo -q symlink -n ${DEVICENAME}) ; do
+ case $link in
+ cdrom*)
+ LABEL="$link"
+ break
+ ;;
+ esac
+ done
case $DEVICENAME in
fd*)
--- End Message ---
--- Begin Message ---
Version: 0.7-1
this is fixed in upstream version 0.7, which is currently in experimental.
live well,
vagrant
--- End Message ---
