Your message dated Sun, 12 Sep 2010 07:47:07 +0000
with message-id <[email protected]>
and subject line Bug#596327: fixed in dosfstools 3.0.10-1
has caused the Debian Bug report #596327,
regarding dosfsck: false positives in bad_name() when running in interactive
mode
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
596327: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596327
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dosfstools
Version: 3.0.6-1
Severity: important
Tags: patch
dosfsck in interactive mode complains about bad file name when it finds
a direntry with 7 or more characters with codes > 127. This is wrong:
filenames containing such characters are valid (at least in MSDOS,
Windows and Linux), but they can be interpreted differently depending
on the local codepage (CP437, CP866, etc.)
Another problem is a misleading error message: dosfsck thinks that short
filename is wrong, but shows a long filename.
Patches are attached.
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.33.2 (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages dosfstools depends on:
ii libc6 2.10.1-5 GNU C Library: Shared libraries
dosfstools recommends no packages.
dosfstools suggests no packages.
-- debconf-show failed
commit 8577de60c50c774cf12b2c4311e2cfce67e13bd2
Author: Alexander Korolkov <[email protected]>
Date: Sun Sep 5 16:57:21 2010 +0400
dosfsck: don't complain about bad filenames when short filename contains 7 or more characters with codes 128-255
diff --git a/src/check.c b/src/check.c
index 01f34ab..8da13c5 100644
--- a/src/check.c
+++ b/src/check.c
@@ -339,11 +339,10 @@ static int bad_name(DOS_FILE *file)
if (atari_format && suspicious)
return 1;
- /* Only complain about too much suspicious chars in interactive mode,
- * never correct them automatically. The chars are all basically ok, so we
- * shouldn't auto-correct such names. */
- if (interactive && suspicious > 6)
- return 1;
+ /* Under MS-DOS and Windows, chars >= 128 in short names are valid
+ * (but these characters can be visualised differently depending on
+ * local codepage: CP437, CP866, etc). The chars are all basically ok,
+ * so we shouldn't auto-correct such names. */
return 0;
}
commit 1db5fc9a4c39103c6d7297714b3ac08e8c861741
Author: Alexander Korolkov <[email protected]>
Date: Sun Sep 5 17:15:15 2010 +0400
If the test of short filename fails, dosfsck could complain about bad long
filename
diff --git a/src/check.c b/src/check.c
index 0378da5..2a71b1b 100644
--- a/src/check.c
+++ b/src/check.c
@@ -629,7 +629,8 @@ static int check_dir(DOS_FS *fs,DOS_FILE **root,int dots)
}
if (!((*walk)->dir_ent.attr & ATTR_VOLUME) &&
bad_name(*walk)) {
- printf("%s\n Bad file name.\n",path_name(*walk));
+ puts(path_name(*walk));
+ printf(" Bad short file name (%s).\n",
file_name((*walk)->dir_ent.name));
if (interactive)
printf("1) Drop file\n2) Rename file\n3) Auto-rename\n"
"4) Keep it\n");
--- End Message ---
--- Begin Message ---
Source: dosfstools
Source-Version: 3.0.10-1
We believe that the bug you reported is fixed in the latest version of
dosfstools, which is due to be installed in the Debian FTP archive:
dosfstools-dbg_3.0.10-1_i386.deb
to main/d/dosfstools/dosfstools-dbg_3.0.10-1_i386.deb
dosfstools_3.0.10-1.diff.gz
to main/d/dosfstools/dosfstools_3.0.10-1.diff.gz
dosfstools_3.0.10-1.dsc
to main/d/dosfstools/dosfstools_3.0.10-1.dsc
dosfstools_3.0.10-1_i386.deb
to main/d/dosfstools/dosfstools_3.0.10-1_i386.deb
dosfstools_3.0.10.orig.tar.gz
to main/d/dosfstools/dosfstools_3.0.10.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated dosfstools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 12 Sep 2010 09:39:52 +0200
Source: dosfstools
Binary: dosfstools dosfstools-dbg
Architecture: source i386
Version: 3.0.10-1
Distribution: experimental
Urgency: low
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Description:
dosfstools - utilities for making and checking MS-DOS FAT filesystems
dosfstools-dbg - utilities for making and checking MS-DOS FAT filesystems
(debug)
Closes: 596327 596329
Changes:
dosfstools (3.0.10-1) experimental; urgency=low
.
* Updating standards version to 3.9.0.
* Merging upstream version 3.0.10:
- Fixes problem in dosfsck with false positives in bad_name() when running
in interactive mode (Closes: #596327).
- Updates LFN when renaming or deleting short filename (Closes: #596329).
* Updating standards version to 3.9.1.
Checksums-Sha1:
b9e740f1964993476c171ac29538a9a5d8b4b0a0 1257 dosfstools_3.0.10-1.dsc
97b2612f5e773be433c897c408a669b9ca198233 81744 dosfstools_3.0.10.orig.tar.gz
6ddcdbef209a32a42e0ad98725157e6662f2a680 8154 dosfstools_3.0.10-1.diff.gz
71cb7a56b960c0cc96bd12ca260ffbedb54dfc63 91118 dosfstools_3.0.10-1_i386.deb
628db00d1f66c9af7541ffb08a988474afee8062 85856 dosfstools-dbg_3.0.10-1_i386.deb
Checksums-Sha256:
2235d97ca61c92c238db7e4257e86551b84557724c0a7d9952f04eee2153177c 1257
dosfstools_3.0.10-1.dsc
89e793ac5cdc1d8fdbab1fd54a77f64b3fa102403d7cd37492484163f1d9e9b5 81744
dosfstools_3.0.10.orig.tar.gz
b41c96e12ebc615fc8120a63304d8fb54a3c4385466a711a816ec9a71bc17021 8154
dosfstools_3.0.10-1.diff.gz
3453f5c069a404032f9f38150d90f55d4cb9383138b576ee4115f4c1b56e7d90 91118
dosfstools_3.0.10-1_i386.deb
bf5bb24eeb7346c73ef7a1815485f29ad2605579eaa40ee670e1e2f318623c86 85856
dosfstools-dbg_3.0.10-1_i386.deb
Files:
33382d4f1e6da7328ff2c01de0a13429 1257 otherosfs optional
dosfstools_3.0.10-1.dsc
6cf73f9bdde8ffa6b81d33423ddbe490 81744 otherosfs optional
dosfstools_3.0.10.orig.tar.gz
4e13c5945199b9a025a7ffd85888946a 8154 otherosfs optional
dosfstools_3.0.10-1.diff.gz
d7eaec93f386a5936154fae277db44a5 91118 otherosfs optional
dosfstools_3.0.10-1_i386.deb
929a45abc26f58804e24567ebf241a04 85856 debug extra
dosfstools-dbg_3.0.10-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkyMhGUACgkQ+C5cwEsrK56ElgCgmx6ov51J3gT1rqvBeKQt+tCp
hHAAoKJanNkXFhOVYNits1gwprdNdDZN
=pPYX
-----END PGP SIGNATURE-----
--- End Message ---
