Your message dated Sun, 24 Oct 2010 19:32:48 +0000
with message-id <[email protected]>
and subject line Bug#571565: fixed in sbuild 0.60.1-1
has caused the Debian Bug report #571565,
regarding AptitudeBuildDepSatisfier: gracefully handle the case when default 
negative dep is not available
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
571565: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=571565
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libsbuild-perl
Version: 0.60.0-1
Severity: normal
File: /usr/share/perl5/Sbuild/AptitudeBuildDepSatisfier.pm
Tags: patch


Hello,

AptitudeBuildDepSatisfier does not gracefully handle the case when default
negative dep is not available (e.g. package has versioned Breaks on a package
that is actually a virtual package in the archive). A very simple patch for
this problem is below:

>From 1552240163a4fce19a98b4e189511c136107345e Mon Sep 17 00:00:00 2001
From: Modestas Vainius <[email protected]>
Date: Fri, 26 Feb 2010 03:05:12 +0200
Subject: [PATCH] AptitudeBuildDepSatisfier: gracefully handle the case when 
default negative dep is not available

If default version of the negative dependency is not available, just do not 
check
non-default versions. Current code had undefined behaviour because this
condition resulted into perl undefined value errors like:

Complete deps: libc6 (>= 2.3), libgcc1 (>= 1:4.1.1), libstdc++6 (>= 4.1.1)
Use of uninitialized value $v1 in string eq at /usr/share/perl5/Sbuild.pm line 
104.
Use of uninitialized value $vers in pattern match (m//) at 
/usr/share/perl5/Sbuild.pm line 202.
Use of uninitialized value $vers in pattern match (m//) at 
/usr/share/perl5/Sbuild.pm line 207.
Use of uninitialized value $default_version in concatenation (.) or string at 
/usr/share/perl5/Sbuild/AptitudeBuildDepSatisfier.pm line 284.
Can't use libplasma-dev (<< 4:4.1.96), but default version is
... couldn't find pkg to satisfy !libplasma-dev (<< 4:4.1.96)

libplasma-dev is a virtual package while a package declared a negative
versioned dependency against it.

diff --git a/lib/Sbuild/AptitudeBuildDepSatisfier.pm 
b/lib/Sbuild/AptitudeBuildDepSatisfier.pm
index eb23725..eb3cfa0 100644
--- a/lib/Sbuild/AptitudeBuildDepSatisfier.pm
+++ b/lib/Sbuild/AptitudeBuildDepSatisfier.pm
@@ -280,7 +280,7 @@ sub get_non_default_deps {
        #Check if the package default version is not high enough:
        } elsif (defined($rel) && $rel && 
                (  (!$neg && !version_compare($default_version, $rel, 
$requested_version))
-                ||( $neg &&  version_compare($default_version, $rel, 
$requested_version)))) {
+                ||( $neg && defined $default_version && 
version_compare($default_version, $rel, $requested_version)))) {
            if (!$neg) {
                $builder->log("Need $name ($rel $requested_version), but 
default version is $default_version\n");
            } else {


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-2-amd64 (SMP w/1 CPU core)
Locale: LANG=lt_LT.UTF-8, LC_CTYPE=lt_LT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libsbuild-perl depends on:
ii  adduser                       3.112      add and remove users and groups
ii  apt                           0.7.25.3   Advanced front-end for dpkg
ii  dctrl-tools                   2.14       Command-line tools to process Debi
ii  devscripts                    2.10.61    scripts to make the life of a Debi
ii  dpkg-dev                      1.15.5.6   Debian package development tools
ii  exim4                         4.71-3     metapackage to ease Exim MTA (v4) 
ii  exim4-daemon-light [mail-tran 4.71-3     lightweight Exim MTA (v4) daemon
ii  libfilesys-df-perl            0.92-3+b1  Module to obtain filesystem disk s
ii  perl                          5.10.1-11  Larry Wall's Practical Extraction 
ii  perl-modules                  5.10.1-11  Core Perl modules
ii  schroot                       1.4.1-2    Execute commands in a chroot envir

libsbuild-perl recommends no packages.

libsbuild-perl suggests no packages.

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: sbuild
Source-Version: 0.60.1-1

We believe that the bug you reported is fixed in the latest version of
sbuild, which is due to be installed in the Debian FTP archive:

buildd_0.60.1-1_all.deb
  to main/s/sbuild/buildd_0.60.1-1_all.deb
libsbuild-perl_0.60.1-1_all.deb
  to main/s/sbuild/libsbuild-perl_0.60.1-1_all.deb
sbuild_0.60.1-1.diff.gz
  to main/s/sbuild/sbuild_0.60.1-1.diff.gz
sbuild_0.60.1-1.dsc
  to main/s/sbuild/sbuild_0.60.1-1.dsc
sbuild_0.60.1-1_all.deb
  to main/s/sbuild/sbuild_0.60.1-1_all.deb
sbuild_0.60.1.orig.tar.gz
  to main/s/sbuild/sbuild_0.60.1.orig.tar.gz
wanna-build_0.60.1-1_all.deb
  to main/s/sbuild/wanna-build_0.60.1-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Roger Leigh <[email protected]> (supplier of updated sbuild package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Format: 1.8
Date: Sun, 24 Oct 2010 19:56:34 +0100
Source: sbuild
Binary: libsbuild-perl sbuild wanna-build buildd
Architecture: source all
Version: 0.60.1-1
Distribution: unstable
Urgency: low
Maintainer: Debian buildd-tools Developers 
<[email protected]>
Changed-By: Roger Leigh <[email protected]>
Description: 
 buildd     - Daemon for automatically building Debian binary packages from Deb
 libsbuild-perl - Tool for building Debian binary packages from Debian sources
 sbuild     - Tool for building Debian binary packages from Debian sources
 wanna-build - Database to track building of Debian binary packages from Debian
Closes: 559533 570463 571565 571726 588818 591620
Changes: 
 sbuild (0.60.1-1) unstable; urgency=low
 .
   * New release.
   * debian/control:
     - Upgrade to Standards-Version 3.9.1.
   * sbuild:
     - Add --no-source option (Closes: #571726).  Thanks to David
       Bremner for this suggestion.
     - Hint aptitude to produce better solutions in AptitudeBuildDepSatisfier.
       Thanks to Modestas Vainius.  (Closes: #570463)
     - AptitudeBuildDepSatisfier: Handle the case when default negative dep is
       not available gracefully.  Thanks to Modestas Vainius.
       (Closes: #571565).
     - Improve support for aptitude.
     - Set DEBIAN_FRONTEND=noninteractive when using aptitude
       (Closes: #588818).
     - Improve dpkg-source v3 source format handling.  Don't hard-code
       assumptions about how the source files are named
       (Closes: #559533).
     - Remove conflict with schroot from oldstable.
   * buildd:
     - Retry the current suite if --take fails.  (Closes: #570463)
   * buildd-uploader:
     - Don't remove the uploader lock if not already the owner
       Closes: #591620).  Thanks to Sebastian Andrzej Siewior.
   * libsbuild-perl:
     - depend on schroot 1.4.0 or greater due to sbuild-createchroot
       creating schroot.conf fragments with 1.4.x-specific features.
Checksums-Sha1: 
 ae9d51e330142a39247479acbdbdb058f13b5fa9 1265 sbuild_0.60.1-1.dsc
 4538c6e1ceb6aea759deb8b51276b785f24ea7cc 494103 sbuild_0.60.1.orig.tar.gz
 a0fddd5458378c1bf3c10dd2f5c060d1347741ed 20 sbuild_0.60.1-1.diff.gz
 397dc82150fc1e79aa0722055f3d278710b44ea7 215552 libsbuild-perl_0.60.1-1_all.deb
 55e67f90c7830a502644acd5d38e16fb151c8ecf 217686 sbuild_0.60.1-1_all.deb
 81153c5d81fa62075684d8ab922e34d9a682c074 219630 wanna-build_0.60.1-1_all.deb
 a98356d404a06d96d2033f7adcc1f05bcce633be 211324 buildd_0.60.1-1_all.deb
Checksums-Sha256: 
 5cf38964c38317f71c01ae2edc9da8e0600ef12e70d4c97d1842a8f107192c45 1265 
sbuild_0.60.1-1.dsc
 600cbf7bf95bf447f3cd1bcc822954ef58b791f18e9187ec8c7a7a9dc3af8dc3 494103 
sbuild_0.60.1.orig.tar.gz
 f61f27bd17de546264aa58f40f3aafaac7021e0ef69c17f6b1b4cd7664a037ec 20 
sbuild_0.60.1-1.diff.gz
 381153071b5ef1102dc767ca37df0819a5c261cec8aa94089e470d51b050e75e 215552 
libsbuild-perl_0.60.1-1_all.deb
 33e9f6ee15c15835f5c97f2f2443aa4289d5356a9ba7bda211a8efd40a0833b2 217686 
sbuild_0.60.1-1_all.deb
 fb3bcec20ec451a1cfdc59a1b2165e850cf9ea925004a90a9ebde4512ed3ef35 219630 
wanna-build_0.60.1-1_all.deb
 3c00050a117042b5dbbc4e25e9df90d1fa63f1bd9cb6dfe7d3eea617006f3ef0 211324 
buildd_0.60.1-1_all.deb
Files: 
 964cfca1726f14f1552997b18dc8b4ab 1265 devel extra sbuild_0.60.1-1.dsc
 501a55b79d0beff79f8a2c65343c7afc 494103 devel extra sbuild_0.60.1.orig.tar.gz
 4a4dd3598707603b3f76a2378a4504aa 20 devel extra sbuild_0.60.1-1.diff.gz
 8f9f0050404cec1edcdf4b6e550dcd4b 215552 perl extra 
libsbuild-perl_0.60.1-1_all.deb
 29bcad4875f35c870b6d8cfd5a1e9f9c 217686 devel extra sbuild_0.60.1-1_all.deb
 4a1602e16afd2a4541cd9fc6e27c03e7 219630 devel extra 
wanna-build_0.60.1-1_all.deb
 7ba599e45ce85aec060a02e169155789 211324 devel extra buildd_0.60.1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEUEAREDAAYFAkzEhmUACgkQVcFcaSW/uEimPACYyUddg2iR/NHMRZXw2CGug34B
+ACfa401+sLsrFtplCkDQtX5jWKg+XA=
=hZTb
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to