Your message dated Sun, 28 Nov 2010 11:22:43 -0600
with message-id <20101128172243.ga19...@burratino>
and subject line Re: gitweb: should open files (e.g. indextext.html) in utf8 
mode
has caused the Debian Bug report #487465,
regarding gitweb: should open files (e.g. indextext.html) in utf8 mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
487465: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=487465
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gitweb
Version: 1:1.5.5.1-1
Severity: normal
Tags: patch

Subject says it all.  In the current code, gitweb uses utf8 only in stdout.
As a result, included files like indextext.html appears garbled if it
contains utf8 characters.  The attached patch works fine without any
observed side-effects.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (600, 'unstable'), (500, 'testing'), (450, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core)
Locale: LANG=tr_TR.UTF-8, LC_CTYPE=tr_TR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gitweb depends on:
ii  git-core                     1:1.5.5.1-1 fast, scalable, distributed revisi
ii  perl                         5.10.0-10   Larry Wall's Practical Extraction 

gitweb recommends no packages.

-- no debconf information

-- 
roktas
--- /usr/lib/cgi-bin/gitweb.cgi.orig	2008-06-22 00:51:53.000000000 +0000
+++ /usr/lib/cgi-bin/gitweb.cgi	2008-06-22 00:52:07.000000000 +0000
@@ -16,7 +16,7 @@
 use Fcntl ':mode';
 use File::Find qw();
 use File::Basename qw(basename);
-binmode STDOUT, ':utf8';
+use open qw(:std :utf8);
 
 BEGIN {
 	CGI->compile() if $ENV{'MOD_PERL'};

--- End Message ---
--- Begin Message ---
Version: 1:1.6.1.2-1

Recai Oktaş wrote:

> Subject says it all.  In the current code, gitweb uses utf8 only in stdout.
> As a result, included files like indextext.html appears garbled if it
> contains utf8 characters.  The attached patch works fine without any
> observed side-effects.

Thanks!  Eventually something involving to_utf8 was used instead;
see v1.6.1-rc2~11^2 (gitweb: Fix handling of non-ASCII characters in
inserted HTML files, 2008-12-01).

Hopefully it works.


--- End Message ---

Reply via email to