Your message dated Fri, 03 Dec 2010 15:17:06 +0000
with message-id <[email protected]>
and subject line Bug#605687: fixed in hobbit-plugins 20101203
has caused the Debian Bug report #605687,
regarding hobbit-plugins: ext/apt should check all update stamp files, not just
the first one found
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
605687: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=605687
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: hobbit-plugins
Version: 20100527
Severity: minor
Tags: Patch
We regularily run into cases where one of the earlier files in
@stamp_files do exist, but are older than the ones which really say when
the last update has been made. I always have to patch ext/apt or remove
the older file to get that false positive fixed. (The two files are
mostly /var/lib/aptitude/pkgstates and
/var/lib/apt/periodic/update-stamp in our case.)
I therefore suggest to use not the first file found but the newest of
those files.
Here's a proposed patch for that change:
--- /usr/lib/hobbit/client/ext/apt.orig 2010-12-02 12:35:12.000000000 +0100
+++ /usr/lib/hobbit/client/ext/apt 2010-12-02 12:54:09.000000000 +0100
@@ -124,14 +124,17 @@
#
# stamp files in order of decreasing usefulness
my @stamp_files = qw(/var/lib/aptitude/pkgstates
/var/lib/apt/periodic/update-stamp /var/lib/apt/extended_states
/var/lib/apt/update_success /var/lib/apt/lists/lock);
-my $last_update;
+my $last_update = 'never';
foreach my $stamp_file (@stamp_files) {
- $last_update = -M $stamp_file;
- last if $last_update;
+ my $last_update_tmp = -M $stamp_file;
+ if ($last_update_tmp and
+ ($last_update eq 'never' or $last_update_tmp < $last_update)) {
+ $last_update = $last_update_tmp;
+ }
}
my $updatecolor;
-if ($last_update >= 7) {
+if ($last_update eq 'never' or $last_update >= 7) {
$updatecolor = 'red';
} elsif ($last_update >= 1.5) {
$updatecolor = 'yellow';
@@ -159,6 +162,8 @@
pkgreport('Pinned packages not installed from apt repositories', 'green',
@no_repo_pinned);
$bb->print("\n");
-$bb->color_line($updatecolor, sprintf("Last apt update: %.1f day(s) ago\n",
$last_update));
+$bb->color_line($updatecolor, "Last apt update: ".
+ ($last_update eq 'never' ? 'never' :
+ sprintf("%.1f day(s) ago\n", $last_update)));
$bb->send;
Other (or perhaps additional) options would be: Let the local admin
configure the list of relevant update stamps for the machine.
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: kfreebsd-i386 (i686)
Kernel: kFreeBSD 8.1-1-686
Locale: LANG=en_US.iso885915, LC_CTYPE=en_US.iso885915 (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash
Versions of packages hobbit-plugins depends on:
ii hobbit-client 4.3.0~beta2.dfsg-6 dummy package for transitioning fr
ii xymon-client [hobbit- 4.3.0~beta2.dfsg-6 client for the Xymon network monit
Versions of packages hobbit-plugins recommends:
pn libsysadm-install-perl <none> (no description available)
pn lsof <none> (no description available)
Versions of packages hobbit-plugins suggests:
ii fping 2.4b2-to-ipv6-16.1 sends ICMP ECHO_REQUEST packets to
pn ipmitool <none> (no description available)
pn libdbd-pg-perl <none> (no description available)
pn libnet-irc-perl <none> (no description available)
ii ntp 1:4.2.6.p2+dfsg-1+b1 Network Time Protocol daemon and u
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: hobbit-plugins
Source-Version: 20101203
We believe that the bug you reported is fixed in the latest version of
hobbit-plugins, which is due to be installed in the Debian FTP archive:
hobbit-plugins_20101203.dsc
to main/h/hobbit-plugins/hobbit-plugins_20101203.dsc
hobbit-plugins_20101203.tar.gz
to main/h/hobbit-plugins/hobbit-plugins_20101203.tar.gz
hobbit-plugins_20101203_all.deb
to main/h/hobbit-plugins/hobbit-plugins_20101203_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Axel Beckert <[email protected]> (supplier of updated hobbit-plugins package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 03 Dec 2010 15:58:44 +0100
Source: hobbit-plugins
Binary: hobbit-plugins
Architecture: source all
Version: 20101203
Distribution: experimental
Urgency: low
Maintainer: Christoph Berg <[email protected]>
Changed-By: Axel Beckert <[email protected]>
Description:
hobbit-plugins - plugins for the Xymon network monitor
Closes: 487331 524016 526894 605687
Changes:
hobbit-plugins (20101203) experimental; urgency=low
.
* Add myself to Uploaders.
* apt: Overhaul "last apt update" determining
+ Split up the list of update stamp files into two groups to reduce
the amount of "Last apt update" false positives:
- Files where each file indicates a successful update, just not
necessarily the newest one. Check all of them and use the newest
of them. (Closes: #605687)
- Files which are less exact indicators. Check them in order and
just use the first one found as before.
+ Check mtime of /var/cache/apt/pkgcache.bin, /var/lib/apt/lists/partial
and /var/lib/apt/lists before checking the mtime of
/var/lib/apt/lists/lock. (Closes: #526894)
+ Add patch by Emil Larsson for not-in-repo package whitelist
(/etc/hobbit/apt_alien_accepts) as well as a rejected packages
blacklist (/etc/hobbit/apt_rejects). (Closes: #487331)
* ircbot: Forward-port nick-highlighting patch by Christian Herzog from
ISG D-PHYS, ETH Zurich (Closes: #524016)
* ircbot: Optionally use privmsg instead of notice for green and clear
messages (set IRC_GREEN_PRIVMSG to 1)
* Bump Standards-Version to 3.9.1 (no changes)
* Switch to source format "3.0 (native)"
Checksums-Sha1:
9fbe0468f92de90b2e1e3bf367e4f0a5518caff5 972 hobbit-plugins_20101203.dsc
c90a00afbe155767d0237499c79cc16b586a5709 22303 hobbit-plugins_20101203.tar.gz
d8008288638915944ded017a9f783bc1a851d6cc 27380 hobbit-plugins_20101203_all.deb
Checksums-Sha256:
8094e454ac77da3bf0d0854e6792062f9698d5e1ee1079fbc01f4c298a9348df 972
hobbit-plugins_20101203.dsc
3673a57d291bca0ac829786c9abe7fe100472f5b7454f9ee8ff5c0b9c18fd3d8 22303
hobbit-plugins_20101203.tar.gz
4a84a01b51038ea291293d61fa6a8f1bae1051ae5eaedf1c5c3703c2da806b55 27380
hobbit-plugins_20101203_all.deb
Files:
c30f49c2bf7ec40a4dca9981ba45e742 972 net extra hobbit-plugins_20101203.dsc
6cbf4ee597fcc625214cc8ae33df3272 22303 net extra hobbit-plugins_20101203.tar.gz
8793645b701cd3b237eaec4f721aa4b1 27380 net extra
hobbit-plugins_20101203_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkz5Bs4ACgkQwJ4diZWTDt7EFgCeKazC2TZgsFdsyr76NwWSBuZU
/EEAnjkHjE37Aet3lqnLwfE0gB4LZi3C
=svz0
-----END PGP SIGNATURE-----
--- End Message ---
