Your message dated Sun, 12 Dec 2010 13:02:16 +0000
with message-id <[email protected]>
and subject line Bug#602367: fixed in tp-smapi 0.40-9
has caused the Debian Bug report #602367,
regarding tp-smapi-source: Cannot compile tp-smapi-module with Linux 2.6.37-rc1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
602367: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602367
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tp-smapi-source
Version: 0.40-8
Severity: normal
Hi!
I tried to build tp-smapi-module for Linux 2.6.37-rc1, but gave error below.
--
CC [M] /usr/src/modules/tp-smapi/thinkpad_ec.o
/usr/src/modules/tp-smapi/thinkpad_ec.c:91: warning: type defaults to
'int' in declaration of 'DECLARE_MUTEX'
/usr/src/modules/tp-smapi/thinkpad_ec.c:91: warning: parameter names
(without types) in function declaration
/usr/src/modules/tp-smapi/thinkpad_ec.c: In function 'thinkpad_ec_lock':
/usr/src/modules/tp-smapi/thinkpad_ec.c:108: error:
'thinkpad_ec_mutex' undeclared (first use in this function)
/usr/src/modules/tp-smapi/thinkpad_ec.c:108: error: (Each undeclared
identifier is reported only once
/usr/src/modules/tp-smapi/thinkpad_ec.c:108: error: for each function
it appears in.)
/usr/src/modules/tp-smapi/thinkpad_ec.c: In function 'thinkpad_ec_try_lock':
/usr/src/modules/tp-smapi/thinkpad_ec.c:122: error:
'thinkpad_ec_mutex' undeclared (first use in this function)
/usr/src/modules/tp-smapi/thinkpad_ec.c: In function 'thinkpad_ec_unlock':
/usr/src/modules/tp-smapi/thinkpad_ec.c:134: error:
'thinkpad_ec_mutex' undeclared (first use in this function)
--
'DECLARE_MUTEX' has been removed since next commit.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4882720b267b7b1d1b0ce08334b205f0329d4615
I apply the below patch. It worksforme.
--
diff --git a/thinkpad_ec.c b/thinkpad_ec.c
--- a/thinkpad_ec.c
+++ b/thinkpad_ec.c
@@ -88,7 +88,11 @@ static u64 prefetch_jiffies;
#define TPC_PREFETCH_JUNK (INITIAL_JIFFIES+1) /* Ignore prefetch */
/* Locking: */
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37)
static DECLARE_MUTEX(thinkpad_ec_mutex);
+#else
+static DEFINE_SEMAPHORE(thinkpad_ec_mutex);
+#endif
/* Kludge in case the ACPI DSDT reserves the ports we need. */
static int force_io; /* Willing to do IO to ports we couldn't reserve? */
diff --git a/tp_smapi.c b/tp_smapi.c
--- a/tp_smapi.c
+++ b/tp_smapi.c
@@ -109,7 +109,11 @@ static struct { u8 rc; char *msg; int re
#define SMAPI_PORT2 0x4F /* fixed port, meaning unclear */
static unsigned short smapi_port; /* APM control port, normally 0xB2 */
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37)
static DECLARE_MUTEX(smapi_mutex);
+#else
+static DEFINE_SEMAPHORE(smapi_mutex);
+#endif
/**
* find_smapi_port - read SMAPI port from NVRAM
--
Regards.
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.37-rc1 (SMP w/1 CPU core; PREEMPT)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages tp-smapi-source depends on:
ii debhelper 8.0.0 helper programs for debian/rules
ii module-assistant 0.11.3 tool to make module package creati
tp-smapi-source recommends no packages.
Versions of packages tp-smapi-source suggests:
ii sysfsutils 2.1.0+repack-1 sysfs query tool and boot-time set
-- no debconf information
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.37-rc1 (SMP w/1 CPU core; PREEMPT)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages tp-smapi-source depends on:
ii debhelper 8.0.0 helper programs for debian/rules
ii module-assistant 0.11.3 tool to make module package creati
tp-smapi-source recommends no packages.
Versions of packages tp-smapi-source suggests:
ii sysfsutils 2.1.0+repack-1 sysfs query tool and boot-time set
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: tp-smapi
Source-Version: 0.40-9
We believe that the bug you reported is fixed in the latest version of
tp-smapi, which is due to be installed in the Debian FTP archive:
tp-smapi-dkms_0.40-9_all.deb
to main/t/tp-smapi/tp-smapi-dkms_0.40-9_all.deb
tp-smapi-source_0.40-9_all.deb
to main/t/tp-smapi/tp-smapi-source_0.40-9_all.deb
tp-smapi_0.40-9.diff.gz
to main/t/tp-smapi/tp-smapi_0.40-9.diff.gz
tp-smapi_0.40-9.dsc
to main/t/tp-smapi/tp-smapi_0.40-9.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Evgeni Golov <[email protected]> (supplier of updated tp-smapi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 12 Dec 2010 13:44:06 +0100
Source: tp-smapi
Binary: tp-smapi-source tp-smapi-dkms
Architecture: source all
Version: 0.40-9
Distribution: unstable
Urgency: low
Maintainer: Evgeni Golov <[email protected]>
Changed-By: Evgeni Golov <[email protected]>
Description:
tp-smapi-dkms - ThinkPad hardware/firmware access modules source - dkms version
tp-smapi-source - ThinkPad hardware/firmware access modules source
Closes: 602367
Changes:
tp-smapi (0.40-9) unstable; urgency=low
.
* debian/patches/03_2.6.37-compatibility.patch:
+ Use DEFINE_SEMAPHORE instead of DECLARE_MUTEX in 2.6.37 and above.
Closes: #602367
Thanks: Tanaka Watanabe <[email protected]>
Checksums-Sha1:
c60e94c4c0d921441a075a946d7ed8192d449dca 1169 tp-smapi_0.40-9.dsc
41229577a5866cd61a031340214ea3897f956bad 8012 tp-smapi_0.40-9.diff.gz
461c068aac3af9187c3d7b1889196e5972a2434c 59064 tp-smapi-source_0.40-9_all.deb
f71f14518cfc807a735e1eb48a73b7d943dd487b 45394 tp-smapi-dkms_0.40-9_all.deb
Checksums-Sha256:
f50c30956bde823a2534c2850c0ed3346fc934ca2a114ff76108fb0191df43bf 1169
tp-smapi_0.40-9.dsc
7634c0a0d0f201a6173e1a5ce6a07f5018711fff7411f2cbcac4a7043adceac6 8012
tp-smapi_0.40-9.diff.gz
fe014565d558ef8f5071396ef7eb687dc68a2c0ebf4008ca6f21b05d71ebb4bb 59064
tp-smapi-source_0.40-9_all.deb
115f53092cc9e256576f11f90a42098f5d502b40d12d95e241b2998d123f03d9 45394
tp-smapi-dkms_0.40-9_all.deb
Files:
a2d1ef698da94baa1145a9e1528cebd7 1169 kernel optional tp-smapi_0.40-9.dsc
b926b9f53728e07bd08f2cd5230701b7 8012 kernel optional tp-smapi_0.40-9.diff.gz
be5bcb9eee01f8deca516e466e1b9114 59064 kernel optional
tp-smapi-source_0.40-9_all.deb
14a630b106dff981b6662922b0db332e 45394 kernel optional
tp-smapi-dkms_0.40-9_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAk0ExTEACgkQJKAUGKwVtQz98QCePhOyxir10id+sdANoHubtdPm
xbcAn3AGNxQfThW2gbgSLa4q+17pYql4
=bRIJ
-----END PGP SIGNATURE-----
--- End Message ---
