Your message dated Tue, 13 Sep 2005 13:01:29 +0200
with message-id <[EMAIL PROTECTED]>
and subject line dhcp3-client: request user-defined options doesn't work
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Jul 2003 11:08:53 +0000
>From [EMAIL PROTECTED] Mon Jul 21 06:08:33 2003
Return-path: <[EMAIL PROTECTED]>
Received: from walker.svs.informatik.uni-oldenburg.de (walker.pmhahn.de)
[134.106.22.19]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 19eYWu-0001im-00; Mon, 21 Jul 2003 06:08:32 -0500
Received: by walker.pmhahn.de (Postfix, from userid 1000)
id 9DF7D17643; Mon, 21 Jul 2003 12:52:35 +0200 (CEST)
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="UTF-8"
From: Philipp Matthias Hahn <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: dhcp3-client: request user-defined options doesn't work
X-Mailer: reportbug 2.19
Date: Mon, 21 Jul 2003 12:52:35 +0200
X-Debbugs-Cc: [EMAIL PROTECTED]
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Status: No, hits=-9.0 required=4.0
tests=BAYES_10,HAS_PACKAGE,X_DEBBUGS_CC
version=2.53-bugs.debian.org_2003_07_20
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_07_20
(1.174.2.15-2003-03-30-exp)
Package: dhcp3-client
Version: 3.0+3.0.1rc11-5
Severity: normal
Tags: patch upstream
FAI (fully automatic installation) would like to defines user options in
/etc/dhcp3/dhclient.conf and use them to determine what action to take.
At the moment, this doesn't work because of a bug in dhcp3-client. If
you add the lines
option fai-action code 171 = text;
request fai-action;
you get an error that 'fai-action' is not a valid option.
What goes wrong is this:
common/tables.c:1178 dhcp_universe.options [i] = &dhcp_options [i];
The dhcp_universe gets initialized by referencing the options
from the dhcp_options array.
client/clparse.c:377 option = parse_option_name (cfile, 1, &known);
common/parse.c:879 universe = &dhcp_universe;
common/parse.c:895 option = new_option (MDL);
common/parse.c:907 option -> universe = universe;
The new option gets defines in the dhcp_universe, but _not_ in
dhcp_options!
client/clparse.c:420 parse_option_list (cfile, &config -> required_options);
client/clparse.c:636 if (!strcasecmp (dhcp_options [i].name, val))
The option name is compared against dhcp_options, where it
wasn't added.
How to fix it:
I don't know, if dhcp_options[] is supposed to be an immutable array or
if it should be updated to keep it in sync with dhcp_universe.options.
Depending on this question, the following simple patch might be
sufficient or might be the wrong solution:
--- dhcp3-3.0+3.0.1rc11/client/clparse.c~ 2002-11-17 03:25:43.000000000
+0100
+++ dhcp3-3.0+3.0.1rc11/client/clparse.c 2003-07-21 09:31:12.000000000
+0200
@@ -633,7 +633,7 @@ void parse_option_list (cfile, list)
return;
}
for (i = 0; i < 256; i++) {
- if (!strcasecmp (dhcp_options [i].name, val))
+ if (!strcasecmp (dhcp_universe.options [i]->name, val))
break;
}
if (i == 256) {
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux walker 2.4.22-pre7 #2 Sam Jul 19 11:26:49 CEST 2003 i686
Locale: LANG=de_DE.UTF-8, LC_CTYPE=en_US.UTF-8
Versions of packages dhcp3-client depends on:
ii debconf 1.3.4 Debian configuration management sy
ii debianutils 2.5.4 Miscellaneous utilities specific t
ii dhcp3-common 3.0+3.0.1rc11-5 Common files used by all the dhcp3
ii libc6 2.3.1-17 GNU C Library: Shared libraries an
-- no debconf information
---------------------------------------
Received: (at 202264-done) by bugs.debian.org; 13 Sep 2005 11:02:53 +0000
>From [EMAIL PROTECTED] Tue Sep 13 04:02:53 2005
Return-path: <[EMAIL PROTECTED]>
Received: from ip-svs-1.informatik.uni-oldenburg.de
(aechz.svs.informatik.uni-oldenburg.de) [134.106.12.126]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EF8Yu-0005JI-00; Tue, 13 Sep 2005 04:02:52 -0700
Received: from walker.pmhahn.de (walker.svs.informatik.uni-oldenburg.de
[134.106.22.19])
by aechz.svs.informatik.uni-oldenburg.de (Postfix) with ESMTP id
804F737C9C;
Tue, 13 Sep 2005 13:02:19 +0200 (CEST)
Received: by walker.pmhahn.de (Postfix, from userid 1000)
id DAAFA5D7D9; Tue, 13 Sep 2005 13:01:29 +0200 (CEST)
Date: Tue, 13 Sep 2005 13:01:29 +0200
From: Philipp Matthias Hahn <[EMAIL PROTECTED]>
To: Andrew Pollock <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Subject: Re: dhcp3-client: request user-defined options doesn't work
Message-ID: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[EMAIL PROTECTED]>
Organization: UUCP-Freunde Lahn e.V.
User-Agent: Mutt/1.5.10i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
Hello!
On Tue, Sep 13, 2005 at 06:09:07PM +1000, Andrew Pollock wrote:
> I've taken a look at this patch, but unfortunately in the 2 years and 54
> days since you submitted this bug, the dhcp3-client code has changed a
> lot.
>
> Can you tell me if the problem still exists, and if it does, would you
> mind submitting an updated patch?
The bug seems to be closed as of dhcp3_3.0.3-2:
No. Time Source Destination Protocol Info
3 2.069453 0.0.0.0 255.255.255.255 DHCP DHCP
Discover - Transaction ID 0xfefcf58
Ethernet II, Src: AsustekC_XX:XX:XX (00:e0:18:XX:XX:XX), Dst: Broadcast
(ff:ff:ff:ff:ff:ff)
Internet Protocol, Src: 0.0.0.0 (0.0.0.0), Dst: 255.255.255.255
(255.255.255.255)
User Datagram Protocol, Src Port: bootpc (68), Dst Port: bootps (67)
Bootstrap Protocol
...
Option 55: Parameter Request List
...
170 = Private
171 = Private
172 = Private
...
End Option
Padding
No. Time Source Destination Protocol Info
4 2.072264 XXX.XXX.XX.2 XXX.XXX.XX.19 DHCP DHCP
Offer - Transaction ID 0xfefcf58
Frame 4 (423 bytes on wire, 423 bytes captured)
Ethernet II, Src: DigitalS_XX:XX:XX (00:48:54:XX:XX:XX), Dst: AsustekC_XX:XX:XX
(00:e0:18:XX:XX:XX)
Internet Protocol, Src: XXX.XXX.XX.2 (XXX.XXX.XX.2), Dst: XXX.XXX.XX.19
(XXX.XXX.XX.19)
User Datagram Protocol, Src Port: bootps (67), Dst Port: bootpc (68)
Bootstrap Protocol
...
Option 170: Private (26 bytes)
End Option
No. Time Source Destination Protocol Info
5 2.072835 0.0.0.0 255.255.255.255 DHCP DHCP
Request - Transaction ID 0xfefcf58
Frame 5 (342 bytes on wire, 342 bytes captured)
Ethernet II, Src: AsustekC_XX:XX:XX (00:e0:18:XX:XX:XX), Dst: Broadcast
(ff:ff:ff:ff:ff:ff)
Internet Protocol, Src: 0.0.0.0 (0.0.0.0), Dst: 255.255.255.255
(255.255.255.255)
User Datagram Protocol, Src Port: bootpc (68), Dst Port: bootps (67)
Bootstrap Protocol
...
Option 55: Parameter Request List
...
170 = Private
171 = Private
172 = Private
End Option
Padding
No. Time Source Destination Protocol Info
6 2.073871 XXX.XXX.XX.2 XXX.XXX.XX.19 DHCP DHCP
ACK - Transaction ID 0xfefcf58
Frame 6 (423 bytes on wire, 423 bytes captured)
Ethernet II, Src: DigitalS_XX:XX:XX (00:48:54:XX:XX:XX), Dst: AsustekC_XX:XX:XX
(00:e0:18:XX:XX:XX)
Internet Protocol, Src: XXX.XXX.XX.2 (XXX.XXX.XX.2), Dst: XXX.XXX.XX.19
(XXX.XXX.XX.19)
User Datagram Protocol, Src Port: bootps (67), Dst Port: bootpc (68)
Bootstrap Protocol
...
Option 170: Private (26 bytes)
End Option
BYtE
Philipp
--
Philipp Matthias Hahn <[EMAIL PROTECTED]>
GPG/PGP: 9A540E39 @ keyrings.debian.org
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
