Your message dated Sat, 12 Mar 2011 15:48:44 +0000
with message-id <[email protected]>
and subject line Bug#596014: fixed in forked-daapd 0.13-1
has caused the Debian Bug report #596014,
regarding strip trailing whitespace from artist name and song title
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
596014: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596014
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: forked-daapd
Version: 0.12~git0.11-125-gca72ee5-1
Severity: wishlist
Tags: patch
The id3 tags of some of my MP3s contain trailing whitespace in the
artist or title fields. The whitespace is displayed in iTunes
(in the small display on the top when playing a song) when
playing these MP3s using forked-daapd. This wasn't the case when
using mt-daapd or when playing directly from the iTunes library.
The attached patch fixes this behaviour:
--- /tmp/forked-daapd-0.12~git0.11-125-gca72ee5/src/filescanner.c
2010-08-05 18:28:02.000000000 +0200
+++ /soft/forked-daapd-0.12~git0.11-125-gca72ee5/src/filescanner.c
2010-09-08 00:36:46.000000000 +0200
@@ -131,6 +131,17 @@
return ret;
}
+static void
+trim_string(char *s)
+{
+ char *p;
+
+ for (p = s + strlen(s) - 1; *p == ' ' && p >= s; p--)
+ {
+ *p = '\0';
+ }
+}
+
static void
fixup_tags(struct media_file_info *mfi)
@@ -145,23 +156,50 @@
mfi->genre = NULL;
}
- if (mfi->artist && (strlen(mfi->artist) == 0))
+ if (mfi->artist)
+ {
+ if (strlen(mfi->artist) > 0)
+ {
+ trim_string(mfi->artist);
+ }
+ if (strlen(mfi->artist) == 0)
+ {
+ free(mfi->artist);
+ mfi->artist = NULL;
+ }
+ }
+
+ if (mfi->title)
{
- free(mfi->artist);
- mfi->artist = NULL;
+ if (strlen(mfi->title) > 0)
+ {
+ trim_string(mfi->title);
+ }
+ if (strlen(mfi->title) == 0)
+ {
+ free(mfi->title);
+ mfi->title = NULL;
+ }
}
- if (mfi->title && (strlen(mfi->title) == 0))
+ if (mfi->album)
{
- free(mfi->title);
- mfi->title = NULL;
+ if (strlen(mfi->album) > 0)
+ {
+ trim_string(mfi->album);
+ }
+ if (strlen(mfi->album) == 0)
+ {
+ free(mfi->album);
+ mfi->album = NULL;
+ }
}
if (!mfi->artist)
{
if (mfi->orchestra && mfi->conductor)
{
- len = strlen(mfi->orchestra) + strlen(sep) + strlen(mfi ->conductor);
+ len = strlen(mfi->orchestra) + strlen(sep) + strlen(mfi->conductor);
tag = (char *)malloc(len + 1);
if (tag)
{
--- End Message ---
--- Begin Message ---
Source: forked-daapd
Source-Version: 0.13-1
We believe that the bug you reported is fixed in the latest version of
forked-daapd, which is due to be installed in the Debian FTP archive:
forked-daapd_0.13-1.debian.tar.gz
to main/f/forked-daapd/forked-daapd_0.13-1.debian.tar.gz
forked-daapd_0.13-1.dsc
to main/f/forked-daapd/forked-daapd_0.13-1.dsc
forked-daapd_0.13-1_amd64.deb
to main/f/forked-daapd/forked-daapd_0.13-1_amd64.deb
forked-daapd_0.13.orig.tar.gz
to main/f/forked-daapd/forked-daapd_0.13.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julien BLACHE <[email protected]> (supplier of updated forked-daapd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 12 Mar 2011 14:19:09 +0100
Source: forked-daapd
Binary: forked-daapd
Architecture: source amd64
Version: 0.13-1
Distribution: unstable
Urgency: low
Maintainer: Julien BLACHE <[email protected]>
Changed-By: Julien BLACHE <[email protected]>
Description:
forked-daapd - media server with support for RSP, DAAP, DACP and AirTunes
Closes: 596014 596823 608448 616112
Changes:
forked-daapd (0.13-1) unstable; urgency=low
.
* New upstream release.
+ Improved mDNS address resolution (closes: #608448).
+ Trim metadata strings on insert/update (closes: #596014).
+ Added support for sort fields (closes: #596823).
.
* debian/forked-daapd.init:
+ Fix restart action (closes: #616112).
.
* debian/patches:
+ Drop all patches.
Checksums-Sha1:
f4d553b28b365df8545876b201bb72df76c49fe0 1447 forked-daapd_0.13-1.dsc
b22f3d5c842b5dd00bc8042fb09196ec2e894e69 599084 forked-daapd_0.13.orig.tar.gz
c14f7c73983c1d30dcb3ae08f6b6fc5d51592626 6646 forked-daapd_0.13-1.debian.tar.gz
ab2283b3584b03fdcd7e2372ec5dde02c67f8d13 179326 forked-daapd_0.13-1_amd64.deb
Checksums-Sha256:
5855b761c1fe554f6a23fe81f985bc64f512bf6386476038d35190269af58470 1447
forked-daapd_0.13-1.dsc
37486e46c42993714748fccf2ec05ec3717acb031d3863ed83fa1d829b2eba21 599084
forked-daapd_0.13.orig.tar.gz
3fbcb0c2558662f9cdba0bf09a7cddb372db14b6f02161d56dd5005c3f1eb336 6646
forked-daapd_0.13-1.debian.tar.gz
cd1454efc5b7b2ae3ef756ae6fc643024708b50490b96c7689a7afe9d597c326 179326
forked-daapd_0.13-1_amd64.deb
Files:
156d105962c6fe806bb7efd9517b41dc 1447 sound optional forked-daapd_0.13-1.dsc
d92e12bdc0072594058b761dc2bcc405 599084 sound optional
forked-daapd_0.13.orig.tar.gz
ff8a1ad3fc588b2318b88c68179957e7 6646 sound optional
forked-daapd_0.13-1.debian.tar.gz
5ef56f99c91bb0d2dd95ac20e0398a32 179326 sound optional
forked-daapd_0.13-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iD8DBQFNe3UxzWFP1/XWUWkRAppCAJ4nlwYQaicp+6yd45rsq3dTXwg24gCfZiAq
DQB7d1abs8tv8kE/lGVscZQ=
=MSyx
-----END PGP SIGNATURE-----
--- End Message ---
